mirror/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-12-21 10:25:24 +08:00
Code Issues Packages Projects Releases Wiki Activity
8e0e81ced3
godot/editor/editor_feature_profile.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1059 lines
37 KiB
C++
Raw Normal View History

One Copyright Update to rule them all As many open source projects have started doing it, we're removing the current year from the copyright notice, so that we don't need to bump it every year. It seems like only the first year of publication is technically relevant for copyright notices, and even that seems to be something that many companies stopped listing altogether (in a version controlled codebase, the commits are a much better source of date of publication than a hardcoded copyright statement). We also now list Godot Engine contributors first as we're collectively the current maintainers of the project, and we clarify that the "exclusive" copyright of the co-founders covers the timespan before opensourcing (their further contributions are included as part of Godot Engine contributors). Also fixed "cf." Frenchism - it's meant as "refer to / see".
2023-01-05 20:25:55 +08:00
/**************************************************************************/
/* editor_feature_profile.cpp */
/**************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
/* https://godotengine.org */
/**************************************************************************/
/* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */
/* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/**************************************************************************/
Add missing license headers Make `fix_headers.py` script compatible with Python 3.
2019-06-11 21:31:23 +08:00
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
#include "editor_feature_profile.h"
Fix build after merge of #37235 It used APIs that were changed after the PR was last rebased.
2020-05-25 19:10:28 +08:00
Core: Move DirAccess and FileAccess to `core/io` File handling APIs are typically considered part of I/O, and we did have most `FileAccess` implementations in `core/io` already.
2021-06-11 20:51:48 +08:00
#include "core/io/dir_access.h"
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
#include "core/io/json.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 09:46:22 +08:00
#include "editor/editor_node.h"
Move editor paths into the EditorPaths class
2022-07-29 08:36:26 +08:00
#include "editor/editor_paths.h"
i18n: Make property paths and categories translatable
2022-03-03 18:25:11 +08:00
#include "editor/editor_property_name_processor.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 09:46:22 +08:00
#include "editor/editor_scale.h"
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
#include "editor/editor_settings.h"
Improve includes of EditorNode (and everything else) Also start organizing editor-specific GUI components into a dedicated folder, `editor/gui`. Also move `editor_file_server` next to the rest of debugger classes.
2023-04-08 00:59:49 +08:00
#include "editor/gui/editor_file_dialog.h"
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
const char *EditorFeatureProfile::feature_names[FEATURE_MAX] = {
TTRC("3D Editor"),
TTRC("Script Editor"),
TTRC("Asset Library"),
TTRC("Scene Tree Editing"),
TTRC("Node Dock"),
Make the Import dock depend on the FileSystem dock
2020-05-09 03:51:42 +08:00
TTRC("FileSystem Dock"),
TTRC("Import Dock"),
Allow to disable History Dock via feature profile
2022-11-07 03:53:20 +08:00
TTRC("History Dock"),
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
};
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
const char *EditorFeatureProfile::feature_descriptions[FEATURE_MAX] = {
TTRC("Allows to view and edit 3D scenes."),
TTRC("Allows to edit scripts using the integrated script editor."),
TTRC("Provides built-in access to the Asset Library."),
TTRC("Allows editing the node hierarchy in the Scene dock."),
TTRC("Allows to work with signals and groups of the node selected in the Scene dock."),
TTRC("Allows to browse the local file system via a dedicated dock."),
TTRC("Allows to configure import settings for individual assets. Requires the FileSystem dock to function."),
Allow to disable History Dock via feature profile
2022-11-07 03:53:20 +08:00
TTRC("Provides an overview of the editor's and each scene's undo history."),
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
};
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
const char *EditorFeatureProfile::feature_identifiers[FEATURE_MAX] = {
"3d",
"script",
"asset_lib",
"scene_tree",
"node_dock",
Make the Import dock depend on the FileSystem dock
2020-05-09 03:51:42 +08:00
"filesystem_dock",
"import_dock",
Allow to disable History Dock via feature profile
2022-11-07 03:53:20 +08:00
"history_dock",
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
};
void EditorFeatureProfile::set_disable_class(const StringName &p_class, bool p_disabled) {
if (p_disabled) {
disabled_classes.insert(p_class);
} else {
disabled_classes.erase(p_class);
}
}
bool EditorFeatureProfile::is_class_disabled(const StringName &p_class) const {
Add ignoring of disabled recent and favorite classes in create
2019-11-07 22:08:01 +08:00
if (p_class == StringName()) {
return false;
}
return disabled_classes.has(p_class) || is_class_disabled(ClassDB::get_parent_class_nocheck(p_class));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
void EditorFeatureProfile::set_disable_class_editor(const StringName &p_class, bool p_disabled) {
if (p_disabled) {
disabled_editors.insert(p_class);
} else {
disabled_editors.erase(p_class);
}
}
bool EditorFeatureProfile::is_class_editor_disabled(const StringName &p_class) const {
Add ignoring of disabled recent and favorite classes in create
2019-11-07 22:08:01 +08:00
if (p_class == StringName()) {
return false;
}
return disabled_editors.has(p_class) || is_class_editor_disabled(ClassDB::get_parent_class_nocheck(p_class));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
void EditorFeatureProfile::set_disable_class_property(const StringName &p_class, const StringName &p_property, bool p_disabled) {
if (p_disabled) {
if (!disabled_properties.has(p_class)) {
Add a new HashSet template * Intended to replace RBSet in most cases. * Optimized for iteration speed
2022-05-19 23:00:06 +08:00
disabled_properties[p_class] = HashSet<StringName>();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
disabled_properties[p_class].insert(p_property);
} else {
ERR_FAIL_COND(!disabled_properties.has(p_class));
disabled_properties[p_class].erase(p_property);
Rename empty() to is_empty()
2020-12-15 20:04:21 +08:00
if (disabled_properties[p_class].is_empty()) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
disabled_properties.erase(p_class);
}
}
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 20:29:06 +08:00
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
bool EditorFeatureProfile::is_class_property_disabled(const StringName &p_class, const StringName &p_property) const {
if (!disabled_properties.has(p_class)) {
return false;
}
if (!disabled_properties[p_class].has(p_property)) {
return false;
}
return true;
}
bool EditorFeatureProfile::has_class_properties_disabled(const StringName &p_class) const {
return disabled_properties.has(p_class);
}
Fixed changing enabled classes resetting folding in manage editor features.
2021-05-27 22:19:33 +08:00
void EditorFeatureProfile::set_item_collapsed(const StringName &p_class, bool p_collapsed) {
if (p_collapsed) {
collapsed_classes.insert(p_class);
} else {
collapsed_classes.erase(p_class);
}
}
bool EditorFeatureProfile::is_item_collapsed(const StringName &p_class) const {
return collapsed_classes.has(p_class);
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
void EditorFeatureProfile::set_disable_feature(Feature p_feature, bool p_disable) {
ERR_FAIL_INDEX(p_feature, FEATURE_MAX);
features_disabled[p_feature] = p_disable;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 20:29:06 +08:00
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
bool EditorFeatureProfile::is_feature_disabled(Feature p_feature) const {
ERR_FAIL_INDEX_V(p_feature, FEATURE_MAX, false);
return features_disabled[p_feature];
}
String EditorFeatureProfile::get_feature_name(Feature p_feature) {
ERR_FAIL_INDEX_V(p_feature, FEATURE_MAX, String());
return feature_names[p_feature];
}
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
String EditorFeatureProfile::get_feature_description(Feature p_feature) {
ERR_FAIL_INDEX_V(p_feature, FEATURE_MAX, String());
return feature_descriptions[p_feature];
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Error EditorFeatureProfile::save_to_file(const String &p_path) {
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
Dictionary data;
data["type"] = "feature_profile";
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Array dis_classes;
Use range iterators for RBSet in most cases
2022-05-19 07:43:40 +08:00
for (const StringName &E : disabled_classes) {
dis_classes.push_back(String(E));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
dis_classes.sort();
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
data["disabled_classes"] = dis_classes;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Array dis_editors;
Use range iterators for RBSet in most cases
2022-05-19 07:43:40 +08:00
for (const StringName &E : disabled_editors) {
dis_editors.push_back(String(E));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
dis_editors.sort();
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
data["disabled_editors"] = dis_editors;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Array dis_props;
Add a new HashSet template * Intended to replace RBSet in most cases. * Optimized for iteration speed
2022-05-19 23:00:06 +08:00
for (KeyValue<StringName, HashSet<StringName>> &E : disabled_properties) {
Use range iterators for RBSet in most cases
2022-05-19 07:43:40 +08:00
for (const StringName &F : E.value) {
dis_props.push_back(String(E.key) + ":" + String(F));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
}
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
data["disabled_properties"] = dis_props;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Array dis_features;
for (int i = 0; i < FEATURE_MAX; i++) {
if (features_disabled[i]) {
dis_features.push_back(feature_identifiers[i]);
}
}
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
data["disabled_features"] = dis_features;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Make FileAccess and DirAccess classes reference counted.
2022-03-23 17:08:58 +08:00
Ref<FileAccess> f = FileAccess::open(p_path, FileAccess::WRITE);
ERR_FAIL_COND_V_MSG(f.is_null(), ERR_CANT_CREATE, "Cannot create file '" + p_path + "'.");
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
JSON json;
String text = json.stringify(data, "\t");
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
f->store_string(text);
return OK;
}
Error EditorFeatureProfile::load_from_file(const String &p_path) {
Error err;
String text = FileAccess::get_file_as_string(p_path, &err);
if (err != OK) {
return err;
}
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
JSON json;
err = json.parse(text);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
if (err != OK) {
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
ERR_PRINT("Error parsing '" + p_path + "' on line " + itos(json.get_error_line()) + ": " + json.get_error_message());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
return ERR_PARSE_ERROR;
}
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
Dictionary data = json.get_data();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
if (!data.has("type") || String(data["type"]) != "feature_profile") {
Remove duplicate ERR_PRINT macro.
2019-11-07 00:03:04 +08:00
ERR_PRINT("Error parsing '" + p_path + "', it's not a feature profile.");
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
return ERR_PARSE_ERROR;
}
disabled_classes.clear();
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
if (data.has("disabled_classes")) {
Array disabled_classes_arr = data["disabled_classes"];
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
for (int i = 0; i < disabled_classes_arr.size(); i++) {
disabled_classes.insert(disabled_classes_arr[i]);
}
}
disabled_editors.clear();
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
if (data.has("disabled_editors")) {
Array disabled_editors_arr = data["disabled_editors"];
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
for (int i = 0; i < disabled_editors_arr.size(); i++) {
disabled_editors.insert(disabled_editors_arr[i]);
}
}
disabled_properties.clear();
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
if (data.has("disabled_properties")) {
Array disabled_properties_arr = data["disabled_properties"];
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
for (int i = 0; i < disabled_properties_arr.size(); i++) {
String s = disabled_properties_arr[i];
set_disable_class_property(s.get_slice(":", 0), s.get_slice(":", 1), true);
}
}
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-30 02:12:33 +08:00
if (data.has("disabled_features")) {
Array disabled_features_arr = data["disabled_features"];
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
for (int i = 0; i < FEATURE_MAX; i++) {
bool found = false;
String f = feature_identifiers[i];
for (int j = 0; j < disabled_features_arr.size(); j++) {
String fd = disabled_features_arr[j];
if (fd == f) {
found = true;
break;
}
}
features_disabled[i] = found;
}
}
return OK;
}
void EditorFeatureProfile::_bind_methods() {
ClassDB::bind_method(D_METHOD("set_disable_class", "class_name", "disable"), &EditorFeatureProfile::set_disable_class);
ClassDB::bind_method(D_METHOD("is_class_disabled", "class_name"), &EditorFeatureProfile::is_class_disabled);
ClassDB::bind_method(D_METHOD("set_disable_class_editor", "class_name", "disable"), &EditorFeatureProfile::set_disable_class_editor);
ClassDB::bind_method(D_METHOD("is_class_editor_disabled", "class_name"), &EditorFeatureProfile::is_class_editor_disabled);
doc: Sync classref with current source Fix a few missing bindings or unspecified argument names and default values.
2019-09-24 17:44:48 +08:00
ClassDB::bind_method(D_METHOD("set_disable_class_property", "class_name", "property", "disable"), &EditorFeatureProfile::set_disable_class_property);
ClassDB::bind_method(D_METHOD("is_class_property_disabled", "class_name", "property"), &EditorFeatureProfile::is_class_property_disabled);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
ClassDB::bind_method(D_METHOD("set_disable_feature", "feature", "disable"), &EditorFeatureProfile::set_disable_feature);
ClassDB::bind_method(D_METHOD("is_feature_disabled", "feature"), &EditorFeatureProfile::is_feature_disabled);
ClassDB::bind_method(D_METHOD("get_feature_name", "feature"), &EditorFeatureProfile::_get_feature_name);
ClassDB::bind_method(D_METHOD("save_to_file", "path"), &EditorFeatureProfile::save_to_file);
ClassDB::bind_method(D_METHOD("load_from_file", "path"), &EditorFeatureProfile::load_from_file);
BIND_ENUM_CONSTANT(FEATURE_3D);
BIND_ENUM_CONSTANT(FEATURE_SCRIPT);
BIND_ENUM_CONSTANT(FEATURE_ASSET_LIB);
BIND_ENUM_CONSTANT(FEATURE_SCENE_TREE);
BIND_ENUM_CONSTANT(FEATURE_NODE_DOCK);
BIND_ENUM_CONSTANT(FEATURE_FILESYSTEM_DOCK);
doc: Sync classref with current source
2020-09-04 16:43:11 +08:00
BIND_ENUM_CONSTANT(FEATURE_IMPORT_DOCK);
Allow to disable History Dock via feature profile
2022-11-07 03:53:20 +08:00
BIND_ENUM_CONSTANT(FEATURE_HISTORY_DOCK);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
BIND_ENUM_CONSTANT(FEATURE_MAX);
}
Fix some stuff with the editor features
2022-09-21 09:36:39 +08:00
EditorFeatureProfile::EditorFeatureProfile() {
for (int i = 0; i < FEATURE_MAX; i++) {
features_disabled[i] = false;
}
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
//////////////////////////
void EditorFeatureProfileManager::_notification(int p_what) {
Port existing _notification code to use switch statements (part 1/3)
2022-02-16 07:52:32 +08:00
switch (p_what) {
case NOTIFICATION_READY: {
current_profile = EDITOR_GET("_default_feature_profile");
if (!current_profile.is_empty()) {
current.instantiate();
Rename String `plus_file` to `path_join`
2022-08-30 08:34:01 +08:00
Error err = current->load_from_file(EditorPaths::get_singleton()->get_feature_profiles_dir().path_join(current_profile + ".profile"));
Port existing _notification code to use switch statements (part 1/3)
2022-02-16 07:52:32 +08:00
if (err != OK) {
ERR_PRINT("Error loading default feature profile: " + current_profile);
current_profile = String();
current.unref();
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
Port existing _notification code to use switch statements (part 1/3)
2022-02-16 07:52:32 +08:00
_update_profile_list(current_profile);
} break;
Rebuild the trees in the EditorFeatureProfile dialog when the editor theme changes
2022-08-06 00:17:58 +08:00
case NOTIFICATION_THEME_CHANGED: {
// Make sure that the icons are correctly adjusted if the theme's lightness was switched.
_update_selected_profile();
} break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
}
String EditorFeatureProfileManager::_get_selected_profile() {
int idx = profile_list->get_selected();
if (idx < 0) {
return String();
}
return profile_list->get_item_metadata(idx);
}
void EditorFeatureProfileManager::_update_profile_list(const String &p_select_profile) {
String selected_profile;
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
if (p_select_profile.is_empty()) { //default, keep
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
if (profile_list->get_selected() >= 0) {
selected_profile = profile_list->get_item_metadata(profile_list->get_selected());
Rename String `plus_file` to `path_join`
2022-08-30 08:34:01 +08:00
if (!FileAccess::exists(EditorPaths::get_singleton()->get_feature_profiles_dir().path_join(selected_profile + ".profile"))) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
selected_profile = String(); //does not exist
}
}
} else {
selected_profile = p_select_profile;
}
Vector<String> profiles;
Move editor paths into the EditorPaths class
2022-07-29 08:36:26 +08:00
Ref<DirAccess> d = DirAccess::open(EditorPaths::get_singleton()->get_feature_profiles_dir());
ERR_FAIL_COND_MSG(d.is_null(), "Cannot open directory '" + EditorPaths::get_singleton()->get_feature_profiles_dir() + "'.");
Added some obvious errors explanations
2019-09-25 16:28:50 +08:00
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
d->list_dir_begin();
while (true) {
String f = d->get_next();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
if (f.is_empty()) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
break;
}
if (!d->current_is_dir()) {
Remove String::find_last (same as rfind)
2020-07-03 21:26:22 +08:00
int last_pos = f.rfind(".profile");
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
if (last_pos != -1) {
profiles.push_back(f.substr(0, last_pos));
}
}
}
profiles.sort();
profile_list->clear();
for (int i = 0; i < profiles.size(); i++) {
String name = profiles[i];
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
if (i == 0 && selected_profile.is_empty()) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
selected_profile = name;
}
if (name == current_profile) {
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
name += " " + TTR("(current)");
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
profile_list->add_item(name);
int index = profile_list->get_item_count() - 1;
profile_list->set_item_metadata(index, profiles[i]);
if (profiles[i] == selected_profile) {
profile_list->select(index);
}
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
class_list_vbc->set_visible(!selected_profile.is_empty());
property_list_vbc->set_visible(!selected_profile.is_empty());
no_profile_selected_help->set_visible(selected_profile.is_empty());
profile_actions[PROFILE_CLEAR]->set_disabled(current_profile.is_empty());
profile_actions[PROFILE_ERASE]->set_disabled(selected_profile.is_empty());
profile_actions[PROFILE_EXPORT]->set_disabled(selected_profile.is_empty());
profile_actions[PROFILE_SET]->set_disabled(selected_profile.is_empty());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
current_profile_name->set_text(!current_profile.is_empty() ? current_profile : TTR("(none)"));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
_update_selected_profile();
}
void EditorFeatureProfileManager::_profile_action(int p_action) {
switch (p_action) {
case PROFILE_CLEAR: {
Allow changing feature profile via EditorInterface
2023-03-05 03:27:56 +08:00
set_current_profile("", false);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
} break;
case PROFILE_SET: {
String selected = _get_selected_profile();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
ERR_FAIL_COND(selected.is_empty());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
if (selected == current_profile) {
Enhancements and fixes for the editor feature profile
2019-06-05 12:12:08 +08:00
return; // Nothing to do here.
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
Allow changing feature profile via EditorInterface
2023-03-05 03:27:56 +08:00
set_current_profile(selected, false);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
} break;
case PROFILE_IMPORT: {
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-12 00:45:19 +08:00
import_profiles->popup_file_dialog();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
} break;
case PROFILE_EXPORT: {
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-12 00:45:19 +08:00
export_profile->popup_file_dialog();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
export_profile->set_current_file(_get_selected_profile() + ".profile");
} break;
case PROFILE_NEW: {
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
new_profile_dialog->popup_centered(Size2(240, 60) * EDSCALE);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
new_profile_name->clear();
new_profile_name->grab_focus();
} break;
case PROFILE_ERASE: {
String selected = _get_selected_profile();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
ERR_FAIL_COND(selected.is_empty());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
erase_profile_dialog->set_text(vformat(TTR("Remove currently selected profile, '%s'? Cannot be undone."), selected));
erase_profile_dialog->popup_centered(Size2(240, 60) * EDSCALE);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
} break;
}
}
void EditorFeatureProfileManager::_erase_selected_profile() {
String selected = _get_selected_profile();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
ERR_FAIL_COND(selected.is_empty());
Move editor paths into the EditorPaths class
2022-07-29 08:36:26 +08:00
Ref<DirAccess> da = DirAccess::open(EditorPaths::get_singleton()->get_feature_profiles_dir());
ERR_FAIL_COND_MSG(da.is_null(), "Cannot open directory '" + EditorPaths::get_singleton()->get_feature_profiles_dir() + "'.");
Added some obvious errors explanations
2019-09-25 16:28:50 +08:00
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
da->remove(selected + ".profile");
if (selected == current_profile) {
_profile_action(PROFILE_CLEAR);
} else {
_update_profile_list();
}
}
void EditorFeatureProfileManager::_create_new_profile() {
String name = new_profile_name->get_text().strip_edges();
String: Add contains().
2022-02-04 00:03:38 +08:00
if (!name.is_valid_filename() || name.contains(".")) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
EditorNode::get_singleton()->show_warning(TTR("Profile must be a valid filename and must not contain '.'"));
return;
}
Rename String `plus_file` to `path_join`
2022-08-30 08:34:01 +08:00
String file = EditorPaths::get_singleton()->get_feature_profiles_dir().path_join(name + ".profile");
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
if (FileAccess::exists(file)) {
EditorNode::get_singleton()->show_warning(TTR("Profile with this name already exists."));
return;
}
Ref<EditorFeatureProfile> new_profile;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 06:03:09 +08:00
new_profile.instantiate();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
new_profile->save_to_file(file);
_update_profile_list(name);
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
// The newly created profile is the first one, make it the current profile automatically.
if (profile_list->get_item_count() == 1) {
_profile_action(PROFILE_SET);
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
void EditorFeatureProfileManager::_profile_selected(int p_what) {
_update_selected_profile();
}
void EditorFeatureProfileManager::_fill_classes_from(TreeItem *p_parent, const String &p_class, const String &p_selected) {
TreeItem *class_item = class_list->create_item(p_parent);
class_item->set_cell_mode(0, TreeItem::CELL_MODE_CHECK);
class_item->set_icon(0, EditorNode::get_singleton()->get_class_icon(p_class, "Node"));
String text = p_class;
bool disabled = edited->is_class_disabled(p_class);
bool disabled_editor = edited->is_class_editor_disabled(p_class);
bool disabled_properties = edited->has_class_properties_disabled(p_class);
if (disabled) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-18 05:22:52 +08:00
class_item->set_custom_color(0, class_list->get_theme_color(SNAME("disabled_font_color"), SNAME("Editor")));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
} else if (disabled_editor && disabled_properties) {
text += " " + TTR("(Editor Disabled, Properties Disabled)");
} else if (disabled_properties) {
text += " " + TTR("(Properties Disabled)");
} else if (disabled_editor) {
text += " " + TTR("(Editor Disabled)");
}
class_item->set_text(0, text);
class_item->set_editable(0, true);
class_item->set_selectable(0, true);
class_item->set_metadata(0, p_class);
Fixed changing enabled classes resetting folding in manage editor features.
2021-05-27 22:19:33 +08:00
bool collapsed = edited->is_item_collapsed(p_class);
class_item->set_collapsed(collapsed);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
if (p_class == p_selected) {
class_item->select(0);
}
if (disabled) {
//class disabled, do nothing else (do not show further)
return;
}
class_item->set_checked(0, true); // if its not disabled, its checked
List<StringName> child_classes;
ClassDB::get_direct_inheriters_from_class(p_class, &child_classes);
child_classes.sort_custom<StringName::AlphCompare>();
Use const references where possible for List range iterators
2021-07-24 21:46:25 +08:00
for (const StringName &name : child_classes) {
Use C++ iterators for Lists in many situations
2021-07-16 11:45:57 +08:00
if (String(name).begins_with("Editor") || ClassDB::get_api_type(name) != ClassDB::API_CORE) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
continue;
}
_fill_classes_from(class_item, name, p_selected);
}
}
void EditorFeatureProfileManager::_class_list_item_selected() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 22:41:43 +08:00
if (updating_features) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 22:41:43 +08:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
property_list->clear();
TreeItem *item = class_list->get_selected();
if (!item) {
return;
}
Variant md = item->get_metadata(0);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
if (md.get_type() == Variant::STRING || md.get_type() == Variant::STRING_NAME) {
String class_name = md;
String class_description;
DocTools *dd = EditorHelp::get_doc_data();
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 21:04:37 +08:00
HashMap<String, DocData::ClassDoc>::Iterator E = dd->class_list.find(class_name);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
if (E) {
Replace most uses of Map by HashMap * Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-05-13 21:04:37 +08:00
class_description = DTR(E->value.brief_description);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
}
description_bit->set_text(class_description);
} else if (md.get_type() == Variant::INT) {
int feature_id = md;
String feature_description = EditorFeatureProfile::get_feature_description(EditorFeatureProfile::Feature(feature_id));
Fix various i18n failures
2021-08-03 23:53:36 +08:00
description_bit->set_text(TTRGET(feature_description));
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
return;
} else {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
return;
}
String class_name = md;
if (edited->is_class_disabled(class_name)) {
return;
}
updating_features = true;
TreeItem *root = property_list->create_item();
TreeItem *options = property_list->create_item(root);
options->set_text(0, TTR("Class Options:"));
{
TreeItem *option = property_list->create_item(options);
option->set_cell_mode(0, TreeItem::CELL_MODE_CHECK);
option->set_editable(0, true);
option->set_selectable(0, true);
Changes to to feature profile editor Changed "Disable Editor" to "Contextual Editor Enabled" Do not show contextual editors for disabled classes.
2019-04-09 07:20:20 +08:00
option->set_checked(0, !edited->is_class_editor_disabled(class_name));
option->set_text(0, TTR("Enable Contextual Editor"));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
option->set_metadata(0, CLASS_OPTION_DISABLE_EDITOR);
}
List<PropertyInfo> props;
ClassDB::get_property_list(class_name, &props, true);
Don't display empty Class Properties in feature profile
2022-02-07 18:55:17 +08:00
bool has_editor_props = false;
for (const PropertyInfo &E : props) {
if (E.usage & PROPERTY_USAGE_EDITOR) {
has_editor_props = true;
break;
}
}
if (has_editor_props) {
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
TreeItem *properties = property_list->create_item(root);
properties->set_text(0, TTR("Class Properties:"));
Add property name style toggle to Inspector
2022-03-23 09:46:59 +08:00
const EditorPropertyNameProcessor::Style text_style = EditorPropertyNameProcessor::get_settings_style();
const EditorPropertyNameProcessor::Style tooltip_style = EditorPropertyNameProcessor::get_tooltip_style(text_style);
Use const references where possible for List range iterators
2021-07-24 21:46:25 +08:00
for (const PropertyInfo &E : props) {
Use C++ iterators for Lists in many situations
2021-07-16 11:45:57 +08:00
String name = E.name;
if (!(E.usage & PROPERTY_USAGE_EDITOR)) {
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
continue;
}
Add property name style toggle to Inspector
2022-03-23 09:46:59 +08:00
const String text = EditorPropertyNameProcessor::get_singleton()->process_name(name, text_style);
const String tooltip = EditorPropertyNameProcessor::get_singleton()->process_name(name, tooltip_style);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
TreeItem *property = property_list->create_item(properties);
property->set_cell_mode(0, TreeItem::CELL_MODE_CHECK);
property->set_editable(0, true);
property->set_selectable(0, true);
property->set_checked(0, !edited->is_class_property_disabled(class_name, name));
Add property name style toggle to Inspector
2022-03-23 09:46:59 +08:00
property->set_text(0, text);
Rename TreeItem's `set_tooltip` to `set_tooltip_text` `set_tooltip` -> `set_tooltip_text` `get_tooltip` -> `get_tooltip_text` For consistency: `get_button_tooltip` -> `get_button_tooltip_text` And the `tooltip` parameter in `add_button` was renamed to `tooltip_text`
2022-08-29 21:55:49 +08:00
property->set_tooltip_text(0, tooltip);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
property->set_metadata(0, name);
Use C++ iterators for Lists in many situations
2021-07-16 11:45:57 +08:00
String icon_type = Variant::get_type_name(E.type);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
property->set_icon(0, EditorNode::get_singleton()->get_class_icon(icon_type));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 22:41:43 +08:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
updating_features = false;
}
void EditorFeatureProfileManager::_class_list_item_edited() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 22:41:43 +08:00
if (updating_features) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 22:41:43 +08:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
TreeItem *item = class_list->get_edited();
if (!item) {
return;
}
bool checked = item->is_checked(0);
Variant md = item->get_metadata(0);
Added StringName as a variant type. Also changed all relevant properties defined manually to StringName.
2020-02-21 05:58:05 +08:00
if (md.get_type() == Variant::STRING || md.get_type() == Variant::STRING_NAME) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
String class_selected = md;
edited->set_disable_class(class_selected, !checked);
_save_and_update();
_update_selected_profile();
} else if (md.get_type() == Variant::INT) {
int feature_selected = md;
edited->set_disable_feature(EditorFeatureProfile::Feature(feature_selected), !checked);
_save_and_update();
}
}
Fixed changing enabled classes resetting folding in manage editor features.
2021-05-27 22:19:33 +08:00
void EditorFeatureProfileManager::_class_list_item_collapsed(Object *p_item) {
if (updating_features) {
return;
}
TreeItem *item = Object::cast_to<TreeItem>(p_item);
if (!item) {
return;
}
Variant md = item->get_metadata(0);
if (md.get_type() != Variant::STRING && md.get_type() != Variant::STRING_NAME) {
return;
}
String class_name = md;
bool collapsed = item->is_collapsed();
edited->set_item_collapsed(class_name, collapsed);
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
void EditorFeatureProfileManager::_property_item_edited() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 22:41:43 +08:00
if (updating_features) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 22:41:43 +08:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
TreeItem *class_item = class_list->get_selected();
if (!class_item) {
return;
}
Variant md = class_item->get_metadata(0);
Added StringName as a variant type. Also changed all relevant properties defined manually to StringName.
2020-02-21 05:58:05 +08:00
if (md.get_type() != Variant::STRING && md.get_type() != Variant::STRING_NAME) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
return;
}
String class_name = md;
TreeItem *item = property_list->get_edited();
if (!item) {
return;
}
bool checked = item->is_checked(0);
md = item->get_metadata(0);
Added StringName as a variant type. Also changed all relevant properties defined manually to StringName.
2020-02-21 05:58:05 +08:00
if (md.get_type() == Variant::STRING || md.get_type() == Variant::STRING_NAME) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
String property_selected = md;
edited->set_disable_class_property(class_name, property_selected, !checked);
_save_and_update();
_update_selected_profile();
} else if (md.get_type() == Variant::INT) {
int feature_selected = md;
switch (feature_selected) {
case CLASS_OPTION_DISABLE_EDITOR: {
Changes to to feature profile editor Changed "Disable Editor" to "Contextual Editor Enabled" Do not show contextual editors for disabled classes.
2019-04-09 07:20:20 +08:00
edited->set_disable_class_editor(class_name, !checked);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
_save_and_update();
_update_selected_profile();
} break;
}
}
}
void EditorFeatureProfileManager::_update_selected_profile() {
String class_selected;
int feature_selected = -1;
if (class_list->get_selected()) {
Variant md = class_list->get_selected()->get_metadata(0);
Added StringName as a variant type. Also changed all relevant properties defined manually to StringName.
2020-02-21 05:58:05 +08:00
if (md.get_type() == Variant::STRING || md.get_type() == Variant::STRING_NAME) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
class_selected = md;
} else if (md.get_type() == Variant::INT) {
feature_selected = md;
}
}
class_list->clear();
String profile = _get_selected_profile();
Fix some stuff with the editor features
2022-09-21 09:36:39 +08:00
profile_actions[PROFILE_SET]->set_disabled(profile == current_profile);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
if (profile.is_empty()) { //nothing selected, nothing edited
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
property_list->clear();
edited.unref();
return;
}
if (profile == current_profile) {
edited = current; //reuse current profile (which is what editor uses)
ERR_FAIL_COND(current.is_null()); //nothing selected, current should never be null
} else {
//reload edited, if different from current
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 06:03:09 +08:00
edited.instantiate();
Rename String `plus_file` to `path_join`
2022-08-30 08:34:01 +08:00
Error err = edited->load_from_file(EditorPaths::get_singleton()->get_feature_profiles_dir().path_join(profile + ".profile"));
ERR_FAIL_COND_MSG(err != OK, "Error when loading editor feature profile from file '" + EditorPaths::get_singleton()->get_feature_profiles_dir().path_join(profile + ".profile") + "'.");
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
updating_features = true;
TreeItem *root = class_list->create_item();
TreeItem *features = class_list->create_item(root);
Fix various -Wmaybe-uninitialized warnings from GCC 12.2.1 Not sure why I didn't get those before, it may be due to upstream changes (12.2.1 is a moving target, it's basically 12.3-dev), or simply rebuilding Godot from scratch with different options.
2022-09-22 15:25:47 +08:00
TreeItem *last_feature = nullptr;
Put multiple colons back into translated strings
2021-08-01 01:08:07 +08:00
features->set_text(0, TTR("Main Features:"));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
for (int i = 0; i < EditorFeatureProfile::FEATURE_MAX; i++) {
Make the Import dock depend on the FileSystem dock
2020-05-09 03:51:42 +08:00
TreeItem *feature;
if (i == EditorFeatureProfile::FEATURE_IMPORT_DOCK) {
feature = class_list->create_item(last_feature);
} else {
feature = class_list->create_item(features);
last_feature = feature;
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
feature->set_cell_mode(0, TreeItem::CELL_MODE_CHECK);
feature->set_text(0, TTRGET(EditorFeatureProfile::get_feature_name(EditorFeatureProfile::Feature(i))));
feature->set_selectable(0, true);
feature->set_editable(0, true);
feature->set_metadata(0, i);
if (!edited->is_feature_disabled(EditorFeatureProfile::Feature(i))) {
feature->set_checked(0, true);
}
if (i == feature_selected) {
feature->select(0);
}
}
TreeItem *classes = class_list->create_item(root);
Put multiple colons back into translated strings
2021-08-01 01:08:07 +08:00
classes->set_text(0, TTR("Nodes and Classes:"));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
_fill_classes_from(classes, "Node", class_selected);
_fill_classes_from(classes, "Resource", class_selected);
updating_features = false;
_class_list_item_selected();
}
void EditorFeatureProfileManager::_import_profiles(const Vector<String> &p_paths) {
//test it first
for (int i = 0; i < p_paths.size(); i++) {
Ref<EditorFeatureProfile> profile;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 06:03:09 +08:00
profile.instantiate();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Error err = profile->load_from_file(p_paths[i]);
String basefile = p_paths[i].get_file();
if (err != OK) {
EditorNode::get_singleton()->show_warning(vformat(TTR("File '%s' format is invalid, import aborted."), basefile));
return;
}
Rename String `plus_file` to `path_join`
2022-08-30 08:34:01 +08:00
String dst_file = EditorPaths::get_singleton()->get_feature_profiles_dir().path_join(basefile);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
if (FileAccess::exists(dst_file)) {
Fix minor typos
2019-06-17 20:11:49 +08:00
EditorNode::get_singleton()->show_warning(vformat(TTR("Profile '%s' already exists. Remove it first before importing, import aborted."), basefile.get_basename()));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
return;
}
}
//do it second
for (int i = 0; i < p_paths.size(); i++) {
Ref<EditorFeatureProfile> profile;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-18 06:03:09 +08:00
profile.instantiate();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Error err = profile->load_from_file(p_paths[i]);
ERR_CONTINUE(err != OK);
String basefile = p_paths[i].get_file();
Rename String `plus_file` to `path_join`
2022-08-30 08:34:01 +08:00
String dst_file = EditorPaths::get_singleton()->get_feature_profiles_dir().path_join(basefile);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
profile->save_to_file(dst_file);
}
_update_profile_list();
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
// The newly imported profile is the first one, make it the current profile automatically.
if (profile_list->get_item_count() == 1) {
_profile_action(PROFILE_SET);
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
void EditorFeatureProfileManager::_export_profile(const String &p_path) {
ERR_FAIL_COND(edited.is_null());
Error err = edited->save_to_file(p_path);
if (err != OK) {
EditorNode::get_singleton()->show_warning(vformat(TTR("Error saving profile to path: '%s'."), p_path));
}
}
void EditorFeatureProfileManager::_save_and_update() {
String edited_path = _get_selected_profile();
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 17:42:46 +08:00
ERR_FAIL_COND(edited_path.is_empty());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
ERR_FAIL_COND(edited.is_null());
Rename String `plus_file` to `path_join`
2022-08-30 08:34:01 +08:00
edited->save_to_file(EditorPaths::get_singleton()->get_feature_profiles_dir().path_join(edited_path + ".profile"));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
if (edited == current) {
update_timer->start();
}
}
void EditorFeatureProfileManager::_emit_current_profile_changed() {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-18 05:22:52 +08:00
emit_signal(SNAME("current_feature_profile_changed"));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
}
void EditorFeatureProfileManager::notify_changed() {
_emit_current_profile_changed();
}
Ref<EditorFeatureProfile> EditorFeatureProfileManager::get_current_profile() {
return current;
}
Allow changing feature profile via EditorInterface
2023-03-05 03:27:56 +08:00
String EditorFeatureProfileManager::get_current_profile_name() const {
return current_profile;
}
void EditorFeatureProfileManager::set_current_profile(const String &p_profile_name, bool p_validate_profile) {
if (p_validate_profile && !p_profile_name.is_empty()) {
// Profile may not exist.
Ref<DirAccess> da = DirAccess::open(EditorPaths::get_singleton()->get_feature_profiles_dir());
ERR_FAIL_COND_MSG(da.is_null(), "Cannot open directory '" + EditorPaths::get_singleton()->get_feature_profiles_dir() + "'.");
ERR_FAIL_COND_MSG(!da->file_exists(p_profile_name + ".profile"), "Feature profile '" + p_profile_name + "' does not exist.");
// Change profile selection to emulate the UI interaction. Otherwise, the wrong profile would get activated.
// FIXME: Ideally, _update_selected_profile() should not rely on the user interface state to function properly.
for (int i = 0; i < profile_list->get_item_count(); i++) {
if (profile_list->get_item_metadata(i) == p_profile_name) {
profile_list->select(i);
break;
}
}
_update_selected_profile();
}
// Store in editor settings.
EditorSettings::get_singleton()->set("_default_feature_profile", p_profile_name);
EditorSettings::get_singleton()->save();
current_profile = p_profile_name;
if (p_profile_name.is_empty()) {
current.unref();
} else {
current = edited;
}
_update_profile_list();
_emit_current_profile_changed();
}
Replace NULL with nullptr
2020-04-02 07:20:12 +08:00
EditorFeatureProfileManager *EditorFeatureProfileManager::singleton = nullptr;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
void EditorFeatureProfileManager::_bind_methods() {
ADD_SIGNAL(MethodInfo("current_feature_profile_changed"));
}
EditorFeatureProfileManager::EditorFeatureProfileManager() {
VBoxContainer *main_vbc = memnew(VBoxContainer);
add_child(main_vbc);
HBoxContainer *name_hbc = memnew(HBoxContainer);
current_profile_name = memnew(LineEdit);
name_hbc->add_child(current_profile_name);
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
current_profile_name->set_text(TTR("(none)"));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
current_profile_name->set_editable(false);
Working multiple window support, including editor
2020-03-07 01:00:16 +08:00
current_profile_name->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
profile_actions[PROFILE_CLEAR] = memnew(Button(TTR("Reset to Default")));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
name_hbc->add_child(profile_actions[PROFILE_CLEAR]);
profile_actions[PROFILE_CLEAR]->set_disabled(true);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-29 04:56:41 +08:00
profile_actions[PROFILE_CLEAR]->connect("pressed", callable_mp(this, &EditorFeatureProfileManager::_profile_action).bind(PROFILE_CLEAR));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Enhancements and fixes for the editor feature profile
2019-06-05 12:12:08 +08:00
main_vbc->add_margin_child(TTR("Current Profile:"), name_hbc);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
main_vbc->add_child(memnew(HSeparator));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
HBoxContainer *profiles_hbc = memnew(HBoxContainer);
profile_list = memnew(OptionButton);
Working multiple window support, including editor
2020-03-07 01:00:16 +08:00
profile_list->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Turn off auto translate for some editor controls * Scene tab * Animation name list in Animation panel * Feature profile name list in Editor Feature Profile dialog * Layout names in editor layout menu * Subresource list in Inspector dock * Resource type shown in EditorResourcePicker * Enum dropdowns in inspectors: We'll eventually allow auto translating these after implementing a way to opt-out auto translation on a property-by-property basis and a way to extract enumerators.
2023-03-28 23:02:02 +08:00
profile_list->set_auto_translate(false);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
profiles_hbc->add_child(profile_list);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-22 01:28:45 +08:00
profile_list->connect("item_selected", callable_mp(this, &EditorFeatureProfileManager::_profile_selected));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
profile_actions[PROFILE_NEW] = memnew(Button(TTR("Create Profile")));
profiles_hbc->add_child(profile_actions[PROFILE_NEW]);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-29 04:56:41 +08:00
profile_actions[PROFILE_NEW]->connect("pressed", callable_mp(this, &EditorFeatureProfileManager::_profile_action).bind(PROFILE_NEW));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
profile_actions[PROFILE_ERASE] = memnew(Button(TTR("Remove Profile")));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
profiles_hbc->add_child(profile_actions[PROFILE_ERASE]);
profile_actions[PROFILE_ERASE]->set_disabled(true);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-29 04:56:41 +08:00
profile_actions[PROFILE_ERASE]->connect("pressed", callable_mp(this, &EditorFeatureProfileManager::_profile_action).bind(PROFILE_ERASE));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
main_vbc->add_margin_child(TTR("Available Profiles:"), profiles_hbc);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
HBoxContainer *current_profile_hbc = memnew(HBoxContainer);
profile_actions[PROFILE_SET] = memnew(Button(TTR("Make Current")));
current_profile_hbc->add_child(profile_actions[PROFILE_SET]);
profile_actions[PROFILE_SET]->set_disabled(true);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-29 04:56:41 +08:00
profile_actions[PROFILE_SET]->connect("pressed", callable_mp(this, &EditorFeatureProfileManager::_profile_action).bind(PROFILE_SET));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
current_profile_hbc->add_child(memnew(VSeparator));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
profile_actions[PROFILE_IMPORT] = memnew(Button(TTR("Import")));
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
current_profile_hbc->add_child(profile_actions[PROFILE_IMPORT]);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-29 04:56:41 +08:00
profile_actions[PROFILE_IMPORT]->connect("pressed", callable_mp(this, &EditorFeatureProfileManager::_profile_action).bind(PROFILE_IMPORT));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
profile_actions[PROFILE_EXPORT] = memnew(Button(TTR("Export")));
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
current_profile_hbc->add_child(profile_actions[PROFILE_EXPORT]);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
profile_actions[PROFILE_EXPORT]->set_disabled(true);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-29 04:56:41 +08:00
profile_actions[PROFILE_EXPORT]->connect("pressed", callable_mp(this, &EditorFeatureProfileManager::_profile_action).bind(PROFILE_EXPORT));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
main_vbc->add_child(current_profile_hbc);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
h_split = memnew(HSplitContainer);
Working multiple window support, including editor
2020-03-07 01:00:16 +08:00
h_split->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
main_vbc->add_child(h_split);
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
class_list_vbc = memnew(VBoxContainer);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
h_split->add_child(class_list_vbc);
Working multiple window support, including editor
2020-03-07 01:00:16 +08:00
class_list_vbc->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
class_list = memnew(Tree);
Put multiple colons back into translated strings
2021-08-01 01:08:07 +08:00
class_list_vbc->add_margin_child(TTR("Configure Selected Profile:"), class_list, true);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
class_list->set_hide_root(true);
class_list->set_edit_checkbox_cell_only_when_checkbox_is_pressed(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-22 01:28:45 +08:00
class_list->connect("cell_selected", callable_mp(this, &EditorFeatureProfileManager::_class_list_item_selected));
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-29 04:56:41 +08:00
class_list->connect("item_edited", callable_mp(this, &EditorFeatureProfileManager::_class_list_item_edited), CONNECT_DEFERRED);
Fixed changing enabled classes resetting folding in manage editor features.
2021-05-27 22:19:33 +08:00
class_list->connect("item_collapsed", callable_mp(this, &EditorFeatureProfileManager::_class_list_item_collapsed));
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
// It will be displayed once the user creates or chooses a profile.
class_list_vbc->hide();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
property_list_vbc = memnew(VBoxContainer);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
h_split->add_child(property_list_vbc);
Working multiple window support, including editor
2020-03-07 01:00:16 +08:00
property_list_vbc->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
description_bit = memnew(EditorHelpBit);
Put multiple colons back into translated strings
2021-08-01 01:08:07 +08:00
property_list_vbc->add_margin_child(TTR("Description:"), description_bit, false);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
description_bit->set_custom_minimum_size(Size2(0, 80) * EDSCALE);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
property_list = memnew(Tree);
Put multiple colons back into translated strings
2021-08-01 01:08:07 +08:00
property_list_vbc->add_margin_child(TTR("Extra Options:"), property_list, true);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
property_list->set_hide_root(true);
property_list->set_hide_folding(true);
property_list->set_edit_checkbox_cell_only_when_checkbox_is_pressed(true);
Remove Signal connect binds Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-29 04:56:41 +08:00
property_list->connect("item_edited", callable_mp(this, &EditorFeatureProfileManager::_property_item_edited), CONNECT_DEFERRED);
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
// It will be displayed once the user creates or chooses a profile.
property_list_vbc->hide();
no_profile_selected_help = memnew(Label(TTR("Create or import a profile to edit available classes and properties.")));
// Add some spacing above the help label.
Ref<StyleBoxEmpty> sb = memnew(StyleBoxEmpty);
Clean-up, harmonize, and improve StyleBox API - Make all margin properties follow the same naming convention (their getter and setter too). - Remove a virtual counterpart of `get_style_margin` from API. - Allow to override `get_minimum_size` from scripting and remove `get_center_size`.
2023-01-20 00:14:09 +08:00
sb->set_content_margin(SIDE_TOP, 20 * EDSCALE);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 17:14:58 +08:00
no_profile_selected_help->add_theme_style_override("normal", sb);
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 10:58:47 +08:00
no_profile_selected_help->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_CENTER);
Fix build after merge of #37235 It used APIs that were changed after the PR was last rebased.
2020-05-25 19:10:28 +08:00
no_profile_selected_help->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Improve the editor feature profiles UX - Add an help message when no profile is selected. - This replaces the class/property trees which are now hidden when no profile is selected. - Display `(none)` as the current profile when no profile is currently active. - Make the newly created/imported profile the current if it's the first profile to be added to the list. - Make more strings localizable.
2020-03-23 04:52:06 +08:00
h_split->add_child(no_profile_selected_help);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
new_profile_dialog = memnew(ConfirmationDialog);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
new_profile_dialog->set_title(TTR("Create Profile"));
VBoxContainer *new_profile_vb = memnew(VBoxContainer);
new_profile_dialog->add_child(new_profile_vb);
Label *new_profile_label = memnew(Label);
Put multiple colons back into translated strings
2021-08-01 01:08:07 +08:00
new_profile_label->set_text(TTR("New profile name:"));
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
new_profile_vb->add_child(new_profile_label);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
new_profile_name = memnew(LineEdit);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
new_profile_vb->add_child(new_profile_name);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
new_profile_name->set_custom_minimum_size(Size2(300 * EDSCALE, 1));
add_child(new_profile_dialog);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-22 01:28:45 +08:00
new_profile_dialog->connect("confirmed", callable_mp(this, &EditorFeatureProfileManager::_create_new_profile));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
new_profile_dialog->register_text_enter(new_profile_name);
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 08:31:19 +08:00
new_profile_dialog->set_ok_button_text(TTR("Create"));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
erase_profile_dialog = memnew(ConfirmationDialog);
add_child(erase_profile_dialog);
Improve the layout and texts of the Editor Feature Profiles dialog
2021-05-07 03:24:41 +08:00
erase_profile_dialog->set_title(TTR("Remove Profile"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-22 01:28:45 +08:00
erase_profile_dialog->connect("confirmed", callable_mp(this, &EditorFeatureProfileManager::_erase_selected_profile));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
import_profiles = memnew(EditorFileDialog);
add_child(import_profiles);
Working multiple window support, including editor
2020-03-07 01:00:16 +08:00
import_profiles->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILES);
Seperate filter and description in FileDialog.add_filter()
2022-07-05 05:26:26 +08:00
import_profiles->add_filter("*.profile", TTR("Godot Feature Profile"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-22 01:28:45 +08:00
import_profiles->connect("files_selected", callable_mp(this, &EditorFeatureProfileManager::_import_profiles));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
import_profiles->set_title(TTR("Import Profile(s)"));
import_profiles->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
export_profile = memnew(EditorFileDialog);
add_child(export_profile);
Working multiple window support, including editor
2020-03-07 01:00:16 +08:00
export_profile->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
Seperate filter and description in FileDialog.add_filter()
2022-07-05 05:26:26 +08:00
export_profile->add_filter("*.profile", TTR("Godot Feature Profile"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-22 01:28:45 +08:00
export_profile->connect("file_selected", callable_mp(this, &EditorFeatureProfileManager::_export_profile));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
export_profile->set_title(TTR("Export Profile"));
export_profile->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
set_title(TTR("Manage Editor Feature Profiles"));
EDITOR_DEF("_default_feature_profile", "");
update_timer = memnew(Timer);
update_timer->set_wait_time(1); //wait a second before updating editor
add_child(update_timer);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-22 01:28:45 +08:00
update_timer->connect("timeout", callable_mp(this, &EditorFeatureProfileManager::_emit_current_profile_changed));
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 06:18:03 +08:00
update_timer->set_one_shot(true);
singleton = this;
}
Reference in New Issue Copy Permalink