mirror of
git://sourceware.org/git/glibc.git
synced 2025-02-11 12:50:58 +08:00
ee8d5e33ad
realpath returns an allocated string when the result exceeds PATH_MAX, which is unexpected when its second argument is not NULL. This results in the second argument (resolved) being uninitialized and also results in a memory leak since the caller expects resolved to be the same as the returned value. Return NULL and set errno to ENAMETOOLONG if the result exceeds PATH_MAX. This fixes [BZ #28770], which is CVE-2021-3998. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
50 lines
1.5 KiB
C
50 lines
1.5 KiB
C
/* Verify that realpath returns NULL with ENAMETOOLONG if the result exceeds
|
|
NAME_MAX.
|
|
Copyright The GNU Toolchain Authors.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <errno.h>
|
|
#include <limits.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <support/check.h>
|
|
#include <support/temp_file.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
|
|
#define BASENAME "tst-realpath-toolong."
|
|
|
|
int
|
|
do_test (void)
|
|
{
|
|
char *base = support_create_and_chdir_toolong_temp_directory (BASENAME);
|
|
|
|
char buf[PATH_MAX + 1];
|
|
const char *res = realpath (".", buf);
|
|
|
|
/* canonicalize.c states that if the real path is >= PATH_MAX, then
|
|
realpath returns NULL and sets ENAMETOOLONG. */
|
|
TEST_VERIFY (res == NULL);
|
|
TEST_VERIFY (errno == ENAMETOOLONG);
|
|
|
|
free (base);
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|