Siddhesh Poyarekar a643f60c53 Make sure that the fortified function conditionals are constant ... In _FORTIFY_SOURCE=3, the size expression may be non-constant, resulting in branches in the inline functions remaining intact and causing a tiny overhead. Clang (and in future, gcc) make sure that the -1 case is always safe, i.e. any comparison of the generated expression with (size_t)-1 is always false so that bit is taken care of. The rest is avoidable since we want the _chk variant whenever we have a size expression and it's not -1. Rework the conditionals in a uniform way to clearly indicate two conditions at compile time: - Either the size is unknown (-1) or we know at compile time that the operation length is less than the object size. We can call the original function in this case. It could be that either the length, object size or both are non-constant, but the compiler, through range analysis, is able to fold the *comparison* to a constant. - The size and length are known and the compiler can see at compile time that operation length > object size. This is valid grounds for a warning at compile time, followed by emitting the _chk variant. For everything else, emit the _chk variant. This simplifies most of the fortified function implementations and at the same time, ensures that only one call from _chk or the regular function is emitted. Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>		2021-10-20 18:12:41 +05:30
..
bits	Make sure that the fortified function conditionals are constant	2021-10-20 18:12:41 +05:30
__fbufsize.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
__flbf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
__fpending.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
__fpurge.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
__freadable.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
__freading.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
__fsetlocking.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
__fwritable.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
__fwriting.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
bug-fopena+.c
bug-fseek.c
bug-ftell.c
bug-memstream1.c
bug-mmap-fflush.c
bug-rewind2.c
bug-rewind.c
bug-ungetc2.c
bug-ungetc3.c
bug-ungetc4.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
bug-ungetc.c
bug-ungetwc1.c
bug-ungetwc2.c
bug-wfflush.c
bug-wmemstream1.c
bug-wsetpos.c
clearerr_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
clearerr.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
Depend
fcloseall.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
feof_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
feof.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ferror_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ferror.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
filedoalloc.c	Use 64 bit time_t stat internally	2021-06-22 12:09:52 -03:00
fileno.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fileops.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
fmemopen.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fputc_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fputc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fputwc_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fputwc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
freopen64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
freopen.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fseek.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fseeko64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fseeko.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ftello64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ftello.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fwide.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fwprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
fwscanf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
genops.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getc_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getchar_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getchar.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getwc_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getwc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getwchar_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
getwchar.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofclose.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofdopen.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofflush_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofflush.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofgetpos64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofgetpos.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofgets_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofgets.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofgetws_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofgetws.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofopen64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofopen.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofopncook.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofputs_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofputs.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofputws_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofputws.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofread_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofread.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofsetpos64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofsetpos.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ioftell.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofwide.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofwrite_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iofwrite.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iogetdelim.c	libio: Replace internal _IO_getdelim symbol with __getdelim	2021-07-07 18:33:52 +02:00
iogetline.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iogets.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iogetwline.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iolibio.h
iopadn.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iopopen.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
ioputs.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ioseekoff.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ioseekpos.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iosetbuffer.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iosetvbuf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
ioungetc.c	libio: Add hidden prototype for ungetc	2021-07-07 18:33:52 +02:00
ioungetwc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iovdprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iovsprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iovsscanf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iovswscanf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
iowpadn.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
libc_fatal.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
libio.h	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
libioP.h	libio: Replace internal _IO_getdelim symbol with __getdelim	2021-07-07 18:33:52 +02:00
Makefile	Move malloc hooks into a compat DSO	2021-07-22 18:37:59 +05:30
memstream.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
obprintf.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
oldfileops.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
oldfmemopen.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
oldiofclose.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldiofdopen.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldiofgetpos64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldiofgetpos.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldiofopen.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldiofsetpos64.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldiofsetpos.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldiopopen.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
oldpclose.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldstdfiles.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
oldtmpfile.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
pclose.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
peekc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
putc_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
putc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
putchar_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
putchar.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
putwc_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
putwc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
putwchar_u.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
putwchar.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
rewind.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
setbuf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
setlinebuf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
stdfiles.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
stdio.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
stdio.h	Don't add access size hints to fortifiable functions	2021-10-20 08:33:31 +05:30
strfile.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
strops.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
swprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
swscanf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
test-fmemopen.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
test-freopen.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
test-freopen.sh	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst_getwc.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst_getwc.input
tst_putwc.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst_swprintf.c
tst_swscanf.c
tst_wprintf2.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst_wprintf.c
tst_wscanf.c
tst_wscanf.input
tst-atime.c
tst-bz22415.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-bz24051.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-bz24153.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-bz24228.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-bz24228.map
tst-cleanup-default-static.c	Set the retain attribute on _elf_set_element if CC supports [BZ #27492]	2021-04-16 11:26:39 -07:00
tst-cleanup-default.c	Set the retain attribute on _elf_set_element if CC supports [BZ #27492]	2021-04-16 11:26:39 -07:00
tst-cleanup-nostart-stop-gc-static.c	Set the retain attribute on _elf_set_element if CC supports [BZ #27492]	2021-04-16 11:26:39 -07:00
tst-cleanup-nostart-stop-gc.c	Set the retain attribute on _elf_set_element if CC supports [BZ #27492]	2021-04-16 11:26:39 -07:00
tst-cleanup-start-stop-gc-static.c	Set the retain attribute on _elf_set_element if CC supports [BZ #27492]	2021-04-16 11:26:39 -07:00
tst-cleanup-start-stop-gc.c	Set the retain attribute on _elf_set_element if CC supports [BZ #27492]	2021-04-16 11:26:39 -07:00
tst-cleanup.c	Set the retain attribute on _elf_set_element if CC supports [BZ #27492]	2021-04-16 11:26:39 -07:00
tst-cleanup.exp	Set the retain attribute on _elf_set_element if CC supports [BZ #27492]	2021-04-16 11:26:39 -07:00
tst-eof.c
tst-ext2.c
tst-ext.c
tst-fgetc-after-eof.c
tst-fgetwc.c
tst-fgetwc.input
tst-fgetws.c
tst-fopenloc2.c
tst-fopenloc.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-fputws.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-freopen.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-fseek.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-ftell-active-handler.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-ftell-append.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-ftell-partial-wide.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-fwrite-error.c	libio: Update license on test case	2021-03-30 19:23:09 +05:30
tst-memstream1.c
tst-memstream2.c
tst-memstream3.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-memstream4.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-memstream.h	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-mmap2-eofsync.c
tst-mmap-eofsync.c
tst-mmap-fflushsync.c
tst-mmap-offend.c
tst-mmap-setvbuf.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-popen1.c	Enable support for GCC 11 -Wmismatched-dealloc.	2021-05-16 15:21:18 -06:00
tst-setvbuf1.c
tst-sprintf-chk-ub.c
tst-sprintf-ub.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-sscanf.c
tst-swscanf.c
tst-ungetwc1.c
tst-ungetwc2.c
tst-vtables-common.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-vtables-interposed.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-vtables.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-wfile-sync.c	libio: Update tst-wfile-sync to not depend on stdin	2021-10-12 13:25:43 -03:00
tst-widetext.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
tst-widetext.input
tst-wmemstream1.c	Enable support for GCC 11 -Wmismatched-dealloc.	2021-05-16 15:21:18 -06:00
tst-wmemstream2.c
tst-wmemstream3.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-wmemstream4.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
tst-wmemstream5.c	Enable support for GCC 11 -Wmismatched-dealloc.	2021-05-16 15:21:18 -06:00
vasprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
Versions	Add missing symbols to Version files	2021-06-02 07:32:19 +02:00
vscanf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
vsnprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
vswprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
vtables.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
vwprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
vwscanf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
wfiledoalloc.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
wfileops.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
wgenops.c	Remove "Contributed by" lines	2021-09-03 22:06:44 +05:30
wmemstream.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
wprintf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
wscanf.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00
wstrops.c	Update copyright dates with scripts/update-copyrights	2021-01-02 12:17:34 -08:00