mirror of
git://sourceware.org/git/glibc.git
synced 2024-12-03 04:01:43 +08:00
32db86d558
This patch adds fall-through comments in some cases where -Wextra produces implicit-fallthrough warnings. The patch is non-exhaustive. Apart from architecture-specific code for non-x86_64 architectures, it does not change sunrpc/xdr.c (legacy code, probably should have such changes, but left to be dealt with separately), or places that already had comments about the fall-through but not matching the form expected by -Wimplicit-fallthrough=3 (the default level with -Wextra; my inclination is to adjust those comments to match rather than downgrading to -Wimplicit-fallthrough=1 to allow any comment), or one place where I thought the implicit fallthrough was not correct and so should be handled separately as a bug fix. I think the key thing to consider in review of this patch is whether the fall-through is indeed intended and correct in each place where such a comment is added. Tested for x86_64. * elf/dl-exception.c (_dl_exception_create_format): Add fall-through comments. * elf/ldconfig.c (parse_conf_include): Likewise. * elf/rtld.c (print_statistics): Likewise. * locale/programs/charmap.c (parse_charmap): Likewise. * misc/mntent_r.c (__getmntent_r): Likewise. * posix/wordexp.c (parse_arith): Likewise. (parse_backtick): Likewise. * resolv/ns_ttl.c (ns_parse_ttl): Likewise. * sysdeps/x86/cpu-features.c (init_cpu_features): Likewise. * sysdeps/x86_64/dl-machine.h (elf_machine_rela): Likewise. |
||
|---|---|---|
| .. | ||
| bits | ||
| fpu | ||
| nptl | ||
| __longjmp_cancel.S | ||
| atomic-machine.h | ||
| cacheinfo.c | ||
| cet-tunables.h | ||
| check-cet.awk | ||
| configure | ||
| configure.ac | ||
| cpu-features-offsets.sym | ||
| cpu-features.c | ||
| cpu-features.h | ||
| cpu-tunables.c | ||
| dl-cet.c | ||
| dl-get-cpu-features.c | ||
| dl-hwcap.h | ||
| dl-procinfo.c | ||
| dl-procinfo.h | ||
| dl-procruntime.c | ||
| dl-prop.h | ||
| dl-tunables.list | ||
| elide.h | ||
| float128-abi.h | ||
| fpu_control.h | ||
| hp-timing.h | ||
| init-arch.h | ||
| jmp_buf-ssp.sym | ||
| ldsodefs.h | ||
| libc-start.c | ||
| libc-start.h | ||
| link_map.h | ||
| linkmap.h | ||
| longjmp.c | ||
| Makeconfig | ||
| Makefile | ||
| string_private.h | ||
| sysdep.h | ||
| tininess.h | ||
| tst-cet-legacy-1.c | ||
| tst-cet-legacy-1a.c | ||
| tst-cet-legacy-2.c | ||
| tst-cet-legacy-2a.c | ||
| tst-cet-legacy-3.c | ||
| tst-cet-legacy-4.c | ||
| tst-cet-legacy-4a.c | ||
| tst-cet-legacy-4b.c | ||
| tst-cet-legacy-4c.c | ||
| tst-cet-legacy-mod-1.c | ||
| tst-cet-legacy-mod-2.c | ||
| tst-cet-legacy-mod-4.c | ||
| tst-get-cpu-features-static.c | ||
| tst-get-cpu-features.c | ||
| Versions | ||