mirror of
git://sourceware.org/git/glibc.git
synced 2024-11-27 03:41:23 +08:00
0292b0dd6c
invalid length [Coverity CID 106]. * nss/nss_files/files-key.c (search): Close stream before successful return [Coverity CID 107]. * io/fts.c (fts_open): Don't allocate parent if *argv==NULL [Coverity CID 108]. * sunrpc/rpc_cout.c (inline_struct): Free sizestr after use [Coverity CID 110, 109]. * sunrpc/rpc_scan.c (docppline): Free file string if it is not going to be used [Coverity CID 111]. * sysdeps/unix/sysv/linux/getsourcefilter.c (getsourcefilter): Free memory if socket level value cannot be retrieved [Coverity CID 112]. * nis/nis_clone_dir.c (nis_clone_directory): Free all memory in error case [Coverity CID 114]. * nis/nis_clone_res.c (nis_clone_result): Free all memory in the error cases [Coverity CID 115]. * sunrpc/rpc_parse.c (get_definition): Free defp if tok == TOK_EOF [Coverity CID 116]. * sysdeps/unix/sysv/linux/setsourcefilter.c (setsourcefilter): Free memory if socket level value cannot be retrieved [Coverity CID 117]. * elf/cache.c (save_cache): Initialize pad to avoid writing uninitialized data to disk. * elf/cache.c (save_cache): Free file_entries_new [Coverity CID 118]. * intl/finddomain.c (_nl_find_domain): Avoid strdup of expand locale name, use strdupa. Remove free call [Coverity CID 119]. * sunrpc/rpc_main.c (generate_guard): Avoid extra allocation and the resulting leak [Coverity CID 121]. * sunrpc/rpc_main.c (mkfile_output): Free all allocated memory [Coverity CID 122]. * sunrpc/rpc_main.c (h_output): Free guard after we are done [Coverity CID 123]. * sunrpc/svc_udp.c (cache_set): Free victim if newbuf allocation fails [Coverity CID 126]. * sunrpc/svc_udp.c (svcudp_enablecache): Free memory in error cases [Coverity CID 127]. * nis/nis_table.c (__create_ib_request): Free ibreq in case strdup fails [Coverity CID 128]. * nis/nis_getservlist.c (nis_getservlist): Free all memory in case of an error [Coverity CID 130, 129]. * nis/nis_print_group_entry.c (nis_print_group_entry): If nis_lookup call failed, return. Free lookup result in error cases [Coverity CID 131]. * nis/nis_removemember.c (nis_removemember): Free all memory in error cases [Coverity CID 132]. * nis/nss_nisplus/nisplus-alias.c (_nss_nisplus_getaliasbyname_r): Always free lookup result [Coverity CID 134]. * nis/nss_nisplus/nisplus-ethers.c (_nss_nisplus_gethostton_r): Always free lookup result [Coverity CID 135]. * nis/nss_nisplus/nisplus-ethers.c (_nss_nisplus_getntohost_r): Always free lookup result [Coverity CID 136]. * nis/nss_nisplus/nisplus-network.c (_nss_nisplus_getnetbyaddr_r): Before retrying, free old result [Coverity CID 137]. * nis/nss_nisplus/nisplus-publickey.c (_nss_nisplus_netname2user): Free res in case UID is zero [Coverity CID 138]. * nis/ypclnt.c (yp_update): Always free master string [Coverity CID 140]. * nis/nis_creategroup.c (nis_creategroup): Free all memory in error cases [Coverity CID 143, 142, 141]. * nis/nss_nis/nis-publickey.c (_nss_nis_getpublickey): Free result if yp_match call succeeded [Coverity CID 155]. * nis/nss_nis/nis-publickey.c (_nss_nis_getsecretkey): Free string allocated in yp_match at all times [Coverity CID 157, 156]. * nscd/nscd.c (write_pid): Close stream also if writing failed [Coverity CID 165]. * nis/nis_table.c (nis_add_entry): Move test for NULL parameter ahead of first use [Coverity CID 167]. * nis/nss_nis/nis-alias.c (_nss_nis_getaliasbyname_r): Move test for NULL parameter ahead of first use [Coverity CID 168]. * intl/finddomain.c (_nl_find_domain): We never return NULL if we found the locale [Coverity CID 169]. * inet/getnameinfo.c (getnameinfo): __getservbyport_r does not set herrno [Coverity CID 178]. * nis/nis_checkpoint.c (nis_checkpoint): Don't access and returned freed object [Coverity CID 182].
123 lines
3.8 KiB
C
123 lines
3.8 KiB
C
/* Copyright (c) 1997,1998,1999,2004,2005,2006 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Thorsten Kukuk <kukuk@vt.uni-paderborn.de>, 1997.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, write to the Free
|
|
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
|
|
02111-1307 USA. */
|
|
|
|
#include <assert.h>
|
|
#include <string.h>
|
|
#include <rpcsvc/nis.h>
|
|
|
|
nis_error
|
|
nis_removemember (const_nis_name member, const_nis_name group)
|
|
{
|
|
if (group != NULL && group[0] != '\0')
|
|
{
|
|
size_t grouplen = strlen (group);
|
|
char buf[grouplen + 14 + NIS_MAXNAMELEN];
|
|
char leafbuf[grouplen + 2];
|
|
char domainbuf[grouplen + 2];
|
|
nis_name *newmem;
|
|
nis_result *res, *res2;
|
|
nis_error status;
|
|
char *cp, *cp2;
|
|
unsigned long int i, j, k;
|
|
|
|
cp = stpcpy (buf, nis_leaf_of_r (group, leafbuf, sizeof (leafbuf) - 1));
|
|
cp = stpcpy (cp, ".groups_dir");
|
|
cp2 = nis_domain_of_r (group, domainbuf, sizeof (domainbuf) - 1);
|
|
if (cp2 != NULL && cp2[0] != '\0')
|
|
{
|
|
cp = stpcpy (cp, ".");
|
|
stpcpy (cp, cp2);
|
|
}
|
|
res = nis_lookup (buf, FOLLOW_LINKS|EXPAND_NAME);
|
|
if (res == NULL || NIS_RES_STATUS (res) != NIS_SUCCESS)
|
|
{
|
|
if (res)
|
|
{
|
|
status = NIS_RES_STATUS (res);
|
|
nis_freeresult (res);
|
|
}
|
|
else
|
|
return NIS_NOMEMORY;
|
|
return status;
|
|
}
|
|
|
|
if ((res->objects.objects_len != 1) ||
|
|
(__type_of (NIS_RES_OBJECT (res)) != NIS_GROUP_OBJ))
|
|
{
|
|
nis_freeresult (res);
|
|
return NIS_INVALIDOBJ;
|
|
}
|
|
|
|
newmem =
|
|
calloc (NIS_RES_OBJECT(res)->GR_data.gr_members.gr_members_len,
|
|
sizeof (char *));
|
|
if (newmem == NULL)
|
|
{
|
|
nis_freeresult (res);
|
|
return NIS_NOMEMORY;
|
|
}
|
|
|
|
k = NIS_RES_OBJECT (res)[0].GR_data.gr_members.gr_members_len;
|
|
j = 0;
|
|
for (i = 0; i < NIS_RES_OBJECT(res)->GR_data.gr_members.gr_members_len;
|
|
++i)
|
|
{
|
|
if (strcmp (NIS_RES_OBJECT(res)->GR_data.gr_members.gr_members_val[i],
|
|
member) != 0)
|
|
{
|
|
newmem[j] = NIS_RES_OBJECT(res)->GR_data.gr_members.gr_members_val[i];
|
|
++j;
|
|
}
|
|
else
|
|
{
|
|
free (NIS_RES_OBJECT(res)->GR_data.gr_members.gr_members_val[i]);
|
|
--k;
|
|
}
|
|
}
|
|
free (NIS_RES_OBJECT (res)->GR_data.gr_members.gr_members_val);
|
|
assert (k <= NIS_RES_OBJECT(res)->GR_data.gr_members.gr_members_len);
|
|
/* This realloc() call always decreases the size. This cannot
|
|
fail. We still have the test but do not recover memory
|
|
(i.e., we overwrite the input pointer). */
|
|
nis_name *newp = realloc (newmem, k * sizeof (char*));
|
|
if (newp == NULL)
|
|
{
|
|
free (newmem);
|
|
nis_freeresult (res);
|
|
return NIS_NOMEMORY;
|
|
}
|
|
newmem = newp;
|
|
|
|
NIS_RES_OBJECT (res)->GR_data.gr_members.gr_members_val = newmem;
|
|
NIS_RES_OBJECT (res)->GR_data.gr_members.gr_members_len = k;
|
|
|
|
cp = stpcpy (buf, NIS_RES_OBJECT (res)->zo_name);
|
|
*cp++ = '.';
|
|
strncpy (cp, NIS_RES_OBJECT (res)->zo_domain, NIS_MAXNAMELEN);
|
|
res2 = nis_modify (buf, NIS_RES_OBJECT (res));
|
|
status = NIS_RES_STATUS (res2);
|
|
nis_freeresult (res);
|
|
nis_freeresult (res2);
|
|
|
|
return status;
|
|
}
|
|
else
|
|
return NIS_FAIL;
|
|
}
|