glibc/stdio-common
Joseph Myers 6ff61a5145 Fix stdio-common tests for GCC 12 -Waddress
My glibc bot shows failures building the testsuite with GCC mainline
across all architectures:

tst-vfprintf-width-prec.c: In function 'do_test':
tst-vfprintf-width-prec.c:90:16: error: the comparison will always evaluate as 'false' for the address of 'result' will never be NULL [-Werror=address]
   90 |     if (result == NULL)
      |                ^~
tst-vfprintf-width-prec.c:89:13: note: 'result' declared here
   89 |     wchar_t result[100];
      |             ^~~~~~

This is clearly a correct warning; the comparison against NULL is
clearly a cut-and-paste mistake from an earlier case in the test that
does use calloc.  Thus, remove the unnecessary check for NULL shown up
by the warning.

Similarly, two other tests have bogus comparisons against NULL; remove
those as well:

scanf14a.c:95:13: error: the comparison will always evaluate as 'false' for the address of 'fname' will never be NULL [-Werror=address]
   95 |   if (fname == NULL)
      |             ^~
scanf14a.c:93:8: note: 'fname' declared here
   93 |   char fname[strlen (tmpdir) + sizeof "/tst-scanf14.XXXXXX"];
      |        ^~~~~

scanf16a.c:125:13: error: the comparison will always evaluate as 'false' for the address of 'fname' will never be NULL [-Werror=address]
  125 |   if (fname == NULL)
      |             ^~
scanf16a.c:123:8: note: 'fname' declared here
  123 |   char fname[strlen (tmpdir) + sizeof "/tst-scanf16.XXXXXX"];
      |        ^~~~~

Tested with build-many-glibcs.py (GCC mainline) for aarch64-linux-gnu.

(cherry picked from commit a312e8fe6d)
2023-01-11 14:12:05 +01:00
..
bits Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
_i18n_number.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
_itoa.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
_itowa.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
_itowa.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
asprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
bug1.c
bug1.input
bug2.c
bug3.c Fix hardcoded /tmp paths in testing (bug 13888). 2018-06-26 21:48:48 +00:00
bug4.c Fix hardcoded /tmp paths in testing (bug 13888). 2018-06-26 21:48:48 +00:00
bug5.c Fix hardcoded /tmp paths in testing (bug 13888). 2018-06-26 21:48:48 +00:00
bug6.c
bug6.input
bug7.c Avoid insecure usage of tmpnam in tests. 2018-07-18 21:04:12 +00:00
bug8.c
bug9.c
bug10.c
bug11.c
bug12.c
bug13.c
bug14.c
bug16.c stdio-common: Use array_length and array_end macros 2017-11-02 12:45:20 +01:00
bug17.c
bug18.c
bug18a.c
bug19.c
bug19a.c
bug20.c
bug21.c Use C99-compliant scanf under _GNU_SOURCE with modern compilers. 2019-01-03 11:12:39 -05:00
bug22.c Remove most vfprintf width/precision-dependent allocations (bug 14231, bug 26211). 2020-07-07 14:54:12 +00:00
bug23-2.c
bug23-3.c
bug23-4.c
bug23.c
bug24.c
bug25.c
bug26.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
bug-vfprintf-nargs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
ctermid.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
cuserid.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Depend
dprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
errlist-compat.c signal: Move sys_errlist to a compat symbol 2020-07-07 14:10:58 -03:00
errlist.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
errnobug.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
flockfile.c linux: Move flockfile/_IO_flockfile into libc 2021-05-10 23:35:44 -03:00
fprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
fscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
ftrylockfile.c linux: Move ftrylockfile/_IO_ftrylockfile into libc 2021-05-10 23:35:44 -03:00
funlockfile.c linux: Move funlockfile/_IO_funlockfile into libc 2021-05-10 23:35:44 -03:00
fxprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
gentempfd.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
getline.c libio: Replace internal _IO_getdelim symbol with __getdelim 2021-07-07 18:33:52 +02:00
getw.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
iovfscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_fscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_scanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_sscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vfscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vsscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
itoa-digits.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
itoa-udigits.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
itowa-digits.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Makefile Move malloc hooks into a compat DSO 2021-07-22 18:37:59 +05:30
perror.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf_fp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf_fphex.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf_size.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf-parse.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf-parsemb.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf-parsewc.c
printf-prs.c stdio-common/printf-prs.c: Reword comment 2021-03-31 17:20:18 -03:00
printf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
printf.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
psiginfo-data.h
psiginfo-define.h
psiginfo.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
psignal.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
putw.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
reg-modifier.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
reg-printf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
reg-type.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
remove.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
rename.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
renameat2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
renameat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf1.c
scanf2.c
scanf3.c
scanf4.c
scanf5.c
scanf7.c
scanf8.c
scanf9.c
scanf10.c
scanf11.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf12.c
scanf12.input
scanf13.c
scanf14.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf14a.c Fix stdio-common tests for GCC 12 -Waddress 2023-01-11 14:12:05 +01:00
scanf15.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf16.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf16a.c Fix stdio-common tests for GCC 12 -Waddress 2023-01-11 14:12:05 +01:00
scanf17.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
scanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
siglist.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
snprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
sscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
stdio_ext.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
stdio_lim.h.in Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tempnam.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tempname.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
temptest.c
test_rdwr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-fseek.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-fwrite.c
test-popen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-strerr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-vfprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tfformat.c stdio-common: Add a few double formatting tests [BZ #27245] 2021-02-03 16:47:47 -03:00
tiformat.c
tllformat.c
tmpfile64.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tmpfile.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tmpnam_r.c Annotate additional APIs with GCC attribute access. 2021-05-06 11:01:05 -06:00
tmpnam.c Annotate additional APIs with GCC attribute access. 2021-05-06 11:01:05 -06:00
tst-bz11319-fortify2.c Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319) 2018-12-05 18:15:43 -02:00
tst-bz11319.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-cookie.c
tst-errno-manual.py Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fdopen.c Avoid insecure usage of tmpnam in tests. 2018-07-18 21:04:12 +00:00
tst-ferror.c
tst-ferror.input
tst-fgets.c Prefer https for Sourceware links 2017-11-16 11:49:26 +05:30
tst-fileno.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fmemopen2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fmemopen3.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fmemopen4.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fmemopen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fphex-wide.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fphex.c stdio-common: Use array_length and array_end macros 2017-11-02 12:45:20 +01:00
tst-fseek.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fwrite.c Prefer https for Sourceware links 2017-11-16 11:49:26 +05:30
tst-gets.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-gets.input
tst-grouping.c
tst-long-dbl-fphex.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-obprintf.c
tst-perror.c
tst-popen2.c
tst-popen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-bz18872.sh Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-bz25691.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-fp-free.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-fp-leak.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf-round.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printf.c printf: Add smoke tests for long double 2021-02-05 09:52:52 +05:30
tst-printf.sh printf: Add smoke tests for long double 2021-02-05 09:52:52 +05:30
tst-printfsz-islongdouble.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printfsz-islongdouble.sh Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-printfsz.c
tst-put-error.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-renameat2.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-rndseek.c Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
tst-scanf-round.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-setvbuf1.c
tst-setvbuf1.expect
tst-sprintf2.c
tst-sprintf3.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-sprintf.c
tst-sscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-swprintf.c stdio-common: Use array_length and array_end macros 2017-11-02 12:45:20 +01:00
tst-swscanf.c
tst-tmpnam.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-unbputc.c
tst-unbputc.sh Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-ungetc.c Avoid insecure usage of tmpnam in tests. 2018-07-18 21:04:12 +00:00
tst-unlockedio.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-vfprintf-mbs-prec.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-vfprintf-user-type.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-vfprintf-width-prec-alloc.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-vfprintf-width-prec.c Fix stdio-common tests for GCC 12 -Waddress 2023-01-11 14:12:05 +01:00
tst-wc-printf.c
tstdiomisc.c stdio-common: Use array_length and array_end macros 2017-11-02 12:45:20 +01:00
tstgetln.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tstgetln.input
tstscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tstscanf.input
Versions Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
vfprintf-internal.c Fix memmove call in vfprintf-internal.c:group_number 2022-11-11 16:51:50 +01:00
vfprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
vfscanf-internal.c stdio: fix vfscanf with matches longer than INT_MAX (bug 27650) 2021-05-03 10:34:11 +02:00
vfscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
vfwprintf-internal.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
vfwprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
vfwscanf-internal.c Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
vfwscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
vprintf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
xbug.c