mirror of
git://sourceware.org/git/glibc.git
synced 2025-01-30 12:31:53 +08:00
9dd346ff43
This mostly automatically-generated patch converts 113 function definitions in glibc from old-style K&R to prototype-style. Following my other recent such patches, this one deals with the case of function definitions in files that either contain assertions or where grep suggested they might contain assertions - and thus where it isn't possible to use a simple object code comparison as a sanity check on the correctness of the patch, because line numbers are changed. A few such automatically-generated changes needed to be supplemented by manual changes for the result to compile. openat64 had a prototype declaration with "..." but an old-style definition in sysdeps/unix/sysv/linux/dl-openat64.c, and "..." needed adding to the generated prototype in the definition (I've filed <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68024> for diagnosing such cases in GCC; the old state was undefined behavior not requiring a diagnostic, but one seems a good idea). In addition, as Florian has noted regparm attribute mismatches between declaration and definition are only diagnosed for prototype definitions, and five functions needed internal_function added to their definitions (in the case of __pthread_mutex_cond_lock, via the macro definition of __pthread_mutex_lock) to compile on i386. After this patch is in, remaining old-style definitions are probably most readily fixed manually before we can turn on -Wold-style-definition for all builds. Tested for x86_64 and x86 (testsuite). * crypt/md5-crypt.c (__md5_crypt_r): Convert to prototype-style function definition. * crypt/sha256-crypt.c (__sha256_crypt_r): Likewise. * crypt/sha512-crypt.c (__sha512_crypt_r): Likewise. * debug/backtracesyms.c (__backtrace_symbols): Likewise. * elf/dl-minimal.c (_itoa): Likewise. * hurd/hurdmalloc.c (malloc): Likewise. (free): Likewise. (realloc): Likewise. * inet/inet6_option.c (inet6_option_space): Likewise. (inet6_option_init): Likewise. (inet6_option_append): Likewise. (inet6_option_alloc): Likewise. (inet6_option_next): Likewise. (inet6_option_find): Likewise. * io/ftw.c (FTW_NAME): Likewise. (NFTW_NAME): Likewise. (NFTW_NEW_NAME): Likewise. (NFTW_OLD_NAME): Likewise. * libio/iofwide.c (_IO_fwide): Likewise. * libio/strops.c (_IO_str_init_static_internal): Likewise. (_IO_str_init_static): Likewise. (_IO_str_init_readonly): Likewise. (_IO_str_overflow): Likewise. (_IO_str_underflow): Likewise. (_IO_str_count): Likewise. (_IO_str_seekoff): Likewise. (_IO_str_pbackfail): Likewise. (_IO_str_finish): Likewise. * libio/wstrops.c (_IO_wstr_init_static): Likewise. (_IO_wstr_overflow): Likewise. (_IO_wstr_underflow): Likewise. (_IO_wstr_count): Likewise. (_IO_wstr_seekoff): Likewise. (_IO_wstr_pbackfail): Likewise. (_IO_wstr_finish): Likewise. * locale/programs/localedef.c (normalize_codeset): Likewise. * locale/programs/locarchive.c (add_locale_to_archive): Likewise. (add_locales_to_archive): Likewise. (delete_locales_from_archive): Likewise. * malloc/malloc.c (__libc_mallinfo): Likewise. * math/gen-auto-libm-tests.c (init_fp_formats): Likewise. * misc/tsearch.c (__tfind): Likewise. * nptl/pthread_attr_destroy.c (__pthread_attr_destroy): Likewise. * nptl/pthread_attr_getdetachstate.c (__pthread_attr_getdetachstate): Likewise. * nptl/pthread_attr_getguardsize.c (pthread_attr_getguardsize): Likewise. * nptl/pthread_attr_getinheritsched.c (__pthread_attr_getinheritsched): Likewise. * nptl/pthread_attr_getschedparam.c (__pthread_attr_getschedparam): Likewise. * nptl/pthread_attr_getschedpolicy.c (__pthread_attr_getschedpolicy): Likewise. * nptl/pthread_attr_getscope.c (__pthread_attr_getscope): Likewise. * nptl/pthread_attr_getstack.c (__pthread_attr_getstack): Likewise. * nptl/pthread_attr_getstackaddr.c (__pthread_attr_getstackaddr): Likewise. * nptl/pthread_attr_getstacksize.c (__pthread_attr_getstacksize): Likewise. * nptl/pthread_attr_init.c (__pthread_attr_init_2_1): Likewise. (__pthread_attr_init_2_0): Likewise. * nptl/pthread_attr_setdetachstate.c (__pthread_attr_setdetachstate): Likewise. * nptl/pthread_attr_setguardsize.c (pthread_attr_setguardsize): Likewise. * nptl/pthread_attr_setinheritsched.c (__pthread_attr_setinheritsched): Likewise. * nptl/pthread_attr_setschedparam.c (__pthread_attr_setschedparam): Likewise. * nptl/pthread_attr_setschedpolicy.c (__pthread_attr_setschedpolicy): Likewise. * nptl/pthread_attr_setscope.c (__pthread_attr_setscope): Likewise. * nptl/pthread_attr_setstack.c (__pthread_attr_setstack): Likewise. * nptl/pthread_attr_setstackaddr.c (__pthread_attr_setstackaddr): Likewise. * nptl/pthread_attr_setstacksize.c (__pthread_attr_setstacksize): Likewise. * nptl/pthread_condattr_setclock.c (pthread_condattr_setclock): Likewise. * nptl/pthread_create.c (__find_in_stack_list): Likewise. * nptl/pthread_getattr_np.c (pthread_getattr_np): Likewise. * nptl/pthread_mutex_cond_lock.c (__pthread_mutex_lock): Define to use internal_function. * nptl/pthread_mutex_init.c (__pthread_mutex_init): Convert to prototype-style function definition. * nptl/pthread_mutex_lock.c (__pthread_mutex_lock): Likewise. (__pthread_mutex_cond_lock_adjust): Likewise. Use internal_function. * nptl/pthread_mutex_timedlock.c (pthread_mutex_timedlock): Convert to prototype-style function definition. * nptl/pthread_mutex_trylock.c (__pthread_mutex_trylock): Likewise. * nptl/pthread_mutex_unlock.c (__pthread_mutex_unlock_usercnt): Likewise. (__pthread_mutex_unlock): Likewise. * nptl_db/td_ta_clear_event.c (td_ta_clear_event): Likewise. * nptl_db/td_ta_set_event.c (td_ta_set_event): Likewise. * nptl_db/td_thr_clear_event.c (td_thr_clear_event): Likewise. * nptl_db/td_thr_event_enable.c (td_thr_event_enable): Likewise. * nptl_db/td_thr_set_event.c (td_thr_set_event): Likewise. * nss/makedb.c (process_input): Likewise. * posix/fnmatch.c (__strchrnul): Likewise. (__wcschrnul): Likewise. (fnmatch): Likewise. * posix/fnmatch_loop.c (FCT): Likewise. * posix/glob.c (globfree): Likewise. (__glob_pattern_type): Likewise. (__glob_pattern_p): Likewise. * posix/regcomp.c (re_compile_pattern): Likewise. (re_set_syntax): Likewise. (re_compile_fastmap): Likewise. (regcomp): Likewise. (regerror): Likewise. (regfree): Likewise. * posix/regexec.c (regexec): Likewise. (re_match): Likewise. (re_search): Likewise. (re_match_2): Likewise. (re_search_2): Likewise. (re_search_stub): Likewise. Use internal_function (re_copy_regs): Likewise. (re_set_registers): Convert to prototype-style function definition. (prune_impossible_nodes): Likewise. Use internal_function. * resolv/inet_net_pton.c (inet_net_pton): Convert to prototype-style function definition. (inet_net_pton_ipv4): Likewise. * stdlib/strtod_l.c (____STRTOF_INTERNAL): Likewise. * sysdeps/pthread/aio_cancel.c (aio_cancel): Likewise. * sysdeps/pthread/aio_suspend.c (aio_suspend): Likewise. * sysdeps/pthread/timer_delete.c (timer_delete): Likewise. * sysdeps/unix/sysv/linux/dl-openat64.c (openat64): Likewise. Make variadic. * time/strptime_l.c (localtime_r): Convert to prototype-style function definition. * wcsmbs/mbsnrtowcs.c (__mbsnrtowcs): Likewise. * wcsmbs/mbsrtowcs_l.c (__mbsrtowcs_l): Likewise. * wcsmbs/wcsnrtombs.c (__wcsnrtombs): Likewise. * wcsmbs/wcsrtombs.c (__wcsrtombs): Likewise. |
||
|---|---|---|
| .. | ||
| bits | ||
| rxspencer | ||
| sys | ||
| _exit.c | ||
| alarm.c | ||
| annexc.c | ||
| BOOST.tests | ||
| bsd-getpgrp.c | ||
| bug-ga1.c | ||
| bug-ga2.c | ||
| bug-getopt1.c | ||
| bug-getopt2.c | ||
| bug-getopt3.c | ||
| bug-getopt4.c | ||
| bug-getopt5.c | ||
| bug-glob1.c | ||
| bug-glob2.c | ||
| bug-glob3.c | ||
| bug-regex1.c | ||
| bug-regex2.c | ||
| bug-regex3.c | ||
| bug-regex4.c | ||
| bug-regex5.c | ||
| bug-regex6.c | ||
| bug-regex7.c | ||
| bug-regex8.c | ||
| bug-regex9.c | ||
| bug-regex10.c | ||
| bug-regex11.c | ||
| bug-regex12.c | ||
| bug-regex13.c | ||
| bug-regex14.c | ||
| bug-regex15.c | ||
| bug-regex16.c | ||
| bug-regex17.c | ||
| bug-regex18.c | ||
| bug-regex19.c | ||
| bug-regex20.c | ||
| bug-regex21.c | ||
| bug-regex22.c | ||
| bug-regex23.c | ||
| bug-regex24.c | ||
| bug-regex25.c | ||
| bug-regex26.c | ||
| bug-regex27.c | ||
| bug-regex28.c | ||
| bug-regex29.c | ||
| bug-regex30.c | ||
| bug-regex31.c | ||
| bug-regex31.input | ||
| bug-regex32.c | ||
| bug-regex33.c | ||
| bug-regex34.c | ||
| bug-regex35.c | ||
| bug-regex36.c | ||
| confstr.c | ||
| cpio.h | ||
| Depend | ||
| environ.c | ||
| execl.c | ||
| execle.c | ||
| execlp.c | ||
| execv.c | ||
| execve.c | ||
| execvp.c | ||
| execvpe.c | ||
| fexecve.c | ||
| fnmatch_loop.c | ||
| fnmatch.c | ||
| fnmatch.h | ||
| fork.c | ||
| fpathconf.c | ||
| gai_strerror.c | ||
| gai.conf | ||
| get_child_max.c | ||
| getaddrinfo.c | ||
| getconf-speclist.c | ||
| getconf.c | ||
| getegid.c | ||
| geteuid.c | ||
| getgid.c | ||
| getgroups.c | ||
| getopt1.c | ||
| getopt_init.c | ||
| getopt_int.h | ||
| getopt.c | ||
| getopt.h | ||
| getpgid.c | ||
| getpgrp.c | ||
| getpid.c | ||
| getppid.c | ||
| getresgid.c | ||
| getresuid.c | ||
| getsid.c | ||
| getuid.c | ||
| glob64.c | ||
| glob.c | ||
| glob.h | ||
| globtest.c | ||
| globtest.sh | ||
| group_member.c | ||
| init-posix.c | ||
| Makefile | ||
| nanosleep.c | ||
| pathconf.c | ||
| pause.c | ||
| PCRE.tests | ||
| posix_madvise.c | ||
| posix-conf-vars.h | ||
| posix-conf-vars.list | ||
| posix-envs.def | ||
| pread64.c | ||
| pread.c | ||
| ptestcases.h | ||
| PTESTS | ||
| PTESTS2C.sed | ||
| pwrite64.c | ||
| pwrite.c | ||
| re_comp.h | ||
| regcomp.c | ||
| regex_internal.c | ||
| regex_internal.h | ||
| regex.c | ||
| regex.h | ||
| regexbug1.c | ||
| regexec.c | ||
| runptests.c | ||
| runtests.c | ||
| sched_cpualloc.c | ||
| sched_cpucount.c | ||
| sched_cpufree.c | ||
| sched_getaffinity.c | ||
| sched_getp.c | ||
| sched_gets.c | ||
| sched_primax.c | ||
| sched_primin.c | ||
| sched_rr_gi.c | ||
| sched_setaffinity.c | ||
| sched_setp.c | ||
| sched_sets.c | ||
| sched_yield.c | ||
| sched.h | ||
| setgid.c | ||
| setpgid.c | ||
| setpgrp.c | ||
| setresgid.c | ||
| setresuid.c | ||
| setsid.c | ||
| setuid.c | ||
| sleep.c | ||
| spawn_faction_addclose.c | ||
| spawn_faction_adddup2.c | ||
| spawn_faction_addopen.c | ||
| spawn_faction_destroy.c | ||
| spawn_faction_init.c | ||
| spawn_int.h | ||
| spawn.c | ||
| spawn.h | ||
| spawnattr_destroy.c | ||
| spawnattr_getdefault.c | ||
| spawnattr_getflags.c | ||
| spawnattr_getpgroup.c | ||
| spawnattr_getschedparam.c | ||
| spawnattr_getschedpolicy.c | ||
| spawnattr_getsigmask.c | ||
| spawnattr_init.c | ||
| spawnattr_setdefault.c | ||
| spawnattr_setflags.c | ||
| spawnattr_setpgroup.c | ||
| spawnattr_setschedparam.c | ||
| spawnattr_setschedpolicy.c | ||
| spawnattr_setsigmask.c | ||
| spawni.c | ||
| spawnp.c | ||
| sysconf.c | ||
| tar.h | ||
| test-vfork.c | ||
| testcases.h | ||
| testfnm.c | ||
| TESTS | ||
| TESTS2C.sed | ||
| times.c | ||
| transbug.c | ||
| tst-boost.c | ||
| tst-chmod.c | ||
| tst-cpucount.c | ||
| tst-cpuset.c | ||
| tst-dir.c | ||
| tst-exec-static.c | ||
| tst-exec.c | ||
| tst-execl1.c | ||
| tst-execl2.c | ||
| tst-execle1.c | ||
| tst-execle2.c | ||
| tst-execlp1.c | ||
| tst-execlp2.c | ||
| tst-execv1.c | ||
| tst-execv2.c | ||
| tst-execve1.c | ||
| tst-execve2.c | ||
| tst-execvp1.c | ||
| tst-execvp2.c | ||
| tst-execvp3.c | ||
| tst-execvp4.c | ||
| tst-fnmatch2.c | ||
| tst-fnmatch3.c | ||
| tst-fnmatch.c | ||
| tst-fnmatch.input | ||
| tst-fork.c | ||
| tst-getaddrinfo2.c | ||
| tst-getaddrinfo3.c | ||
| tst-getaddrinfo4.c | ||
| tst-getaddrinfo5.c | ||
| tst-getaddrinfo.c | ||
| tst-getconf.sh | ||
| tst-getopt_long1.c | ||
| tst-gnuglob.c | ||
| tst-mmap-offset.c | ||
| tst-mmap.c | ||
| tst-nanosleep.c | ||
| tst-nice.c | ||
| tst-pathconf.c | ||
| tst-pcre.c | ||
| tst-preadwrite64.c | ||
| tst-preadwrite.c | ||
| tst-regex2.c | ||
| tst-regex.c | ||
| tst-regexloc.c | ||
| tst-rfc3484-2.c | ||
| tst-rfc3484-3.c | ||
| tst-rfc3484.c | ||
| tst-rxspencer-no-utf8.c | ||
| tst-rxspencer.c | ||
| tst-spawn-static.c | ||
| tst-spawn.c | ||
| tst-sysconf.c | ||
| tst-truncate64.c | ||
| tst-truncate.c | ||
| tst-vfork1.c | ||
| tst-vfork2.c | ||
| tst-vfork3.c | ||
| tst-waitid.c | ||
| tstgetopt.c | ||
| uname-values.h | ||
| uname.c | ||
| unistd.h | ||
| Versions | ||
| vfork.c | ||
| wait3.c | ||
| wait4.c | ||
| wait.c | ||
| wait.h | ||
| waitid.c | ||
| waitpid.c | ||
| wordexp-test.c | ||
| wordexp-tst.sh | ||
| wordexp.c | ||
| wordexp.h | ||