mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-11-21 01:12:26 +08:00
Code Issues Packages Projects Releases Wiki Activity
9d6861b8c3
glibc/misc
History
Mark Wielaard 9d6861b8c3 Reduce memory size of tsearch red-black tree. 
A tsearch red-black tree node contains 3 pointers (key, left, right)
and 1 bit to hold the red-black flag. When allocating new nodes
this 1 bit is expanded to a full word. Causing the overhead per node
to be 3 times the key size.

We can reduce this overhead to just 2 times the key size.
malloc returns naturally aligned memory. All nodes are internally
allocated with malloc and the left/right node pointers are used
as implementation details. So we can use the low bits of the
left/right node pointers to store extra information.

Replace all direct accesses of the struct node_t node pointers and
red-black value with defines that take care of the red-black flag in
the low bit of the (left) node pointer. This reduces the size of the
nodes on 32-bit systems from 16 to 12 bytes and on 64-bit systems
from 32 to 24 bytes.

Also fix a call to CHECK_TREE so the code can be build (and tested)
with DEBUGGING defined again.

V2 changes:

- Add assert after malloc to catch any odd pointers from bad
  interposed mallocs.
- Rename implementation flag to USE_MALLOC_LOW_BIT.

ChangeLog:

       * misc/tsearch.c (struct node_t): Reduce to 3 pointers if
       USE_MALLOC_LOW_BIT.  Define pointer/value accessors.
       (check_tree_recurse): Use newly defined accessors.
       (check_tree): Likewise.
       (maybe_split_for_insert): Likewise.
       (__tfind): Likewise.
       (__tdelete): Likewise.
       (trecurse): Likewise.
       (tdestroy_recurse): Likewise.
       (__tsearch): Likewise. And add asserts for malloc alignment.
       (__twalk): Cast root to node in case CHECK_TREE is defined.
2016-08-25 23:48:05 +02:00
..
bits Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
sys Deprecate inclusion of <sys/sysmacros.h> by <sys/types.h> 2016-08-03 15:28:49 -04:00
acct.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ar.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
brk.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
bug18240.c hsearch_r: Apply VM size limit in test case 2016-02-12 12:57:40 +01:00
bug-hsearch1.c
chflags.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
chroot.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
daemon.c Convert 29 more function definitions to prototype style (multiple parameters in one K&R parameter declaration). 2015-10-20 11:52:27 +00:00
dirname.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
efgcvt_r.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
efgcvt.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
err.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
err.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
error.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
error.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fchflags.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fdatasync.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fgetxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
flistxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fremovexattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fsetxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fstab.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fstab.h
fsync.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ftruncate64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ftruncate.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
futimes.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
futimesat.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getauxval.c Fix crash on getauxval call without HAVE_AUX_VECTOR 2016-04-10 23:58:43 +02:00
getclktck.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getdomain.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getdtsz.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
gethostid.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
gethostname.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getloadavg.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getpagesize.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getpass.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getsysstats.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getttyent.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
getusershell.c
getxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
gtty.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
hsearch_r.c hsearch_r: Include <limits.h> 2016-04-07 13:48:00 +02:00
hsearch.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ifunc-impl-list.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
init-misc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
insremque.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ioctl.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
lgetxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
libgen.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
listxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
llistxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
lremovexattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
lsearch.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
lsetxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
lutimes.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
madvise.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
makedev.c Minimize sysdeps code involved in defining major/minor/makedev. 2016-08-03 15:23:04 -04:00
Makefile Minimize sysdeps code involved in defining major/minor/makedev. 2016-08-03 15:23:04 -04:00
mincore.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkdtemp.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkostemp64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkostemp.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkostemps64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkostemps.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkstemp64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkstemp.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkstemps64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mkstemps.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mktemp.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mlock.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mlockall.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mmap64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mmap.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mntent_r.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mntent.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mntent.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
mprotect.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
msync.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
munlock.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
munlockall.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
munmap.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
preadv64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
preadv.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
pselect.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ptrace.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
pwritev64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
pwritev.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
qefgcvt_r.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
qefgcvt.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
readv.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
reboot.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
regexp.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
regexp.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
remap_file_pages.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
removexattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
revoke.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
sbrk.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
search.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
select.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
setdomain.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
setegid.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
seteuid.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
sethostid.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
sethostname.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
setregid.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
setreuid.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
setxattr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
sgtty.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
sstk.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
stab.h
stty.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
swapoff.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
swapon.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
sync.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
syncfs.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
syscall.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
syscall.h
sysexits.h
syslog.c Assume that SOCK_CLOEXEC is available and works 2015-10-17 12:02:37 +02:00
syslog.h
truncate64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
truncate.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tsearch.c Reduce memory size of tsearch red-black tree. 2016-08-25 23:48:05 +02:00
tst-dirname.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-efgcvt.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-error1.c
tst-fdset.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-hsearch.c
tst-insremque.c
tst-makedev.c Minimize sysdeps code involved in defining major/minor/makedev. 2016-08-03 15:23:04 -04:00
tst-mntent2.c
tst-mntent-blank-corrupt.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-mntent-blank-passno.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-mntent.c getmntent: fix memory corruption w/blank lines [BZ #18887] 2015-08-29 18:07:00 -04:00
tst-preadvwritev64.c Fix LO_HI_LONG definition 2016-07-08 15:41:21 -03:00
tst-preadvwritev-common.c Fix LO_HI_LONG definition 2016-07-08 15:41:21 -03:00
tst-preadvwritev.c Fix LO_HI_LONG definition 2016-07-08 15:41:21 -03:00
tst-pselect.c
tst-tsearch.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ttyent.h
ttyslot.c Fix ttyslot namespace (bug 18547). 2015-06-17 20:21:19 +00:00
ualarm.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
usleep.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ustat.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ustat.h
utimes.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
Versions Minimize sysdeps code involved in defining major/minor/makedev. 2016-08-03 15:23:04 -04:00
vhangup.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
writev.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00