glibc/sysdeps/unix
Meador Inge 995a46bbfb get_nprocs: Only return explictly set cache values (BZ #16996)
The implementation of __get_nprocs uses a stactic variable to cache
the value of the current number of processors.  The caching breaks when
'time (NULL) == 0':

  $ cat nproc.c
  #include <stdio.h>
  #include <time.h>
  #include <sys/time.h>

  int main(int argc, char *argv[])
  {
    time_t t;
    struct timeval tv = {0, 0};
    printf("settimeofday({0, 0}, NULL) = %d\n", settimeofday(&tv, NULL));
    t = time(NULL);
    printf("Time: %d, CPUs: %d\n", (unsigned int)t, get_nprocs());
    return 0;
  }
  $ gcc -O3 nproc.c
  $ ./a.out
  settimeofday({0, 0}, NULL) = -1
  Time: 1401311578, CPUs: 4
  $ sudo ./a.out
  settimeofday({0, 0}, NULL) = 0
  Time: 0, CPUs: 0

The problem is with the condition used to check whether a cached
value should be returned or not:

  static int cached_result;
  static time_t timestamp;

  time_t now = time (NULL);
  time_t prev = timestamp;
  atomic_read_barrier ();
  if (now == prev)
    return cached_result;

This patch fixes the problem by ensuring that 'cached_result' has
been set at least once before returning it.
2014-06-13 14:02:04 +05:30
..
alpha alpha: Fix __pointer_chk_guard definition for the testsuite 2014-04-16 21:35:27 -07:00
arm
bsd
i386
inet
mips
powerpc
sh
sysv/linux get_nprocs: Only return explictly set cache values (BZ #16996) 2014-06-13 14:02:04 +05:30
x86_64
clock_gettime.c
clock_nanosleep.c
clock_settime.c
confstr.h
get_child_max.c
getlogin_r.c
getlogin.c
getpagesize.c
grantpt.c Fix macro warning on HAVE_PT_CHOWN 2014-05-14 09:46:54 +02:00
ifreq.c
Implies
make-syscalls.sh
Makefile
s-proto-cancel.S
s-proto.S
setxid.h
sockatmark.c
stime.c
Subdirs
syscall-template.S
syscall.S
syscalls.list
sysdep.h