mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2025-02-11 12:50:58 +08:00
Code Issues Packages Projects Releases Wiki Activity
939fdd1c36
glibc/math/bits/math-finite.h
Joseph Myers 939fdd1c36 Fix finite-math-only lgamma functions signgam setting (bug 19211). 
The lgamma inline functions in bits/math-finite.h do not set signgam
if __USE_ISOC99, even when other feature test macros mean a standard
such as XSI POSIX is selected for which it should be set.  (This is
essentially the opposite issue to bug 15421, the out-of-line versions
setting signgam even when they shouldn't.)

This patch fixes those functions to use __USE_MISC || __USE_XOPEN as
the condition for when to set signgam, since it's the condition for
when math.h declares signgam.  The legacy gamma* names are only
declared at all if __USE_MISC || __USE_XOPEN, so they just set signgam
unconditionally.

Tests for certain standards or not using _GNU_SOURCE cannot use
test-skeleton.c (this is a known issue noted on the wiki todo list).
Thus, the new tests that signgam remains not set in ISO C modes do not
use test-skeleton.c.  They also define _ISOMAC to avoid running into
declarations in the internal include/ headers that only work in
_GNU_SOURCE mode.

Tested for x86_64 and x86.

	[BZ #19211]
	* math/bits/math-finite.h (lgamma): Set signgam if [__USE_MISC ||
	__USE_XOPEN], not if [!__USE_ISOC99].
	(lgammaf): Likewise.
	(lgammal): Likewise.
	(gamma): Set signgam unconditionally, not if [!__USE_ISOC99].
	(gammaf): Likewise.
	(gammal): Likewise.
	* math/test-signgam-finite-c11.c: New file.
	* math/test-signgam-finite-c99.c: Likewise.
	* math/test-signgam-finite.c: Likewise.
	* math/Makefile (tests): Add test-signgam-finite,
	test-signgam-finite-c99 and test-signgam-finite-c11.
	(CFLAGS-test-signgam-finite.c): New variable.
	(CFLAGS-test-signgam-finite-c99.c): Likewise.
	(CFLAGS-test-signgam-finite-c11.c): Likewise.
2015-11-05 21:23:07 +00:00

507 lines
15 KiB
C
Raw Blame History

/* Entry points to finite-math-only compiler runs.
Copyright (C) 2011-2015 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
#ifndef _MATH_H
# error "Never use <bits/math-finite.h> directly; include <math.h> instead."
#endif
/* acos. */
extern double __REDIRECT_NTH (acos, (double), __acos_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (acosf, (float), __acosf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (acosl, (long double), __acos_finite);
# else
extern long double __REDIRECT_NTH (acosl, (long double), __acosl_finite);
# endif
# endif
#endif
#if defined __USE_XOPEN_EXTENDED || defined __USE_ISOC99
/* acosh. */
extern double __REDIRECT_NTH (acosh, (double), __acosh_finite);
#endif
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (acoshf, (float), __acoshf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (acoshl, (long double), __acosh_finite);
# else
extern long double __REDIRECT_NTH (acoshl, (long double), __acoshl_finite);
# endif
# endif
#endif
/* asin. */
extern double __REDIRECT_NTH (asin, (double), __asin_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (asinf, (float), __asinf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (asinl, (long double), __asin_finite);
# else
extern long double __REDIRECT_NTH (asinl, (long double), __asinl_finite);
# endif
# endif
#endif
/* atan2. */
extern double __REDIRECT_NTH (atan2, (double, double), __atan2_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (atan2f, (float, float), __atan2f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (atan2l, (long double, long double),
__atan2_finite);
# else
extern long double __REDIRECT_NTH (atan2l, (long double, long double),
__atan2l_finite);
# endif
# endif
#endif
#if defined __USE_XOPEN_EXTENDED || defined __USE_ISOC99
/* atanh. */
extern double __REDIRECT_NTH (atanh, (double), __atanh_finite);
#endif
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (atanhf, (float), __atanhf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (atanhl, (long double), __atanh_finite);
# else
extern long double __REDIRECT_NTH (atanhl, (long double), __atanhl_finite);
# endif
# endif
#endif
/* cosh. */
extern double __REDIRECT_NTH (cosh, (double), __cosh_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (coshf, (float), __coshf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (coshl, (long double), __cosh_finite);
# else
extern long double __REDIRECT_NTH (coshl, (long double), __coshl_finite);
# endif
# endif
#endif
/* exp. */
extern double __REDIRECT_NTH (exp, (double), __exp_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (expf, (float), __expf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (expl, (long double), __exp_finite);
# else
extern long double __REDIRECT_NTH (expl, (long double), __expl_finite);
# endif
# endif
#endif
#ifdef __USE_GNU
/* exp10. */
extern double __REDIRECT_NTH (exp10, (double), __exp10_finite);
extern float __REDIRECT_NTH (exp10f, (float), __exp10f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (exp10l, (long double), __exp10_finite);
# else
extern long double __REDIRECT_NTH (exp10l, (long double), __exp10l_finite);
# endif
# endif
/* pow10. */
extern double __REDIRECT_NTH (pow10, (double), __exp10_finite);
extern float __REDIRECT_NTH (pow10f, (float), __exp10f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (pow10l, (long double), __exp10_finite);
# else
extern long double __REDIRECT_NTH (pow10l, (long double), __exp10l_finite);
# endif
# endif
#endif
#ifdef __USE_ISOC99
/* exp2. */
extern double __REDIRECT_NTH (exp2, (double), __exp2_finite);
extern float __REDIRECT_NTH (exp2f, (float), __exp2f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (exp2l, (long double), __exp2_finite);
# else
extern long double __REDIRECT_NTH (exp2l, (long double), __exp2l_finite);
# endif
# endif
#endif
/* fmod. */
extern double __REDIRECT_NTH (fmod, (double, double), __fmod_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (fmodf, (float, float), __fmodf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (fmodl, (long double, long double),
__fmod_finite);
# else
extern long double __REDIRECT_NTH (fmodl, (long double, long double),
__fmodl_finite);
# endif
# endif
#endif
#if defined __USE_XOPEN || defined __USE_ISOC99
/* hypot. */
extern double __REDIRECT_NTH (hypot, (double, double), __hypot_finite);
#endif
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (hypotf, (float, float), __hypotf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (hypotl, (long double, long double),
__hypot_finite);
# else
extern long double __REDIRECT_NTH (hypotl, (long double, long double),
__hypotl_finite);
# endif
# endif
#endif
#if defined __USE_MISC || defined __USE_XOPEN
/* j0. */
extern double __REDIRECT_NTH (j0, (double), __j0_finite);
#endif
#if defined __USE_MISC && defined __USE_ISOC99
extern float __REDIRECT_NTH (j0f, (float), __j0f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (j0l, (long double), __j0_finite);
# else
extern long double __REDIRECT_NTH (j0l, (long double), __j0l_finite);
# endif
# endif
#endif
#if defined __USE_MISC || defined __USE_XOPEN
/* y0. */
extern double __REDIRECT_NTH (y0, (double), __y0_finite);
#endif
#if defined __USE_MISC && defined __USE_ISOC99
extern float __REDIRECT_NTH (y0f, (float), __y0f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (y0l, (long double), __y0_finite);
# else
extern long double __REDIRECT_NTH (y0l, (long double), __y0l_finite);
# endif
# endif
#endif
#if defined __USE_MISC || defined __USE_XOPEN
/* j1. */
extern double __REDIRECT_NTH (j1, (double), __j1_finite);
#endif
#if defined __USE_MISC && defined __USE_ISOC99
extern float __REDIRECT_NTH (j1f, (float), __j1f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (j1l, (long double), __j1_finite);
# else
extern long double __REDIRECT_NTH (j1l, (long double), __j1l_finite);
# endif
# endif
#endif
#if defined __USE_MISC || defined __USE_XOPEN
/* y1. */
extern double __REDIRECT_NTH (y1, (double), __y1_finite);
#endif
#if defined __USE_MISC && defined __USE_ISOC99
extern float __REDIRECT_NTH (y1f, (float), __y1f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (y1l, (long double), __y1_finite);
# else
extern long double __REDIRECT_NTH (y1l, (long double), __y1l_finite);
# endif
# endif
#endif
#if defined __USE_MISC || defined __USE_XOPEN
/* jn. */
extern double __REDIRECT_NTH (jn, (int, double), __jn_finite);
#endif
#if defined __USE_MISC && defined __USE_ISOC99
extern float __REDIRECT_NTH (jnf, (int, float), __jnf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (jnl, (int, long double), __jn_finite);
# else
extern long double __REDIRECT_NTH (jnl, (int, long double), __jnl_finite);
# endif
# endif
#endif
#if defined __USE_MISC || defined __USE_XOPEN
/* yn. */
extern double __REDIRECT_NTH (yn, (int, double), __yn_finite);
#endif
#if defined __USE_MISC && defined __USE_ISOC99
extern float __REDIRECT_NTH (ynf, (int, float), __ynf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (ynl, (int, long double), __yn_finite);
# else
extern long double __REDIRECT_NTH (ynl, (int, long double), __ynl_finite);
# endif
# endif
#endif
#ifdef __USE_MISC
/* lgamma_r. */
extern double __REDIRECT_NTH (lgamma_r, (double, int *), __lgamma_r_finite);
# ifdef __USE_ISOC99
extern float __REDIRECT_NTH (lgammaf_r, (float, int *), __lgammaf_r_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (lgammal_r, (long double, int *),
__lgamma_r_finite);
# else
extern long double __REDIRECT_NTH (lgammal_r, (long double, int *),
__lgammal_r_finite);
# endif
# endif
# endif
#endif
extern double __lgamma_r_finite (double, int *);
extern float __lgammaf_r_finite (float, int *);
#ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (__lgammal_r_finite, (long double, int *),
__lgamma_r_finite);
#else
extern long double __lgammal_r_finite (long double, int *);
#endif
#if ((defined __USE_XOPEN || defined __USE_ISOC99) \
&& defined __extern_always_inline)
/* lgamma. */
__extern_always_inline double __NTH (lgamma (double __d))
{
# if defined __USE_MISC || defined __USE_XOPEN
return __lgamma_r_finite (__d, &signgam);
# else
int __local_signgam = 0;
return __lgamma_r_finite (__d, &__local_signgam);
# endif
}
#endif
#if defined __USE_ISOC99 && defined __extern_always_inline
__extern_always_inline float __NTH (lgammaf (float __d))
{
# if defined __USE_MISC || defined __USE_XOPEN
return __lgammaf_r_finite (__d, &signgam);
# else
int __local_signgam = 0;
return __lgammaf_r_finite (__d, &__local_signgam);
# endif
}
# ifdef __MATH_DECLARE_LDOUBLE
__extern_always_inline long double __NTH (lgammal (long double __d))
{
# if defined __USE_MISC || defined __USE_XOPEN
return __lgammal_r_finite (__d, &signgam);
# else
int __local_signgam = 0;
return __lgammal_r_finite (__d, &__local_signgam);
# endif
}
# endif
#endif
#if ((defined __USE_MISC || (defined __USE_XOPEN && !defined __USE_XOPEN2K)) \
&& defined __extern_always_inline)
/* gamma. */
__extern_always_inline double __NTH (gamma (double __d))
{
return __lgamma_r_finite (__d, &signgam);
}
# ifdef __USE_ISOC99
__extern_always_inline float __NTH (gammaf (float __d))
{
return __lgammaf_r_finite (__d, &signgam);
}
# ifdef __MATH_DECLARE_LDOUBLE
__extern_always_inline long double __NTH (gammal (long double __d))
{
return __lgammal_r_finite (__d, &signgam);
}
# endif
# endif
#endif
/* log. */
extern double __REDIRECT_NTH (log, (double), __log_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (logf, (float), __logf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (logl, (long double), __log_finite);
# else
extern long double __REDIRECT_NTH (logl, (long double), __logl_finite);
# endif
# endif
#endif
/* log10. */
extern double __REDIRECT_NTH (log10, (double), __log10_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (log10f, (float), __log10f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (log10l, (long double), __log10_finite);
# else
extern long double __REDIRECT_NTH (log10l, (long double), __log10l_finite);
# endif
# endif
#endif
#ifdef __USE_ISOC99
/* log2. */
extern double __REDIRECT_NTH (log2, (double), __log2_finite);
extern float __REDIRECT_NTH (log2f, (float), __log2f_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (log2l, (long double), __log2_finite);
# else
extern long double __REDIRECT_NTH (log2l, (long double), __log2l_finite);
# endif
# endif
#endif
/* pow. */
extern double __REDIRECT_NTH (pow, (double, double), __pow_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (powf, (float, float), __powf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (powl, (long double, long double),
__pow_finite);
# else
extern long double __REDIRECT_NTH (powl, (long double, long double),
__powl_finite);
# endif
# endif
#endif
#if defined __USE_XOPEN_EXTENDED || defined __USE_ISOC99
/* remainder. */
extern double __REDIRECT_NTH (remainder, (double, double), __remainder_finite);
#endif
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (remainderf, (float, float), __remainderf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (remainderl, (long double, long double),
__remainder_finite);
# else
extern long double __REDIRECT_NTH (remainderl, (long double, long double),
__remainderl_finite);
# endif
# endif
#endif
#if (defined __USE_MISC \
|| (defined __USE_XOPEN_EXTENDED && !defined __USE_XOPEN2K8))
/* scalb. */
extern double __REDIRECT_NTH (scalb, (double, double), __scalb_finite);
#endif
#if defined __USE_MISC && defined __USE_ISOC99
extern float __REDIRECT_NTH (scalbf, (float, float), __scalbf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (scalbl, (long double, long double),
__scalb_finite);
# else
extern long double __REDIRECT_NTH (scalbl, (long double, long double),
__scalbl_finite);
# endif
# endif
#endif
/* sinh. */
extern double __REDIRECT_NTH (sinh, (double), __sinh_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (sinhf, (float), __sinhf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (sinhl, (long double), __sinh_finite);
# else
extern long double __REDIRECT_NTH (sinhl, (long double), __sinhl_finite);
# endif
# endif
#endif
/* sqrt. */
extern double __REDIRECT_NTH (sqrt, (double), __sqrt_finite);
#ifdef __USE_ISOC99
extern float __REDIRECT_NTH (sqrtf, (float), __sqrtf_finite);
# ifdef __MATH_DECLARE_LDOUBLE
# ifdef __NO_LONG_DOUBLE_MATH
extern long double __REDIRECT_NTH (sqrtl, (long double), __sqrt_finite);
# else
extern long double __REDIRECT_NTH (sqrtl, (long double), __sqrtl_finite);
# endif
# endif
#endif
#if defined __USE_ISOC99 && defined __extern_always_inline
/* tgamma. */
extern double __gamma_r_finite (double, int *);
__extern_always_inline double __NTH (tgamma (double __d))
{
int __local_signgam = 0;
double __res = __gamma_r_finite (__d, &__local_signgam);
return __local_signgam < 0 ? -__res : __res;
}
extern float __gammaf_r_finite (float, int *);
__extern_always_inline float __NTH (tgammaf (float __d))
{
int __local_signgam = 0;
float __res = __gammaf_r_finite (__d, &__local_signgam);
return __local_signgam < 0 ? -__res : __res;
}
# ifdef __MATH_DECLARE_LDOUBLE
extern long double __gammal_r_finite (long double, int *);
__extern_always_inline long double __NTH (tgammal (long double __d))
{
int __local_signgam = 0;
# ifdef __NO_LONG_DOUBLE_MATH
long double __res = __gamma_r_finite (__d, &__local_signgam);
# else
long double __res = __gammal_r_finite (__d, &__local_signgam);
# endif
return __local_signgam < 0 ? -__res : __res;
}
# endif
#endif
Reference in New Issue View Git Blame Copy Permalink