mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2025-02-05 12:40:55 +08:00
Code Issues Packages Projects Releases Wiki Activity
869c2f1eae
glibc/wcsmbs
History
Joseph Myers f5eee5c72b Fix strtol in Turkish locales (bug 19242). 
The implementations of strtol and related functions use
locale-specific conversions to upper case before determining whether a
character is a valid letter in the argument.  This means that in
Turkish locales such as tr_TR.UTF-8 and tr_TR.ISO-8859-9, "i" is
interpreted as not being a valid number, when if the base passed to
strtol is 19 or more it should be interpreted as the number 18.

ISO C explicitly says "The letters from a (or A) through z (or Z) are
ascribed the values 10 through 35", so clearly intends the standard
ASCII letters (otherwise you wouldn't generally have exactly 26
letters to ascribe such values) (whereas white-space must be
identified according to the locale).  In particular, 'i' and 'I' must
be understood to be in that sequence.

This patch makes the code do the case conversions and classification
in the C locale; the user's locale remains used for whitespace testing
(explicitly correct according to ISO C).  Note that the way the code
worked, the only non-ASCII letter that would previously have been
accepted would have been the Turkish 'ı' (dotless 'i'), because the
uppercase version of that in Turkish locales is 'I'.  This patch means
that will no longer be accepted, which seems appropriate.

Tested for x86_64 and x86.

	[BZ #19242]
	* stdlib/strtol_l.c (ISALPHA): Use _nl_C_locobj_ptr for locale.
	(TOUPPER): Likewise.
	* stdlib/tst-strtol-locale-main.c: New file.
	* stdlib/tst-strtol-locale.c: Likewise.
	* stdlib/Makefile (tests): Add tst-strtol-locale.
	[$(run-built-tests) = yes] (LOCALES): Add tr_TR.ISO-8859-9.
	[$(run-built-tests) = yes] ($(objpfx)tst-strtol-locale.out):
	Depend on $(gen-locales).
	* wcsmbs/tst-wcstol-locale.c: New file.
	* wcsmbs/Makefile (tests): Add tst-wcstol-locale.
	[$(run-built-tests) = yes] (LOCALES): Add tr_TR.UTF-8 and
	tr_TR.ISO-8859-9.
	[$(run-built-tests) = yes] ($(objpfx)tst-wcstol-locale.out):
	Depend on $(gen-locales).
2015-11-23 08:50:53 +00:00
..
bits Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
btowc.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
c16rtomb.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
Depend
isoc99_fwscanf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
isoc99_swscanf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
isoc99_vfwscanf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
isoc99_vswscanf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
isoc99_vwscanf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
isoc99_wscanf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
Makefile Fix strtol in Turkish locales (bug 19242). 2015-11-23 08:50:53 +00:00
mbrlen.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
mbrtoc16.c Handle mblen return code when n is zero. 2015-04-03 15:47:12 +02:00
mbrtowc.c Handle mblen return code when n is zero. 2015-04-03 15:47:12 +02:00
mbsinit.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
mbsnrtowcs.c Convert 113 more function definitions to prototype style (files with assertions). 2015-10-20 11:54:09 +00:00
mbsrtowcs_l.c Convert 113 more function definitions to prototype style (files with assertions). 2015-10-20 11:54:09 +00:00
mbsrtowcs.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
test-wcpcpy.c S390: Optimize stpcpy and wcpcpy. 2015-08-26 10:26:21 +02:00
test-wcpncpy.c S390: Optimize stpncpy and wcpncpy. 2015-08-26 10:26:21 +02:00
test-wcscat.c S390: Optimize strcat and wcscat. 2015-08-26 10:26:21 +02:00
test-wcschr.c
test-wcschrnul.c S390: Optimize strchrnul and wcschrnul. 2015-08-26 10:26:23 +02:00
test-wcscmp.c
test-wcscpy.c
test-wcscspn.c S390: Optimize strcspn and wcscspn. 2015-08-26 10:26:24 +02:00
test-wcslen.c
test-wcsncat.c S390: Optimize strncat wcsncat. 2015-08-26 10:26:22 +02:00
test-wcsncmp.c Use correct signedness in wcsncmp 2015-04-13 21:25:04 +02:00
test-wcsncpy.c S390: Optimize strncpy and wcsncpy. 2015-08-26 10:26:21 +02:00
test-wcsnlen.c S390: Optimize strnlen and wcsnlen. 2015-08-26 10:26:20 +02:00
test-wcspbrk.c S390: Optimize strpbrk and wcspbrk. 2015-08-26 10:26:24 +02:00
test-wcsrchr.c
test-wcsspn.c S390: Optimize strspn and wcsspn. 2015-08-26 10:26:24 +02:00
test-wmemchr.c S390: Optimize memchr, rawmemchr and wmemchr. 2015-08-26 10:26:24 +02:00
test-wmemcmp.c
test-wmemset.c S390: Optimize wmemset. 2015-08-26 10:26:25 +02:00
tst-btowc.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
tst-c16c32-1.c
tst-mbrtowc2.c
tst-mbrtowc.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
tst-mbsrtowcs.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
tst-wchar-h.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-wcpncpy.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
tst-wcrtomb.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
tst-wcsnlen.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
tst-wcstof.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-wcstol-locale.c Fix strtol in Turkish locales (bug 19242). 2015-11-23 08:50:53 +00:00
uchar.h Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
Versions
wchar.h Updated __nonnull annotations for wcscat, wcsncat, wcscmp and wcsncmp [BZ #18265] 2015-08-05 04:43:42 -04:00
wcpcpy.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcpncpy.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcrtomb.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcsatcliff.c
wcscasecmp_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcscasecmp.c Convert miscellaneous function definitions to prototype style. 2015-10-20 21:27:22 +00:00
wcscat.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcschr.c powerpc: Fix __wcschr static build 2015-04-15 16:01:48 -03:00
wcschrnul.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcscmp.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcscoll_l.c strcoll: Remove incorrect STRDIFF-based optimization (Bug 18589). 2015-10-08 16:41:45 -04:00
wcscoll.c Fix regcomp wcscoll, wcscmp namespace (bug 18497). 2015-06-09 21:07:30 +00:00
wcscpy.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcscspn.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsdup.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcslen.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsmbs-tst1.c Add dependencies on needed locales in each subdir tests (bug 18969) 2015-10-12 15:18:08 +02:00
wcsmbsload.c Move bits/libc-lock.h and bits/libc-lockP.h out of bits/ (bug 14912). 2015-09-08 21:11:03 +00:00
wcsmbsload.h Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcsncase_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcsncase.c Convert miscellaneous function definitions to prototype style. 2015-10-20 21:27:22 +00:00
wcsncat.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsncmp.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsncpy.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsnlen.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsnrtombs.c Convert 113 more function definitions to prototype style (files with assertions). 2015-10-20 11:54:09 +00:00
wcspbrk.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsrchr.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsrtombs.c Convert 113 more function definitions to prototype style (files with assertions). 2015-10-20 11:54:09 +00:00
wcsspn.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcsstr.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcstod_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstod.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstof_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstof.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstok.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcstol_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstol.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstold_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstold.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstoll_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstoll.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstoul_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstoul.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstoull_l.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcstoull.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcswidth.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcsxfrm_l.c Remove unused definitions 2015-02-11 12:50:53 +01:00
wcsxfrm.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wctob.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wcwidth.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wcwidth.h Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wmemchr.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wmemcmp.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wmemcpy.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wmemmove.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wmempcpy.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00
wmemset.c Convert 703 function definitions to prototype style. 2015-10-16 20:21:49 +00:00