mirror of
git://sourceware.org/git/glibc.git
synced 2024-11-27 03:41:23 +08:00
e02cabecf0
The nan* functions handle their string argument by constructing a NAN(...) string on the stack as a VLA and passing it to strtod functions. This approach has problems discussed in bug 16961 and bug 16962: the stack usage is unbounded, and it gives incorrect results in certain cases where the argument is not a valid n-char-sequence. The natural fix for both issues is to refactor the NaN payload parsing out of strtod into a separate function that the nan* functions can call directly, so that no temporary string needs constructing on the stack at all. This patch does that refactoring in preparation for fixing those bugs (but without actually using the new functions from nan* - which will also require exporting them from libc at version GLIBC_PRIVATE). This patch is not intended to change any user-visible behavior, so no tests are added (fixes for the above bugs will of course add tests for them). This patch builds on my recent fixes for strtol and strtod issues in Turkish locales. Given those fixes, the parsing of NaN payloads is locale-independent; thus, the new functions do not need to take a locale_t argument. Tested for x86_64, x86, mips64 and powerpc. * stdlib/strtod_nan.c: New file. * stdlib/strtod_nan_double.h: Likewise. * stdlib/strtod_nan_float.h: Likewise. * stdlib/strtod_nan_main.c: Likewise. * stdlib/strtod_nan_narrow.h: Likewise. * stdlib/strtod_nan_wide.h: Likewise. * stdlib/strtof_nan.c: Likewise. * stdlib/strtold_nan.c: Likewise. * sysdeps/ieee754/ldbl-128/strtod_nan_ldouble.h: Likewise. * sysdeps/ieee754/ldbl-128ibm/strtod_nan_ldouble.h: Likewise. * sysdeps/ieee754/ldbl-96/strtod_nan_ldouble.h: Likewise. * wcsmbs/wcstod_nan.c: Likewise. * wcsmbs/wcstof_nan.c: Likewise. * wcsmbs/wcstold_nan.c: Likewise. * stdlib/Makefile (routines): Add strtof_nan, strtod_nan and strtold_nan. * wcsmbs/Makefile (routines): Add wcstod_nan, wcstold_nan and wcstof_nan. * include/stdlib.h (__strtof_nan): Declare and use libc_hidden_proto. (__strtod_nan): Likewise. (__strtold_nan): Likewise. (__wcstof_nan): Likewise. (__wcstod_nan): Likewise. (__wcstold_nan): Likewise. * include/wchar.h (____wcstoull_l_internal): Declare. * stdlib/strtod_l.c: Do not include <ieee754.h>. (____strtoull_l_internal): Remove declaration. (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. (STRTOULL): Likewise. (____STRTOF_INTERNAL): Use STRTOF_NAN to parse NaN payload. * stdlib/strtof_l.c (____strtoull_l_internal): Remove declaration. (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * sysdeps/ieee754/ldbl-128/strtold_l.c (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * sysdeps/ieee754/ldbl-128ibm/strtold_l.c (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * sysdeps/ieee754/ldbl-64-128/strtold_l.c (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * sysdeps/ieee754/ldbl-96/strtold_l.c (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * wcsmbs/wcstod_l.c (____wcstoull_l_internal): Remove declaration. * wcsmbs/wcstof_l.c (____wcstoull_l_internal): Likewise. * wcsmbs/wcstold_l.c (____wcstoull_l_internal): Likewise. |
||
|---|---|---|
| .. | ||
| bits | ||
| btowc.c | ||
| c16rtomb.c | ||
| Depend | ||
| isoc99_fwscanf.c | ||
| isoc99_swscanf.c | ||
| isoc99_vfwscanf.c | ||
| isoc99_vswscanf.c | ||
| isoc99_vwscanf.c | ||
| isoc99_wscanf.c | ||
| Makefile | ||
| mbrlen.c | ||
| mbrtoc16.c | ||
| mbrtowc.c | ||
| mbsinit.c | ||
| mbsnrtowcs.c | ||
| mbsrtowcs_l.c | ||
| mbsrtowcs.c | ||
| test-wcpcpy.c | ||
| test-wcpncpy.c | ||
| test-wcscat.c | ||
| test-wcschr.c | ||
| test-wcschrnul.c | ||
| test-wcscmp.c | ||
| test-wcscpy.c | ||
| test-wcscspn.c | ||
| test-wcslen.c | ||
| test-wcsncat.c | ||
| test-wcsncmp.c | ||
| test-wcsncpy.c | ||
| test-wcsnlen.c | ||
| test-wcspbrk.c | ||
| test-wcsrchr.c | ||
| test-wcsspn.c | ||
| test-wmemchr.c | ||
| test-wmemcmp.c | ||
| test-wmemset.c | ||
| tst-btowc.c | ||
| tst-c16c32-1.c | ||
| tst-mbrtowc2.c | ||
| tst-mbrtowc.c | ||
| tst-mbsrtowcs.c | ||
| tst-wchar-h.c | ||
| tst-wcpncpy.c | ||
| tst-wcrtomb.c | ||
| tst-wcsnlen.c | ||
| tst-wcstod-nan-locale.c | ||
| tst-wcstof.c | ||
| tst-wcstol-locale.c | ||
| uchar.h | ||
| Versions | ||
| wchar.h | ||
| wcpcpy.c | ||
| wcpncpy.c | ||
| wcrtomb.c | ||
| wcsatcliff.c | ||
| wcscasecmp_l.c | ||
| wcscasecmp.c | ||
| wcscat.c | ||
| wcschr.c | ||
| wcschrnul.c | ||
| wcscmp.c | ||
| wcscoll_l.c | ||
| wcscoll.c | ||
| wcscpy.c | ||
| wcscspn.c | ||
| wcsdup.c | ||
| wcslen.c | ||
| wcsmbs-tst1.c | ||
| wcsmbsload.c | ||
| wcsmbsload.h | ||
| wcsncase_l.c | ||
| wcsncase.c | ||
| wcsncat.c | ||
| wcsncmp.c | ||
| wcsncpy.c | ||
| wcsnlen.c | ||
| wcsnrtombs.c | ||
| wcspbrk.c | ||
| wcsrchr.c | ||
| wcsrtombs.c | ||
| wcsspn.c | ||
| wcsstr.c | ||
| wcstod_l.c | ||
| wcstod_nan.c | ||
| wcstod.c | ||
| wcstof_l.c | ||
| wcstof_nan.c | ||
| wcstof.c | ||
| wcstok.c | ||
| wcstol_l.c | ||
| wcstol.c | ||
| wcstold_l.c | ||
| wcstold_nan.c | ||
| wcstold.c | ||
| wcstoll_l.c | ||
| wcstoll.c | ||
| wcstoul_l.c | ||
| wcstoul.c | ||
| wcstoull_l.c | ||
| wcstoull.c | ||
| wcswidth.c | ||
| wcsxfrm_l.c | ||
| wcsxfrm.c | ||
| wctob.c | ||
| wcwidth.c | ||
| wcwidth.h | ||
| wmemchr.c | ||
| wmemcmp.c | ||
| wmemcpy.c | ||
| wmemmove.c | ||
| wmempcpy.c | ||
| wmemset.c | ||