Joseph Myers e02cabecf0 Refactor strtod parsing of NaN payloads. ... The nan* functions handle their string argument by constructing a NAN(...) string on the stack as a VLA and passing it to strtod functions. This approach has problems discussed in bug 16961 and bug 16962: the stack usage is unbounded, and it gives incorrect results in certain cases where the argument is not a valid n-char-sequence. The natural fix for both issues is to refactor the NaN payload parsing out of strtod into a separate function that the nan* functions can call directly, so that no temporary string needs constructing on the stack at all. This patch does that refactoring in preparation for fixing those bugs (but without actually using the new functions from nan* - which will also require exporting them from libc at version GLIBC_PRIVATE). This patch is not intended to change any user-visible behavior, so no tests are added (fixes for the above bugs will of course add tests for them). This patch builds on my recent fixes for strtol and strtod issues in Turkish locales. Given those fixes, the parsing of NaN payloads is locale-independent; thus, the new functions do not need to take a locale_t argument. Tested for x86_64, x86, mips64 and powerpc. * stdlib/strtod_nan.c: New file. * stdlib/strtod_nan_double.h: Likewise. * stdlib/strtod_nan_float.h: Likewise. * stdlib/strtod_nan_main.c: Likewise. * stdlib/strtod_nan_narrow.h: Likewise. * stdlib/strtod_nan_wide.h: Likewise. * stdlib/strtof_nan.c: Likewise. * stdlib/strtold_nan.c: Likewise. * sysdeps/ieee754/ldbl-128/strtod_nan_ldouble.h: Likewise. * sysdeps/ieee754/ldbl-128ibm/strtod_nan_ldouble.h: Likewise. * sysdeps/ieee754/ldbl-96/strtod_nan_ldouble.h: Likewise. * wcsmbs/wcstod_nan.c: Likewise. * wcsmbs/wcstof_nan.c: Likewise. * wcsmbs/wcstold_nan.c: Likewise. * stdlib/Makefile (routines): Add strtof_nan, strtod_nan and strtold_nan. * wcsmbs/Makefile (routines): Add wcstod_nan, wcstold_nan and wcstof_nan. * include/stdlib.h (__strtof_nan): Declare and use libc_hidden_proto. (__strtod_nan): Likewise. (__strtold_nan): Likewise. (__wcstof_nan): Likewise. (__wcstod_nan): Likewise. (__wcstold_nan): Likewise. * include/wchar.h (____wcstoull_l_internal): Declare. * stdlib/strtod_l.c: Do not include <ieee754.h>. (____strtoull_l_internal): Remove declaration. (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. (STRTOULL): Likewise. (____STRTOF_INTERNAL): Use STRTOF_NAN to parse NaN payload. * stdlib/strtof_l.c (____strtoull_l_internal): Remove declaration. (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * sysdeps/ieee754/ldbl-128/strtold_l.c (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * sysdeps/ieee754/ldbl-128ibm/strtold_l.c (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * sysdeps/ieee754/ldbl-64-128/strtold_l.c (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * sysdeps/ieee754/ldbl-96/strtold_l.c (STRTOF_NAN): Define macro. (SET_MANTISSA): Remove macro. * wcsmbs/wcstod_l.c (____wcstoull_l_internal): Remove declaration. * wcsmbs/wcstof_l.c (____wcstoull_l_internal): Likewise. * wcsmbs/wcstold_l.c (____wcstoull_l_internal): Likewise.		2015-11-24 22:24:52 +00:00
..
arpa
bits
gnu
net
netinet
programs
protocols
rpc	Rename bits/libc-tsd.h to libc-tsd.h (bug 14912).	2015-09-03 20:33:46 +00:00
rpcsvc
sys	Mark ld.so internel __fxstatat64 hidden	2015-10-19 12:01:48 -07:00
aio.h
aliases.h
alloca.h
argp.h
argz.h
assert.h
atomic.h	Move bits/atomic.h to atomic-machine.h (bug 14912).	2015-09-11 20:00:19 +00:00
byteswap.h
caller.h
complex.h
cpio.h
ctype.h	Rename bits/libc-tsd.h to libc-tsd.h (bug 14912).	2015-09-03 20:33:46 +00:00
des.h
dirent.h	Mark internal dirent functions hidden	2015-10-15 14:15:41 -07:00
dlfcn.h	Mark _dl_catch_error hidden	2015-10-15 14:13:50 -07:00
elf.h
endian.h
envz.h
err.h
errno.h
error.h
execinfo.h
fcntl.h	Mark internal fcntl functions hidden	2015-10-15 14:16:41 -07:00
features.h	Fix features.h for -Wundef (bug 19212).	2015-11-05 21:19:37 +00:00
fenv.h	Mark fegetround pure (bug 16296).	2015-09-15 20:36:50 +00:00
fmtmsg.h
fnmatch.h
fpu_control.h
ftw.h
gconv.h
getopt_int.h
getopt.h
glob.h
gmp.h
gnu-versions.h
grp.h
gshadow.h
iconv.h
ifaddrs.h
ifunc-impl-list.h
inline-hashtab.h
langinfo.h
libc-internal.h	Use max_align_t from <stddef.h>.	2015-10-29 12:46:22 +00:00
libc-symbols.h	Remove .weak, .weakext configure tests.	2015-10-19 12:06:00 +00:00
libgen.h
libintl.h
libio.h	Rename bits/stdio-lock.h to stdio-lock.h (bug 14912).	2015-09-04 16:21:14 +00:00
limits.h
link.h	Move bits/libc-lock.h and bits/libc-lockP.h out of bits/ (bug 14912).	2015-09-08 21:11:03 +00:00
list.h
locale.h
malloc.h
math.h	Fix lgamma setting signgam for ISO C (bug 15421).	2015-11-20 22:49:59 +00:00
mcheck.h
memory.h
mntent.h
monetary.h
mqueue.h
netdb.h
netgroup.h
nl_types.h
nss.h	Harden putpwent, putgrent, putspent, putspent against injection [BZ #18724]	2015-10-02 11:34:13 +02:00
nsswitch.h
obstack.h
poll.h
printf.h
pthread.h
pty.h
pwd.h	Harden putpwent, putgrent, putspent, putspent against injection [BZ #18724]	2015-10-02 11:34:13 +02:00
regex.h
resolv.h
rounding-mode.h
sched.h
scratch_buffer.h	Use max_align_t from <stddef.h>.	2015-10-29 12:46:22 +00:00
search.h
set-hooks.h
setjmp.h	Mark internal setjmp functions hidden	2015-10-15 14:22:25 -07:00
sgtty.h
shadow.h
shlib-compat.h
signal.h	Mark ld.so internel sigaction functions hidden	2015-10-15 14:23:31 -07:00
spawn.h
stab.h
stackinfo.h
stap-probe.h	include/stap-probe.h: Fix formatting.	2015-10-14 11:35:31 -04:00
stdc-predef.h
stdio_ext.h
stdio.h	Provide __libc_fatal for rtld.	2015-07-09 15:32:32 -07:00
stdlib.h	Refactor strtod parsing of NaN payloads.	2015-11-24 22:24:52 +00:00
string.h	Mark ld.so internel string functions hidden	2015-10-15 14:26:00 -07:00
strings.h
stropts.h
stubs-prologue.h
syscall.h
sysexits.h
syslog.h
tar.h
termios.h
tgmath.h
time.h
ttyent.h
uchar.h
ucontext.h
ulimit.h
unistd.h	Assume that SOCK_CLOEXEC is available and works	2015-10-17 12:02:37 +02:00
utime.h
utmp.h
values.h
wchar.h	Refactor strtod parsing of NaN payloads.	2015-11-24 22:24:52 +00:00
wctype.h
wordexp.h
xlocale.h