glibc/resolv
Joseph Myers a3708cf6b0 Avoid use of atoi in some places in libc
This patch is split out of
<https://sourceware.org/pipermail/libc-alpha/2022-December/144122.html>.

atoi has undefined behavior on out-of-range input, which makes it
problematic to use anywhere in glibc that might be processing input
out-of-range for atoi but not specified to produce undefined behavior
for the function calling atoi.  Change some uses of atoi to call
strtol instead; this avoids the undefined behavior, though there is no
guarantee that the overflow handling of strtol is really right in
those places either.  This also serves to avoid localplt test failures
given an installed header redirection for strtol (which means that the
call from the inline atoi implementation doesn't end up at a hidden
alias from libc_hidden_proto).

Certainly, the use of atoi is questionable in argp-help.c (shared with
gnulib, so shouldn't depend on glibc implementation details, and
processing user-provided input), and maybe also in argp-parse.c (I'm
not sure what that code in argp-parse.c is meant to be used for).  I
also changed inet/rexec.c and resolv/res_init.c similarly to use
strtol to avoid such localplt failures, although given those files (in
those versions) are only used in glibc it's not problematic for them
to rely on the specific behavior of glibc's atoi on out-of-range input
(in the absence of compiler optimizations based on the undefined
behavior) in the same way it's problematic for gnulib code to do so.

There may be other uses of atoi (or atol or atoll), in any of glibc's
installed code, for which it would also be appropriate to avoid the
undefined behavior on out-of-range input; this patch only fixes the
specific cases needed to avoid localplt failures.

Tested for x86_64.
2022-12-19 14:45:44 +00:00
..
arpa
bits/types
nss_dns nss_dns: Rewrite _nss_dns_gethostbyname4_r using current interfaces 2022-08-30 10:02:49 +02:00
sys
tst-leaks2.root/etc
base64.c
compat-gethnamaddr.c
compat-hooks.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
Depend
dn_comp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
dn_expand.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
dn_skipname.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
gai_cancel.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
gai_error.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
gai_misc.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
gai_misc.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
gai_notify.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
gai_sigqueue.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
gai_suspend.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
getaddrinfo_a.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
herror.c
inet_addr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
inet_net_ntop.c
inet_net_pton.c
inet_neta.c
inet_ntop.c
inet_pton.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
libanl-compat.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
Makefile configure: Use -Wno-ignored-attributes if compiler warns about multiple aliases 2022-11-01 09:51:06 -03:00
netdb.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
ns_date.c
ns_makecanon.c
ns_name_compress.c
ns_name_length_uncompressed.c resolv: Add internal __ns_name_length_uncompressed function 2022-08-30 10:02:49 +02:00
ns_name_ntop.c
ns_name_pack.c
ns_name_pton.c
ns_name_skip.c
ns_name_uncompress.c
ns_name_unpack.c
ns_name.c
ns_netint.c
ns_parse.c
ns_print.c
ns_rr_cursor_init.c resolv: Add DNS packet parsing helpers geared towards wire format 2022-08-30 10:02:49 +02:00
ns_rr_cursor_next.c resolv: Add DNS packet parsing helpers geared towards wire format 2022-08-30 10:02:49 +02:00
ns_samebinaryname.c resolv: Add the __ns_samebinaryname function 2022-08-30 10:02:49 +02:00
ns_samedomain.c
ns_samename.c
ns_ttl.c
nsap_addr.c
nss_dns_functions.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
README nss_dns: Remove remnants of IPv6 address mapping 2022-08-30 10:02:49 +02:00
res_context_hostalias.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_data.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_debug.c resolv: Implement no-aaaa stub resolver option 2022-06-24 18:18:44 +02:00
res_enable_icmp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_get_nsaddr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_hconf.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_hconf.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_hostalias.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_init.c Avoid use of atoi in some places in libc 2022-12-19 14:45:44 +00:00
res_isourserver.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_libc.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_mkquery.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_nameinquery.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_queriesmatch.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_query.c resolv: Implement no-aaaa stub resolver option 2022-06-24 18:18:44 +02:00
res_randomid.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res_send.c resolv: Implement no-aaaa stub resolver option 2022-06-24 18:18:44 +02:00
res-close.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res-name-checking.c resolv: Add internal __res_binary_hnok function 2022-08-30 10:02:49 +02:00
res-noaaaa.c resolv: Implement no-aaaa stub resolver option 2022-06-24 18:18:44 +02:00
res-putget.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
res-state.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
resolv_conf.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
resolv_conf.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
resolv_context.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
resolv_context.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
resolv-deprecated.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
resolv-internal.h resolv: Implement no-aaaa stub resolver option 2022-06-24 18:18:44 +02:00
resolv.h resolv: Implement no-aaaa stub resolver option 2022-06-24 18:18:44 +02:00
tst-aton.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-bug18665-tcp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-bug18665.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-inet_aton_exact.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-inet_ntop.c
tst-inet_pton.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-leaks2.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-leaks.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-no-libidn2.c
tst-ns_name_compress.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-ns_name_length_uncompressed.c resolv: Add internal __ns_name_length_uncompressed function 2022-08-30 10:02:49 +02:00
tst-ns_name_pton.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-ns_name.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-ns_name.data Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-ns_rr_cursor.c resolv: Add DNS packet parsing helpers geared towards wire format 2022-08-30 10:02:49 +02:00
tst-ns_samebinaryname.c resolv: Add the __ns_samebinaryname function 2022-08-30 10:02:49 +02:00
tst-p_secstodate.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-res_hconf_reorder.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-res_hnok.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-ai_idn-common.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-ai_idn-latin1.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-ai_idn-nolibidn2.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-ai_idn.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-aliases.c resolv: Add tst-resolv-aliases 2022-08-30 10:02:49 +02:00
tst-resolv-basic.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-binary.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-byaddr.c resolv: Add tst-resolv-byaddr for testing reverse lookup 2022-08-30 10:02:49 +02:00
tst-resolv-canonname.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-edns.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-invalid-cname.c resolv: Fix building tst-resolv-invalid-cname for earlier C standards 2022-08-30 14:04:12 +02:00
tst-resolv-maybe_insert_sig.h resolv: Add tst-resolv-byaddr for testing reverse lookup 2022-08-30 10:02:49 +02:00
tst-resolv-network.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-noaaaa.c resolv/tst-resolv-noaaaa: Support building for older C standards 2022-06-24 19:44:42 +02:00
tst-resolv-nondecimal.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-qtypes.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-res_init-multi.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-res_init-skeleton.c resolv: Implement no-aaaa stub resolver option 2022-06-24 18:18:44 +02:00
tst-resolv-res_init-thread.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-res_init.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-res_ninit.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-rotate.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-search.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-threads.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-trailing.c resolv: Initialize loop variable on tst-resolv-trailing 2022-03-31 08:55:48 -03:00
tst-resolv-trustad.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-resolv-txnid-collision.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
Versions

The resolver in the GNU C Library
*********************************

Starting with version 2.2, the resolver in the GNU C Library comes
from BIND 8.  Only a subset of the src/lib/resolv part of libbind is
included here; basically the parts that are needed to provide the
functionality present in the resolver from BIND 4.9.7 that was
included in the previous release of the GNU C Library, augmented by
the parts needed to provide thread-safety.  This means that support
for things as dynamic DNS updates and TSIG keys isn't included.  If
you need those facilities, please take a look at the full BIND
distribution.


Differences
===========

The resolver in the GNU C Library still differs from what's in BIND
8.2.3-T5B:

* The RES_DEBUG option (`options debug' in /etc/resolv.conf) has been
  disabled.

* The resolver in glibc allows underscores in domain names.

* The <resolv.h> header in glibc includes <netinet/in.h> and
  <arpa/nameser.h> to make it self-contained.

* The `res_close' function in glibc only tries to close open files
  referenced through `_res' if the RES_INIT bit is set in
  `_res.options'.  This fixes a potential security bug with programs
  that bogusly call `res_close' without initialising the resolver
  state first.  Note that the thread-safe `res_nclose' still doesn't
  check the RES_INIT bit.  By the way, you're not really supposed to
  call `res_close/res_nclose' directly.

* The resolver in glibc can connect to a nameserver over IPv6.  Just
  specify the IPv6 address in /etc/resolv.conf.  You cannot change the
  address of an IPv6 nameserver dynamically in your program though.


Using the resolver in multi-threaded code
=========================================

The traditional resolver interfaces `res_query', `res_search',
`res_mkquery', `res_send' and `res_init', used a static (global)
resolver state stored in the `_res' structure.  Therefore, these
interfaces are not thread-safe.  Therefore, BIND 8.2 introduced a set
of "new" interfaces `res_nquery', `res_nsearch', `res_nmkquery',
`res_nsend' and `res_ninit' that take a `res_state' as their first
argument, so you can use a per-thread resolver state.  In glibc, when
you link with -lpthread, such a per-thread resolver state is already
present.  It can be accessed using `_res', which has been redefined as
a macro, in a similar way to what has been done for the `errno' and
`h_errno' variables.  This per-thread resolver state is also used for
the `gethostby*' family of functions, which means that for example
`gethostbyname_r' is now fully thread-safe and re-entrant.  The
traditional resolver interfaces however, continue to use a single
resolver state and are therefore still thread-unsafe.  The resolver
state is the same resolver state that is used for the initial ("main")
thread.

This has the following consequences for existing binaries and source
code:

* Single-threaded programs will continue to work.  There should be no
  user-visible changes when you recompile them.

* Multi-threaded programs that use the traditional resolver interfaces
  in the "main" thread should continue to work, except that they no
  longer see any changes in the global resolver state caused by calls
  to, for example, `gethostbyname' in other threads.  Again there
  should be no user-visible changes when you recompile these programs.

* Multi-threaded programs that use the traditional resolver interfaces
  in more than one thread should be just as buggy as before (there are
  no problems if you use proper locking of course).  If you recompile
  these programs, manipulating the _res structure in threads other
  than the "main" thread will seem to have no effect though.

* In Multi-threaded that manipulate the _res structure, calls to
  functions like `gethostbyname' in threads other than the "main"
  thread won't be influenced by the those changes anymore.

We recommend to use the new thread-safe interfaces in new code, since
the traditional interfaces have been deprecated by the BIND folks.
For compatibility with other (older) systems you might want to
continue to use those interfaces though.


Using the resolver in C++ code
==============================

There resolver contains some hooks which will allow the user to
install some callback functions that make it possible to filter DNS
requests and responses.  Although we do not encourage you to make use
of this facility at all, C++ developers should realise that it isn't
safe to throw exceptions from such callback functions.


Source code
===========

The following files come from the BIND distribution (currently version
8.2.3-T5B):

src/include/
  arpa/nameser.h
  arpa/nameser_compat.h
  resolv.h

src/lib/resolv/
  herror.c
  res_comp.c
  res_data.c
  res_debug.c
  res_init.c
  res_mkquery.c
  res_query.c
  res_send.c

src/lib/nameser/
  ns_name.c
  ns_netint.c
  ns_parse.c
  ns_print.c
  ns_samedomain.c
  ns_ttl.c

src/lib/inet/
  inet_addr.c
  inet_net_ntop.c
  inet_net_pton.c
  inet_neta.c
  inet_ntop.c
  inet_pton.c
  nsap_addr.c

src/lib/isc/
  base64.c

Some of these files have been optimised a bit, and adaptations have
been made to make them fit in with the rest of glibc.

res_libc.c is home-brewn, although parts of it are taken from res_data.c.

res_hconf.c and res_hconf.h were contributed by David Mosberger, and
do not come from BIND.