mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-12-09 04:11:27 +08:00
Code Issues Packages Projects Releases Wiki Activity
65f6f938cd
glibc/sysdeps/posix
History
Eric Rannaud 65f6f938cd linux: open and openat ignore 'mode' with O_TMPFILE in flags 
Both open and openat load their last argument 'mode' lazily, using
va_arg() only if O_CREAT is found in oflag. This is wrong, mode is also
necessary if O_TMPFILE is in oflag.

By chance on x86_64, the problem wasn't evident when using O_TMPFILE
with open, as the 3rd argument of open, even when not loaded with
va_arg, is left untouched in RDX, where the syscall expects it.

However, openat was not so lucky, and O_TMPFILE couldn't be used: mode
is the 4th argument, in RCX, but the syscall expects its 4th argument in
a different register than the glibc wrapper, in R10.

Introduce a macro __OPEN_NEEDS_MODE (oflag) to test if either O_CREAT or
O_TMPFILE is set in oflag.

Tested on Linux x86_64.

	[BZ #17523]
	* io/fcntl.h (__OPEN_NEEDS_MODE): New macro.
	* io/bits/fcntl2.h (open): Use it.
	(openat): Likewise.
	* io/open.c (__libc_open): Likewise.
	* io/open64.c (__libc_open64): Likewise.
	* io/open64_2.c (__open64_2): Likewise.
	* io/open_2.c (__open_2): Likewise.
	* io/openat.c (__openat): Likewise.
	* io/openat64.c (__openat64): Likewise.
	* io/openat64_2.c (__openat64_2): Likewise.
	* io/openat_2.c (__openat_2): Likewise.
	* sysdeps/mach/hurd/open.c (__libc_open): Likewise.
	* sysdeps/mach/hurd/openat.c (__openat): Likewise.
	* sysdeps/posix/open64.c (__libc_open64): Likewise.
	* sysdeps/unix/sysv/linux/dl-openat64.c (openat64): Likewise.
	* sysdeps/unix/sysv/linux/generic/open.c (__libc_open): Likewise.
	(__open_nocancel): Likewise.
	* sysdeps/unix/sysv/linux/generic/open64.c (__libc_open64): Likewise.
	* sysdeps/unix/sysv/linux/open64.c (__libc_open64): Likewise.
	* sysdeps/unix/sysv/linux/openat.c (__OPENAT): Likewise.
2015-02-24 13:19:22 +05:30
..
alarm.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
clock_getres.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
clock.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
closedir.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
ctermid.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
cuserid.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
dirfd.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
dirstream.h Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
dup2.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
dup.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
euidaccess.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
fdopendir.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
flock.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
fpathconf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
gai_strerror-strs.h
gai_strerror.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
getaddrinfo.c Fix qsort_r namespace (bug 17571). 2014-11-12 22:33:41 +00:00
getcwd.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
getdtsz.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
gethostname.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
getpagesize.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
gettimeofday.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
isatty.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
isfdtype.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
killpg.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
libc_fatal.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
Makefile NPTL: Refactor named semaphore code to use shm-directory.h 2014-12-12 15:01:30 -08:00
mkfifo.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
mkfifoat.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
nice.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
open64.c linux: open and openat ignore 'mode' with O_TMPFILE in flags 2015-02-24 13:19:22 +05:30
opendir.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
pathconf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
pause.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
posix_fallocate64.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
posix_fallocate.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
pread64.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
pread.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
preadv64.c
preadv.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
profil.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
pwrite64.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
pwrite.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
pwritev64.c
pwritev.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
raise.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
readdir_r.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
readdir.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
readv.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
remove.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
rename.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
rewinddir.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
seekdir.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
shm_open.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
shm_unlink.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
shm-directory.c Fix shm-directory.h #include. 2015-01-09 16:08:14 -08:00
shm-directory.h Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sigblock.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sigignore.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sigintr.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
signal.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sigpause.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sigset.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sigsetmask.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sigsuspend.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sigwait.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sleep.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
spawni.c Fix posix_spawn getrlimit64 namespace (bug 17991). 2015-02-18 00:26:35 +00:00
sprofil.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sysconf.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
system.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
sysv_signal.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
telldir.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
tempname.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
time.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
timespec_get.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
truncate.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
ttyname_r.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
ttyname.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
ulimit.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
utime.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
utimes.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wait3.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
wait.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
waitid.c Function declaration cleanup 2015-01-06 08:23:58 -08:00
writev.c Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00