mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-11-21 01:12:26 +08:00
Code Issues Packages Projects Releases Wiki Activity
447720b03b
glibc/libio
History
Adhemerval Zanella b65b205fbc libio: Fix fmemopen append mode failure (BZ# 20012) 
The fmemopen implementation does not account the file position correctly in
append mode. The following example shows the failure:

===
int main ()
{
  char buf[10] = "test";
  FILE *fp = fmemopen (buf, 10, "a+");
  fseek (fp, 0, SEEK_SET);

  int gr;
  if ((gr = getc (fp)) != 't' ||
      (gr = getc (fp)) != 'e' ||
      (gr = getc (fp)) != 's' ||
      (gr = getc (fp)) != 't' ||
      (gr = getc (fp)) != EOF)
    {
      printf ("%s: getc failed returned %i\n", __FUNCTION__, gr);
      return 1;
    }

  return 0;
}
===

This is due both how read and write operation update the buffer position,
taking in consideration buffer lenght instead of maximum position defined
by the open mode.  This patch fixes it and also fixes fseek not returning
EINVAL for invalid whence modes.

Tested on x86_64 and i686.

	[BZ #20012]
	* libio/fmemopen.c (fmemopen_read): Use buffer maximum position, not
	length to calculate the buffer to read.
	(fmemopen_write): Set the buffer position based on bytes written.
	(fmemopen_seek): Return EINVAL for invalid whence modes.
2016-04-29 19:25:17 -03:00
..
bits Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__fbufsize.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__flbf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__fpending.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__fpurge.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__freadable.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__freading.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__fsetlocking.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__fwritable.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
__fwriting.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
bug-fopena+.c
bug-fseek.c
bug-ftell.c
bug-memstream1.c
bug-mmap-fflush.c
bug-rewind2.c Fix warnings in fwscanf / rewind tests. 2014-11-26 12:54:39 +00:00
bug-rewind.c Fix warnings in fwscanf / rewind tests. 2014-11-26 12:54:39 +00:00
bug-ungetc2.c
bug-ungetc3.c
bug-ungetc4.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
bug-ungetc.c
bug-ungetwc1.c Fix libio/bug-ungetwc1.c warning. 2014-11-27 16:01:04 +00:00
bug-ungetwc2.c
bug-wfflush.c
bug-wmemstream1.c
bug-wsetpos.c
clearerr_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
clearerr.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
Depend
fcloseall.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
feof_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
feof.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ferror_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ferror.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
filedoalloc.c libio: Clean up _IO_file_doallocate and _IO_wfile_doallocate 2016-03-07 17:05:06 +01:00
fileno.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fileops.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fmemopen.c libio: Fix fmemopen append mode failure (BZ# 20012) 2016-04-29 19:25:17 -03:00
fputc_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fputc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fputwc_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fputwc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
freopen64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
freopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fseek.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fseeko64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fseeko.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ftello64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ftello.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fwide.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fwprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
fwscanf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
genops.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getc_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getchar_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getchar.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getwc_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getwc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getwchar_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
getwchar.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofclose.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofdopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofflush_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofflush.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofgetpos64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofgetpos.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofgets_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofgets.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofgetws_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofgetws.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofopen64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofopncook.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofputs_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofputs.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofputws_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofputws.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofread_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofread.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofsetpos64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofsetpos.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ioftell.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofwide.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofwrite_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iofwrite.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iogetdelim.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iogetline.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iogets.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iogetwline.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iolibio.h Remove use of INTDEF/INTUSE in libio 2012-05-24 23:06:20 +02:00
iopadn.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iopopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ioputs.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ioseekoff.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ioseekpos.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iosetbuffer.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iosetvbuf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ioungetc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
ioungetwc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iovdprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iovsprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iovsscanf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iovswscanf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
iowpadn.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
libc_fatal.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
libio.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
libioP.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
Makefile Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
memstream.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
obprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldfileops.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldfmemopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldiofclose.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldiofdopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldiofgetpos64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldiofgetpos.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldiofopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldiofsetpos64.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldiofsetpos.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldiopopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldpclose.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldstdfiles.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
oldtmpfile.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
pclose.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
peekc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
putc_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
putc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
putchar_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
putchar.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
putwc_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
putwc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
putwchar_u.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
putwchar.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
rewind.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
setbuf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
setlinebuf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
stdfiles.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
stdio.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
stdio.h Fix stdio.h namespace for pre-threads POSIX (bug 20014). 2016-04-28 22:01:04 +00:00
strfile.h Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
strops.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
swprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
swscanf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
test-fmemopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
test-freopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
test-freopen.sh Make shebang interpreter directives consistent 2016-01-07 04:03:21 -05:00
tst_getwc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst_getwc.input
tst_putwc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst_swprintf.c
tst_swscanf.c
tst_wprintf2.c Add dependencies on needed locales in each subdir tests (bug 18969) 2015-10-12 15:18:08 +02:00
tst_wprintf.c
tst_wscanf.c
tst_wscanf.input
tst-atime.c Fix libio/tst-atime not to presume ST_NOATIME exists. 2015-02-06 12:24:16 -08:00
tst-eof.c
tst-ext2.c
tst-ext.c
tst-fgetwc.c
tst-fgetwc.input
tst-fgetws.c
tst-fopenloc2.c
tst-fopenloc.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-fputws.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-freopen.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-fseek.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-ftell-active-handler.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-ftell-append.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-ftell-partial-wide.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-fwrite-error.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-memstream1.c
tst-memstream2.c Adjust timeouts for some tests, to accommodate slow processors, 2015-02-22 01:05:02 -08:00
tst-mmap2-eofsync.c
tst-mmap-eofsync.c
tst-mmap-fflushsync.c
tst-mmap-offend.c
tst-mmap-setvbuf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-popen1.c
tst-setvbuf1.c
tst-sscanf.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-swscanf.c
tst-ungetwc1.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-ungetwc2.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-widetext.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
tst-widetext.input Rename Oriya locale to Odia (bug 15601) 2013-11-20 17:47:41 +05:30
tst-wmemstream1.c
tst-wmemstream2.c
vasprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
Versions libio: fmemopen rewrite to POSIX compliance 2015-07-08 12:07:21 -03:00
vscanf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
vsnprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
vswprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
vwprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
vwscanf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
wfiledoalloc.c libio: Clean up _IO_file_doallocate and _IO_wfile_doallocate 2016-03-07 17:05:06 +01:00
wfileops.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
wgenops.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
wmemstream.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
wprintf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
wscanf.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
wstrops.c Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00