mirror of
git://sourceware.org/git/glibc.git
synced 2025-02-05 12:40:55 +08:00
f5eee5c72b
The implementations of strtol and related functions use locale-specific conversions to upper case before determining whether a character is a valid letter in the argument. This means that in Turkish locales such as tr_TR.UTF-8 and tr_TR.ISO-8859-9, "i" is interpreted as not being a valid number, when if the base passed to strtol is 19 or more it should be interpreted as the number 18. ISO C explicitly says "The letters from a (or A) through z (or Z) are ascribed the values 10 through 35", so clearly intends the standard ASCII letters (otherwise you wouldn't generally have exactly 26 letters to ascribe such values) (whereas white-space must be identified according to the locale). In particular, 'i' and 'I' must be understood to be in that sequence. This patch makes the code do the case conversions and classification in the C locale; the user's locale remains used for whitespace testing (explicitly correct according to ISO C). Note that the way the code worked, the only non-ASCII letter that would previously have been accepted would have been the Turkish 'ı' (dotless 'i'), because the uppercase version of that in Turkish locales is 'I'. This patch means that will no longer be accepted, which seems appropriate. Tested for x86_64 and x86. [BZ #19242] * stdlib/strtol_l.c (ISALPHA): Use _nl_C_locobj_ptr for locale. (TOUPPER): Likewise. * stdlib/tst-strtol-locale-main.c: New file. * stdlib/tst-strtol-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtol-locale. [$(run-built-tests) = yes] (LOCALES): Add tr_TR.ISO-8859-9. [$(run-built-tests) = yes] ($(objpfx)tst-strtol-locale.out): Depend on $(gen-locales). * wcsmbs/tst-wcstol-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstol-locale. [$(run-built-tests) = yes] (LOCALES): Add tr_TR.UTF-8 and tr_TR.ISO-8859-9. [$(run-built-tests) = yes] ($(objpfx)tst-wcstol-locale.out): Depend on $(gen-locales). |
||
|---|---|---|
| .. | ||
| bits | ||
| btowc.c | ||
| c16rtomb.c | ||
| Depend | ||
| isoc99_fwscanf.c | ||
| isoc99_swscanf.c | ||
| isoc99_vfwscanf.c | ||
| isoc99_vswscanf.c | ||
| isoc99_vwscanf.c | ||
| isoc99_wscanf.c | ||
| Makefile | ||
| mbrlen.c | ||
| mbrtoc16.c | ||
| mbrtowc.c | ||
| mbsinit.c | ||
| mbsnrtowcs.c | ||
| mbsrtowcs_l.c | ||
| mbsrtowcs.c | ||
| test-wcpcpy.c | ||
| test-wcpncpy.c | ||
| test-wcscat.c | ||
| test-wcschr.c | ||
| test-wcschrnul.c | ||
| test-wcscmp.c | ||
| test-wcscpy.c | ||
| test-wcscspn.c | ||
| test-wcslen.c | ||
| test-wcsncat.c | ||
| test-wcsncmp.c | ||
| test-wcsncpy.c | ||
| test-wcsnlen.c | ||
| test-wcspbrk.c | ||
| test-wcsrchr.c | ||
| test-wcsspn.c | ||
| test-wmemchr.c | ||
| test-wmemcmp.c | ||
| test-wmemset.c | ||
| tst-btowc.c | ||
| tst-c16c32-1.c | ||
| tst-mbrtowc2.c | ||
| tst-mbrtowc.c | ||
| tst-mbsrtowcs.c | ||
| tst-wchar-h.c | ||
| tst-wcpncpy.c | ||
| tst-wcrtomb.c | ||
| tst-wcsnlen.c | ||
| tst-wcstof.c | ||
| tst-wcstol-locale.c | ||
| uchar.h | ||
| Versions | ||
| wchar.h | ||
| wcpcpy.c | ||
| wcpncpy.c | ||
| wcrtomb.c | ||
| wcsatcliff.c | ||
| wcscasecmp_l.c | ||
| wcscasecmp.c | ||
| wcscat.c | ||
| wcschr.c | ||
| wcschrnul.c | ||
| wcscmp.c | ||
| wcscoll_l.c | ||
| wcscoll.c | ||
| wcscpy.c | ||
| wcscspn.c | ||
| wcsdup.c | ||
| wcslen.c | ||
| wcsmbs-tst1.c | ||
| wcsmbsload.c | ||
| wcsmbsload.h | ||
| wcsncase_l.c | ||
| wcsncase.c | ||
| wcsncat.c | ||
| wcsncmp.c | ||
| wcsncpy.c | ||
| wcsnlen.c | ||
| wcsnrtombs.c | ||
| wcspbrk.c | ||
| wcsrchr.c | ||
| wcsrtombs.c | ||
| wcsspn.c | ||
| wcsstr.c | ||
| wcstod_l.c | ||
| wcstod.c | ||
| wcstof_l.c | ||
| wcstof.c | ||
| wcstok.c | ||
| wcstol_l.c | ||
| wcstol.c | ||
| wcstold_l.c | ||
| wcstold.c | ||
| wcstoll_l.c | ||
| wcstoll.c | ||
| wcstoul_l.c | ||
| wcstoul.c | ||
| wcstoull_l.c | ||
| wcstoull.c | ||
| wcswidth.c | ||
| wcsxfrm_l.c | ||
| wcsxfrm.c | ||
| wctob.c | ||
| wcwidth.c | ||
| wcwidth.h | ||
| wmemchr.c | ||
| wmemcmp.c | ||
| wmemcpy.c | ||
| wmemmove.c | ||
| wmempcpy.c | ||
| wmemset.c | ||