Go to file
Adhemerval Zanella 2149da3683 riscv: Fix alignment-ignorant memcpy implementation
The memcpy optimization (commit 587a1290a1) has a series
of mistakes:

  - The implementation is wrong: the chunk size calculation is wrong
    leading to invalid memory access.

  - It adds ifunc supports as default, so --disable-multi-arch does
    not work as expected for riscv.

  - It mixes Linux files (memcpy ifunc selection which requires the
    vDSO/syscall mechanism)  with generic support (the memcpy
    optimization itself).

  - There is no __libc_ifunc_impl_list, which makes testing only
    check the selected implementation instead of all supported
    by the system.

This patch also simplifies the required bits to enable ifunc: there
is no need to memcopy.h; nor to add Linux-specific files.

The __memcpy_noalignment tail handling now uses a branchless strategy
similar to aarch64 (overlap 32-bits copies for sizes 4..7 and byte
copies for size 1..3).

Checked on riscv64 and riscv32 by explicitly enabling the function
on __libc_ifunc_impl_list on qemu-system.

Changes from v1:
* Implement the memcpy in assembly to correctly handle RISCV
  strict-alignment.
Reviewed-by: Evan Green <evan@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
2024-03-12 14:38:08 -03:00
advisories Update advisory format and introduce some automation 2024-01-30 13:58:57 -05:00
argp Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
assert Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
benchtests benchtests: Add more benchtests for rounding functions. 2024-02-23 08:50:00 -03:00
bits Refer to C23 in place of C2X in glibc 2024-02-01 11:02:01 +00:00
catgets Update copyright dates not handled by scripts/update-copyrights 2024-01-01 10:53:40 -08:00
ChangeLog.old Create ChangeLog.old/ChangeLog.28 2024-01-31 01:34:58 +01:00
conform conform: Reformat Makefile. 2024-02-25 13:38:16 -05:00
csu csu: Reformat Makefile. 2024-02-25 13:38:16 -05:00
ctype ctype: Reformat Makefile. 2024-02-25 13:38:16 -05:00
debug string: Add hidden builtin definition for __strcpy_chk. 2024-02-06 09:17:04 +01:00
dirent dirent: Reformat Makefile. 2024-02-25 13:38:16 -05:00
dlfcn dlfcn: Reformat Makefile. 2024-02-25 13:38:16 -05:00
elf rtld: Add glibc.rtld.enable_secure tunable. 2024-02-29 19:55:58 +00:00
gmon gmon: Reformat Makefile. 2024-02-25 13:38:16 -05:00
gnulib Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
hesiod hesiod: Reformat Makefile. 2024-02-25 13:38:16 -05:00
htl htl/tests: Reformat Makefile. 2024-02-25 13:38:16 -05:00
hurd hurd: Reformat Makefile. 2024-02-25 13:38:16 -05:00
iconv Update copyright dates not handled by scripts/update-copyrights 2024-01-01 10:53:40 -08:00
iconvdata Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
include riscv: Enable multi-arg ifunc resolvers 2024-03-01 07:14:59 -08:00
inet Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
intl Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
io cdefs: Drop access attribute for _FORTIFY_SOURCE=3 (BZ #31383) 2024-02-28 08:35:10 -05:00
libio libio: Improve fortify with clang 2024-02-27 10:52:58 -03:00
locale duplocale: protect use of global locale (bug 23970) 2024-03-11 09:52:59 +01:00
localedata Update SHARED-FILES and license for Unicode 15.1.0. 2024-02-27 08:27:14 -05:00
login Update copyright dates not handled by scripts/update-copyrights 2024-01-01 10:53:40 -08:00
mach mach: Drop some unnecessary vm_param.h includes 2024-01-03 21:59:54 +01:00
malloc Make __getrandom_nocancel set errno and add a _nostatus version 2024-01-12 14:23:11 +01:00
manual manual/tunables - Add entry for enable_secure tunable. 2024-03-01 17:43:03 +00:00
math treewide: python-scripts: use is None for none-equality 2024-02-23 08:50:00 -03:00
mathvec Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
misc cdefs: Drop access attribute for _FORTIFY_SOURCE=3 (BZ #31383) 2024-02-28 08:35:10 -05:00
nis Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
nptl treewide: python-scripts: use is None for none-equality 2024-02-23 08:50:00 -03:00
nptl_db Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
nscd Update copyright dates not handled by scripts/update-copyrights 2024-01-01 10:53:40 -08:00
nss getaddrinfo: translate ENOMEM to EAI_MEMORY (bug 31163) 2024-01-02 11:10:42 +01:00
po po: Update translations 2024-01-31 01:10:02 +01:00
posix unistd: Improve fortify with clang 2024-02-27 10:52:58 -03:00
resolv Refer to C23 in place of C2X in glibc 2024-02-01 11:02:01 +00:00
resource Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
rt debug: Improve mqueue.h fortify warnings with clang 2024-02-27 10:52:59 -03:00
scripts build-many-glibcs.py: Add s390 --disable-multi-arch / multi-arch configurations. 2024-02-21 08:52:36 +01:00
setjmp Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
signal linux/sigsetops: fix type confusion (bug 31468) 2024-03-12 10:00:22 +01:00
socket socket: Improve fortify with clang 2024-02-27 10:52:59 -03:00
soft-fp soft-fp: Add brain format support 2024-02-01 19:06:54 +01:00
stdio-common Rename c2x / gnu2x tests to c23 / gnu23 2024-02-01 17:55:57 +00:00
stdlib stdlib: Improve fortify with clang 2024-02-27 10:52:58 -03:00
string string: Improve fortify with clang 2024-02-27 10:52:58 -03:00
sunrpc Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
support tests: gracefully handle AppArmor userns containment 2024-02-23 08:50:00 -03:00
sysdeps riscv: Fix alignment-ignorant memcpy implementation 2024-03-12 14:38:08 -03:00
sysvipc Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
termios Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
time Refer to C23 in place of C2X in glibc 2024-02-01 11:02:01 +00:00
timezone Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
wcsmbs wcsmbs: Improve fortify with clang 2024-02-27 10:52:59 -03:00
wctype Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
.clang-format Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
.gitattributes
.gitignore
abi-tags
aclocal.m4 configure: Use autoconf 2.71 2023-07-17 10:08:10 -04:00
config.h.in Use proc_getchildren_rusage when available in getrusage and times. 2024-02-17 21:14:39 +01:00
config.make.in crypt: Remove libcrypt support 2023-10-30 13:03:59 -03:00
configure Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
configure.ac crypt: Remove libcrypt support 2023-10-30 13:03:59 -03:00
CONTRIBUTED-BY crypt: Remove libcrypt support 2023-10-30 13:03:59 -03:00
COPYING
COPYING.LIB
extra-lib.mk
gen-locales.mk
INSTALL INSTALL, install.texi: minor updates, regenerate 2024-01-31 00:13:43 +01:00
libc-abis
libof-iterator.mk
LICENSES Relicense IBM portions of resolv/base64.c resolv/res_debug.c. 2024-01-26 13:33:36 -05:00
MAINTAINERS
Makeconfig Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
Makefile Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
Makefile.help Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
Makefile.in
Makerules Support compiling .S files with additional options 2024-02-25 09:22:40 -08:00
NEWS NEWS: Move enable_secure_tunable from 2.39 to 2.40. 2024-03-01 17:37:31 +00:00
o-iterator.mk
README Remove ia64-linux-gnu 2024-01-08 17:09:36 -03:00
Rules Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
SECURITY.md Adapt the security policy for the security page 2023-12-05 09:15:10 -05:00
SHARED-FILES Update SHARED-FILES and license for Unicode 15.1.0. 2024-02-27 08:27:14 -05:00
shlib-versions crypt: Remove libcrypt support 2023-10-30 13:03:59 -03:00
test-skeleton.c Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
version.h Open master branch for glibc 2.40 development 2024-01-31 02:07:20 +01:00

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu and x86_64-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arc*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	loongarch64-*-linux-gnu Hardware floating point, LE only.
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	or1k-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv32-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see https://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at https://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see https://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.