mirror of
git://sourceware.org/git/glibc.git
synced 2025-02-05 12:40:55 +08:00
The array lr->buf contains characters, which can be signed. A 0xff byte in the input could be incorrectly reported as EOF. More importantly, get_string in linereader.c converts a signed input byte to a Unicode code point using ADDWC ((uint32_t) ch), under the assumption that this decodes the ISO-8859-1 input encoding. If char is signed, this does not give the correct result. This means that ISO-8859-1 input files for localedef are not actually supported, contrary to the comment in get_string. This is a happy accident because we can therefore change the file encoding to UTF-8 without impacting backwards compatibility. While at it, remove the \32 check for MS-DOS end-of-file character (^Z). Reviewed-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com> |
||
---|---|---|
.. | ||
3level.h | ||
charmap-dir.c | ||
charmap-dir.h | ||
charmap-kw.gperf | ||
charmap-kw.h | ||
charmap.c | ||
charmap.h | ||
config.h | ||
ld-address.c | ||
ld-collate.c | ||
ld-ctype.c | ||
ld-identification.c | ||
ld-measurement.c | ||
ld-messages.c | ||
ld-monetary.c | ||
ld-name.c | ||
ld-numeric.c | ||
ld-paper.c | ||
ld-telephone.c | ||
ld-time.c | ||
linereader.c | ||
linereader.h | ||
locale-spec.c | ||
locale.c | ||
localedef.c | ||
localedef.h | ||
locarchive.c | ||
locfile-kw.gperf | ||
locfile-kw.h | ||
locfile-token.h | ||
locfile.c | ||
locfile.h | ||
record-status.c | ||
record-status.h | ||
repertoire.c | ||
repertoire.h | ||
simple-hash.c | ||
simple-hash.h | ||
xasprintf.c | ||
xmalloc.c | ||
xstrdup.c |