Go to file
Chung-Lin Tang 15a0c5730d elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645)
This second patch contains the actual implementation of a new sorting algorithm
for shared objects in the dynamic loader, which solves the slow behavior that
the current "old" algorithm falls into when the DSO set contains circular
dependencies.

The new algorithm implemented here is simply depth-first search (DFS) to obtain
the Reverse-Post Order (RPO) sequence, a topological sort. A new l_visited:1
bitfield is added to struct link_map to more elegantly facilitate such a search.

The DFS algorithm is applied to the input maps[nmap-1] backwards towards
maps[0]. This has the effect of a more "shallow" recursion depth in general
since the input is in BFS. Also, when combined with the natural order of
processing l_initfini[] at each node, this creates a resulting output sorting
closer to the intuitive "left-to-right" order in most cases.

Another notable implementation adjustment related to this _dl_sort_maps change
is the removing of two char arrays 'used' and 'done' in _dl_close_worker to
represent two per-map attributes. This has been changed to simply use two new
bit-fields l_map_used:1, l_map_done:1 added to struct link_map. This also allows
discarding the clunky 'used' array sorting that _dl_sort_maps had to sometimes
do along the way.

Tunable support for switching between different sorting algorithms at runtime is
also added. A new tunable 'glibc.rtld.dynamic_sort' with current valid values 1
(old algorithm) and 2 (new DFS algorithm) has been added. At time of commit
of this patch, the default setting is 1 (old algorithm).

Signed-off-by: Chung-Lin Tang  <cltang@codesourcery.com>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
2021-10-21 11:23:53 -03:00
argp Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
assert
benchtests benchtests: Add medium cases and increase iters in bench-memset.c 2021-10-08 15:13:06 -05:00
bits Add missing braces to bsearch inline implementation [BZ #28400] 2021-09-30 20:40:12 +02:00
catgets Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
ChangeLog.old Update ChangeLog.old/ChangeLog.23. 2021-08-01 21:33:43 -04:00
conform Use $(pie-default) with conformtest 2021-09-17 19:24:14 +00:00
crypt Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
csu Extend struct r_debug to support multiple namespaces [BZ #15971] 2021-09-19 13:51:35 -07:00
ctype
debug debug: Add tests for _FORTIFY_SOURCE=3 2021-10-20 18:13:05 +05:30
dirent Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
dlfcn Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
elf elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645) 2021-10-21 11:23:53 -03:00
gmon Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
gnulib Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
grp Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
gshadow Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
hesiod Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
htl htl: Fix sigset of main thread 2021-09-26 02:40:26 +02:00
hurd Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
iconv iconv: Use TIMEOUTFACTOR for iconv test timeout 2021-10-21 11:11:07 -03:00
iconvdata Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
include elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645) 2021-10-21 11:23:53 -03:00
inet Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
intl Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
io Make sure that the fortified function conditionals are constant 2021-10-20 18:12:41 +05:30
libio Make sure that the fortified function conditionals are constant 2021-10-20 18:12:41 +05:30
locale locale: Add missing second argument to _Static_assert in C-collate-seq.c 2021-09-06 19:43:37 +02:00
localedata Update to Unicode 14.0.0 [BZ #28390] 2021-10-04 08:54:27 +02:00
login Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
mach
malloc Add alloc_align attribute to memalign et al 2021-10-21 00:19:20 +01:00
manual elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645) 2021-10-21 11:23:53 -03:00
math math: Also xfail the new j0f tests for ibm128-libgcc 2021-10-06 10:50:31 -03:00
mathvec
misc Add alloc_align attribute to memalign et al 2021-10-21 00:19:20 +01:00
nis Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
nptl nptl: Fix tst-cancel7 and tst-cancelx7 pidfile race 2021-10-18 13:30:10 -03:00
nptl_db Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
nscd Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
nss nss: Unnest nested function add_key 2021-10-19 09:36:43 -07:00
po po/nl.po: Update Dutch translation. 2021-08-01 20:52:28 -04:00
posix posix: Remove alloca usage for internal fnmatch implementation 2021-10-21 10:30:31 -03:00
pwd Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
resolv resolv: Avoid GCC 12 false positive warning [BZ #28439]. 2021-10-11 09:36:57 -06:00
resource y2038: Add support for 64-bit time on legacy ABIs 2021-06-15 10:42:11 -03:00
rt Remove unreliable parts of rt/tst-cpuclock2 2021-10-07 22:38:49 -04:00
scripts elf: Testing infrastructure for ld.so DSO sorting (BZ #17645) 2021-10-21 11:23:53 -03:00
setjmp
shadow Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
signal Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
socket Make sure that the fortified function conditionals are constant 2021-10-20 18:12:41 +05:30
soft-fp Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
stdio-common Fix stdio-common tests for GCC 12 -Waddress 2021-10-04 19:10:43 +00:00
stdlib Add alloc_align attribute to memalign et al 2021-10-21 00:19:20 +01:00
string Correct access attribute on memfrob (bug 28475) 2021-10-20 13:38:50 +00:00
sunrpc Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
support elf: Testing infrastructure for ld.so DSO sorting (BZ #17645) 2021-10-21 11:23:53 -03:00
sysdeps elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645) 2021-10-21 11:23:53 -03:00
sysvipc Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
termios
time Fix subscript error with odd TZif file [BZ #28338] 2021-10-07 11:09:16 -03:00
timezone Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
wcsmbs Make sure that the fortified function conditionals are constant 2021-10-20 18:12:41 +05:30
wctype Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
.gitattributes
.gitignore
abi-tags
aclocal.m4 configure: Replaced obsolete AC_TRY_COMPILE 2021-06-04 10:16:00 -03:00
config.h.in elf: Remove Intel MPX support (lazy PLT, ld.so profile, and LD_AUDIT) 2021-10-11 11:14:02 -07:00
config.make.in
configure configure: Fix check for INSERT in linker script 2021-09-13 12:39:20 -07:00
configure.ac configure: Fix check for INSERT in linker script 2021-09-13 12:39:20 -07:00
CONTRIBUTED-BY Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
COPYING
COPYING.LIB
extra-lib.mk
gen-locales.mk
INSTALL Update install.texi, and regenerate INSTALL. 2021-08-01 16:48:43 -04:00
libc-abis
libof-iterator.mk
LICENSES
MAINTAINERS
Makeconfig Run conform/ tests using newly built libc 2021-09-17 13:12:10 +00:00
Makefile testrun.sh: Add support for --tool=rpctrace 2021-09-10 01:24:10 +02:00
Makefile.help
Makefile.in
Makerules Install shared objects under their ABI names 2021-06-28 08:33:57 +02:00
NEWS elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645) 2021-10-21 11:23:53 -03:00
o-iterator.mk
README
Rules Move malloc hooks into a compat DSO 2021-07-22 18:37:59 +05:30
SHARED-FILES Mention today's regex merge in SHARED-FILES 2021-09-21 18:00:10 -07:00
shlib-versions Move malloc hooks into a compat DSO 2021-07-22 18:37:59 +05:30
test-skeleton.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
version.h Open master branch for glibc 2.35 development 2021-08-01 21:54:40 -04:00

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arc*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv32-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see https://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at https://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see https://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.