glibc/manual
Siddhesh Poyarekar 70939528c6 ungetc: Fix uninitialized read when putting into unused streams [BZ #27821]
When ungetc is called on an unused stream, the backup buffer is
allocated without the main get area being present.  This results in
every subsequent ungetc (as the stream remains in the backup area)
checking uninitialized memory in the backup buffer when trying to put a
character back into the stream.

Avoid comparing the input character with buffer contents when in backup
to avoid this uninitialized read.  The uninitialized read is harmless in
this context since the location is promptly overwritten with the input
character, thus fulfilling ungetc functionality.

Also adjust wording in the manual to drop the paragraph that says glibc
cannot do multiple ungetc back to back since with this change, ungetc
can actually do this.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
(cherry picked from commit cdf0f88f97)
2024-08-28 15:58:01 -04:00
..
examples Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
argp.texi stdlib: Reinstate stable mergesort implementation on qsort 2024-01-15 15:58:35 -03:00
arith.texi Implement C23 <stdbit.h> 2024-01-03 12:07:14 +00:00
charset.texi wcrtomb: Make behavior POSIX compliant 2022-05-13 19:15:46 +05:30
check-safety.sh Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
conf.texi Call "CST" a time zone abbreviation, not a name 2023-06-22 13:49:09 -07:00
contrib.texi contrib.texi: update 2024-01-30 23:48:12 +01:00
creature.texi Always define __USE_TIME_BITS64 when 64 bit time_t is used 2024-05-28 07:30:07 +02:00
crypt.texi crypt: Remove libcrypt support 2023-10-30 13:03:59 -03:00
ctype.texi manual: Enhance documentation of the <ctype.h> functions 2023-07-03 12:36:56 +02:00
debug.texi
dir
dynlink.texi manual: Fix ld.so diagnostics menu/section structure 2023-09-06 18:37:21 +02:00
errno.texi manual: Update documentation of strerror and related functions 2023-07-03 12:36:56 +02:00
fdl-1.3.texi
filesys.texi
freemanuals.texi
getopt.texi manual: Clarify that abbreviations of long options are allowed 2022-05-04 15:56:47 +05:30
header.texi
install-plain.texi
install.texi INSTALL, install.texi: minor updates, regenerate 2024-01-31 00:13:43 +01:00
intro.texi Fix misspellings in manual/ -- BZ 25337 2023-05-27 16:41:44 +00:00
io.texi manual/io: Fix swapped reading and writing phrase. 2024-01-30 20:10:38 +01:00
ipc.texi Fix misspellings in manual/ -- BZ 25337 2023-05-27 16:41:44 +00:00
job.texi manual/jobs.texi: Add missing @item EPERM for getpgid 2023-08-25 11:43:30 +02:00
lang.texi
lgpl-2.1.texi
libc-texinfo.sh grep: egrep -> grep -E, fgrep -> grep -F 2022-06-05 12:09:02 -07:00
libc.texinfo Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
libcbook.texi
llio.texi mremap: Update manual entry 2024-08-01 14:21:49 +02:00
locale.texi stdlib: Reinstate stable mergesort implementation on qsort 2024-01-15 15:58:35 -03:00
macros.texi
maint.texi Always define __USE_TIME_BITS64 when 64 bit time_t is used 2024-05-28 07:30:07 +02:00
Makefile Implement C23 <stdbit.h> 2024-01-03 12:07:14 +00:00
math.texi Remove ia64-linux-gnu 2024-01-08 17:09:36 -03:00
memory.texi manual: fix order of arguments of memalign and aligned_alloc (Bug 27547) 2024-01-24 12:10:38 -05:00
message.texi
nss.texi
nsswitch.texi
pattern.texi Fix misspellings in manual/ -- BZ 25337 2023-05-27 16:41:44 +00:00
pipe.texi
platform.texi x86: Add support for AVX10 preset and vec size in cpu-features 2023-09-29 14:18:42 -05:00
probes.texi
process.texi linux: Add pidfd_getpid 2023-09-05 13:08:59 -03:00
README.pretty-printers Fix misspellings in manual/ -- BZ 25337 2023-05-27 16:41:44 +00:00
README.tunables elf: Ignore GLIBC_TUNABLES for setuid/setgid binaries 2023-11-21 16:15:42 -03:00
resource.texi manual: make setrlimit() description less ambiguous 2024-07-29 17:06:13 +02:00
search.texi stdlib: Reinstate stable mergesort implementation on qsort 2024-01-15 15:58:35 -03:00
setjmp.texi
signal.texi
socket.texi Fix misspellings in manual/ -- BZ 25337 2023-05-27 16:41:44 +00:00
startup.texi
stdbit.texi Use gcc __builtin_stdc_* builtins in stdbit.h if possible 2024-03-04 12:56:27 +01:00
stdio-fp.c
stdio.texi ungetc: Fix uninitialized read when putting into unused streams [BZ #27821] 2024-08-28 15:58:01 -04:00
string.texi Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
summary.pl Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
sysinfo.texi
syslog.texi
terminal.texi manual: document posix_openpt (bug 17010) 2023-04-26 12:29:39 +00:00
texinfo.tex
texis.awk
threads.texi Linux: Make __rseq_size useful for feature detection (bug 31965) 2024-07-16 16:35:29 +02:00
time.texi Implement C23 <stdbit.h> 2024-01-03 12:07:14 +00:00
tsort.awk Update copyright dates with scripts/update-copyrights 2024-01-01 10:53:40 -08:00
tunables.texi elf: Add ELF_DYNAMIC_AFTER_RELOC to rewrite PLT 2024-01-05 05:49:49 -08:00
users.texi crypt: Remove libcrypt support 2023-10-30 13:03:59 -03:00
xtract-typefun.awk

			TUNABLE FRAMEWORK
			=================

Tunables is a feature in the GNU C Library that allows application authors and
distribution maintainers to alter the runtime library behaviour to match their
workload.

The tunable framework allows modules within glibc to register variables that
may be tweaked through an environment variable.  It aims to enforce a strict
namespace rule to bring consistency to naming of these tunable environment
variables across the project.  This document is a guide for glibc developers to
add tunables to the framework.

ADDING A NEW TUNABLE
--------------------

The TOP_NAMESPACE macro is defined by default as 'glibc'.  If distributions
intend to add their own tunables, they should do so in a different top
namespace by overriding the TOP_NAMESPACE macro for that tunable.  Downstream
implementations are discouraged from using the 'glibc' top namespace for
tunables they don't already have consensus to push upstream.

There are three steps to adding a tunable:

1. Add a tunable to the list and fully specify its properties:

For each tunable you want to add, make an entry in elf/dl-tunables.list.  The
format of the file is as follows:

TOP_NAMESPACE {
  NAMESPACE1 {
    TUNABLE1 {
      # tunable attributes, one per line
    }
    # A tunable with default attributes, i.e. string variable.
    TUNABLE2
    TUNABLE3 {
      # its attributes
    }
  }
  NAMESPACE2 {
    ...
  }
}

The list of allowed attributes are:

- type:			Data type.  Defaults to STRING.  Allowed types are:
			INT_32, UINT_64, SIZE_T and STRING.  Numeric types may
			be in octal or hexadecimal format too.

- minval:		Optional minimum acceptable value.  For a string type
			this is the minimum length of the value.

- maxval:		Optional maximum acceptable value.  For a string type
			this is the maximum length of the value.

- default:		Specify an optional default value for the tunable.

- env_alias:		An alias environment variable

2. Use TUNABLE_GET/TUNABLE_SET/TUNABLE_SET_WITH_BOUNDS to get and set tunables.

3. OPTIONAL: If tunables in a namespace are being used multiple times within a
   specific module, set the TUNABLE_NAMESPACE macro to reduce the amount of
   typing.

GETTING AND SETTING TUNABLES
----------------------------

When the TUNABLE_NAMESPACE macro is defined, one may get tunables in that
module using the TUNABLE_GET macro as follows:

  val = TUNABLE_GET (check, int32_t, TUNABLE_CALLBACK (check_callback))

where 'check' is the tunable name, 'int32_t' is the C type of the tunable and
'check_callback' is the function to call if the tunable got initialized to a
non-default value.  The macro returns the value as type 'int32_t'.

The callback function should be defined as follows:

  void
  TUNABLE_CALLBACK (check_callback) (int32_t *valp)
  {
  ...
  }

where it can expect the tunable value to be passed in VALP.

Tunables in the module can be updated using:

  TUNABLE_SET (check, val)

where 'check' is the tunable name and 'val' is a value of same type.

To get and set tunables in a different namespace from that module, use the full
form of the macros as follows:

  val = TUNABLE_GET_FULL (glibc, cpu, hwcap_mask, uint64_t, NULL)

  TUNABLE_SET_FULL (glibc, cpu, hwcap_mask, val)

where 'glibc' is the top namespace, 'cpu' is the tunable namespace and the
remaining arguments are the same as the short form macros.

The minimum and maximum values can updated together with the tunable value
using:

  TUNABLE_SET_WITH_BOUNDS (check, val, min, max)

where 'check' is the tunable name, 'val' is a value of same type, 'min' and
'max' are the minimum and maximum values of the tunable.

To set the minimum and maximum values of tunables in a different namespace
from that module, use the full form of the macros as follows:

  val = TUNABLE_GET_FULL (glibc, cpu, hwcap_mask, uint64_t, NULL)

  TUNABLE_SET_WITH_BOUNDS_FULL (glibc, cpu, hwcap_mask, val, min, max)

where 'glibc' is the top namespace, 'cpu' is the tunable namespace and the
remaining arguments are the same as the short form macros.

When TUNABLE_NAMESPACE is not defined in a module, TUNABLE_GET is equivalent to
TUNABLE_GET_FULL, so you will need to provide full namespace information for
both macros.  Likewise for TUNABLE_SET, TUNABLE_SET_FULL,
TUNABLE_SET_WITH_BOUNDS and TUNABLE_SET_WITH_BOUNDS_FULL.

** IMPORTANT NOTE **

The tunable list is set as read-only after the dynamic linker relocates itself,
so setting tunable values must be limited only to tunables within the dynamic
linker, that too before relocation.

FUTURE WORK
-----------

The framework currently only allows a one-time initialization of variables
through environment variables and in some cases, modification of variables via
an API call.  A future goals for this project include:

- Setting system-wide and user-wide defaults for tunables through some
  mechanism like a configuration file.

- Allow tweaking of some tunables at runtime