mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2025-03-31 14:01:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Correct MIPS math-tests.h condition for sNaN payload preservation.

Browse Source 
Testing for MIPS soft float shows that the issue with NaN payload
preservation applies to soft float as well as hard float: the
sfp-machine.h emulates hardware non-preservation semantics, although
only for the case of two NaN arguments.

This patch duly changes the MIPS math-tests.h to expect such
non-preservation for soft float as well as hard float.  The issue in
the NAN2008 case for which I posted
<https://gcc.gnu.org/ml/gcc-patches/2017-01/msg00034.html>, of sNaN
payloads being preserved but qNaN payloads not being preserved, is not
currently an issue for glibc tests because we don't have any tests
that check for qNaN payloads being preserved by arithmetic, so a
simple __mips_nan2008 conditional suffices without needing compiler
version checks in the __mips_nan2008 case.

Tested for mips64 soft float.

	* sysdeps/mips/math-tests.h (SNAN_TESTS_PRESERVE_PAYLOAD): Do not
	condition on [__mips_hard_float].
This commit is contained in:
Joseph Myers 2017-01-02 20:28:36 +00:00
parent 23d27709a4
commit f39cd196c6
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2017-01-02 Joseph Myers <joseph@codesourcery.com>
* sysdeps/mips/math-tests.h (SNAN_TESTS_PRESERVE_PAYLOAD): Do not
condition on [__mips_hard_float].
2017-01-02 Adhemerval Zanella <adhemerval.zanella@linaro.org>
[BZ #21014]

2
sysdeps/mips/math-tests.h
View File

@ -37,7 +37,7 @@
/* NaN payload preservation when converting a signaling NaN to quiet
is only required in NAN2008 mode. */
#if defined __mips_hard_float && !defined __mips_nan2008
#ifndef __mips_nan2008
# define SNAN_TESTS_PRESERVE_PAYLOAD 0
#endif