mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2025-03-31 14:01:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix x86 sqrt rounding (bug 14032).

Browse Source
This commit is contained in:
Joseph Myers 2013-11-29 16:31:16 +00:00
parent 0712c9d861
commit ea3bc4e821
6 changed files with 3761 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,5 +1,12 @@
2013-11-29 Joseph Myers <joseph@codesourcery.com>
[BZ #14032]
* sysdeps/i386/fpu/e_sqrt.S (__ieee754_sqrt): Do fsqrt with
precision control set to double precision.
* sysdeps/i386/fpu/w_sqrt.c: New file.
* math/auto-libm-test-in: Add more tests.
* math/auto-libm-test-out: Update.
* math/libm-test.inc (sqrt_tonearest_test_data): New variable.
(sqrt_test_tonearest): New function.
(sqrt_towardzero_test_data): New variable.

20
NEWS
View File

@ -10,16 +10,16 @@ Version 2.19
* The following bugs are resolved with this release:
156, 387, 431, 832, 2801, 7003, 9954, 10253, 10278, 11087, 11157, 11214,
13028, 13982, 13985, 14029, 14143, 14155, 14547, 14699, 14752, 14876,
14910, 15004, 15048, 15218, 15277, 15308, 15362, 15374, 15400, 15427,
15483, 15522, 15531, 15532, 15601, 15608, 15609, 15610, 15632, 15640,
15670, 15672, 15680, 15681, 15723, 15734, 15735, 15736, 15748, 15749,
15754, 15760, 15763, 15764, 15797, 15799, 15825, 15844, 15847, 15849,
15855, 15856, 15857, 15859, 15867, 15886, 15887, 15890, 15892, 15893,
15895, 15897, 15905, 15909, 15917, 15919, 15921, 15923, 15939, 15948,
15963, 15966, 15985, 15988, 15997, 16032, 16034, 16036, 16037, 16041,
16055, 16071, 16072, 16074, 16077, 16078, 16103, 16112, 16143, 16144,
16146, 16150, 16151, 16153, 16167, 16172, 16214, 16245, 16271.
13028, 13982, 13985, 14029, 14032, 14143, 14155, 14547, 14699, 14752,
14876, 14910, 15004, 15048, 15218, 15277, 15308, 15362, 15374, 15400,
15427, 15483, 15522, 15531, 15532, 15601, 15608, 15609, 15610, 15632,
15640, 15670, 15672, 15680, 15681, 15723, 15734, 15735, 15736, 15748,
15749, 15754, 15760, 15763, 15764, 15797, 15799, 15825, 15844, 15847,
15849, 15855, 15856, 15857, 15859, 15867, 15886, 15887, 15890, 15892,
15893, 15895, 15897, 15905, 15909, 15917, 15919, 15921, 15923, 15939,
15948, 15963, 15966, 15985, 15988, 15997, 16032, 16034, 16036, 16037,
16041, 16055, 16071, 16072, 16074, 16077, 16078, 16103, 16112, 16143,
16144, 16146, 16150, 16151, 16153, 16167, 16172, 16214, 16245, 16271.
* The public headers no longer use __unused nor __block. This change is to
support compiling programs that are derived from BSD sources and use

57
math/auto-libm-test-in
View File

@ -25,3 +25,60 @@ sqrt 0.25
sqrt 6642.25
sqrt 15190.5625
sqrt 0.75
sqrt 0x1.fffffffffffffp+1023
sqrt 0x1.ffffffffffffbp+1023
sqrt 0x1.ffffffffffff7p+1023
sqrt 0x1.ffffffffffff3p+1023
sqrt 0x1.fffffffffffefp+1023
sqrt 0x1.fffffffffffebp+1023
sqrt 0x1.fffffffffffe7p+1023
sqrt 0x1.fffffffffffe3p+1023
sqrt 0x1.fffffffffffdfp+1023
sqrt 0x1.fffffffffffdbp+1023
sqrt 0x1.fffffffffffd7p+1023
sqrt 0x1.0000000000003p-1022
sqrt 0x1.0000000000007p-1022
sqrt 0x1.000000000000bp-1022
sqrt 0x1.000000000000fp-1022
sqrt 0x1.0000000000013p-1022
sqrt 0x1.0000000000017p-1022
sqrt 0x1.000000000001bp-1022
sqrt 0x1.000000000001fp-1022
sqrt 0x1.0000000000023p-1022
sqrt 0x1.0000000000027p-1022
sqrt 0x1.000000000002bp-1022
sqrt 0x1.000000000002fp-1022
sqrt 0x1.0000000000033p-1022
sqrt 0x1.0000000000037p-1022
sqrt 0x1.7167bc36eaa3bp+6
sqrt 0x1.7570994273ad7p+6
sqrt 0x1.7dae969442fe6p+6
sqrt 0x1.7f8444fcf67e5p+6
sqrt 0x1.8364650e63a54p+6
sqrt 0x1.85bedd274edd8p+6
sqrt 0x1.8609cf496ab77p+6
sqrt 0x1.873849c70a375p+6
sqrt 0x1.8919c962cbaaep+6
sqrt 0x1.8de4493e22dc6p+6
sqrt 0x1.924829a17a288p+6
sqrt 0x1.92702cd992f12p+6
sqrt 0x1.92b763a8311fdp+6
sqrt 0x1.947da013c7293p+6
sqrt 0x1.9536091c494d2p+6
sqrt 0x1.61b04c6p-1019
sqrt 0x1.93789f1p-1018
sqrt 0x1.a1989b4p-1018
sqrt 0x1.f93bc9p-1018
sqrt 0x1.2f675e3p-1017
sqrt 0x1.a158508p-1017
sqrt 0x1.cd31f078p-1017
sqrt 0x1.33b43b08p-1016
sqrt 0x1.6e66a858p-1016
sqrt 0x1.8661cbf8p-1016
sqrt 0x1.bbb221b4p-1016
sqrt 0x1.c4942f3cp-1016
sqrt 0x1.dbb258c8p-1016
sqrt 0x1.57103ea4p-1015
sqrt 0x1.9b294f88p-1015
sqrt 0x1.0000000000001p+0
sqrt 0x1.fffffffffffffp-1

3669
math/auto-libm-test-out
View File

File diff suppressed because it is too large Load Diff

10
sysdeps/i386/fpu/e_sqrt.S
View File

@ -7,7 +7,17 @@
ENTRY(__ieee754_sqrt)
fldl 4(%esp)
subl $8, %esp
cfi_adjust_cfa_offset (8)
fstcw 4(%esp)
movl $0xfeff, %edx
andl 4(%esp), %edx
movl %edx, (%esp)
fldcw (%esp)
fsqrt
fldcw 4(%esp)
addl $8, %esp
cfi_adjust_cfa_offset (-8)
ret
END (__ieee754_sqrt)
strong_alias (__ieee754_sqrt, __sqrt_finite)

8
sysdeps/i386/fpu/w_sqrt.c Normal file
View File

@ -0,0 +1,8 @@
/* The inline __ieee754_sqrt is not correctly rounding; it's OK for
most internal uses in glibc, but not for sqrt itself. */
#define __ieee754_sqrt __avoid_ieee754_sqrt
#include <math.h>
#include <math_private.h>
#undef __ieee754_sqrt
extern double __ieee754_sqrt (double);
#include <math/w_sqrt.c>