mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2025-01-18 12:16:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix tests which expose ldbl -> _Float128 redirects

Browse Source 
The ldbl redirects for ieee128 have some jagged edges when
inspecting and manipulating symbols directly.

e.g asprintf is unconditionally redirected to __asprintfieee128
thus any tests relying on GCC's redirect behavior will encounter
problems if they inspect the symbol names too closely.

I've mitigated tests which expose the limitations of the
ldbl -> f128 redirects by giving them knowledge about the
redirected symbol names.

Hopefully there isn't much user code which depends on this
implementation specific behavior.

Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
This commit is contained in:
Paul E. Murphy 2020-02-07 14:08:16 -06:00
parent 45ae17dd7e
commit d0d1811fb9
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
elf/tst-addr1.c
View File

@ -12,6 +12,16 @@ do_test (void)
return 1;
}
printf ("found symbol %s in %s\n", i.dli_sname, i.dli_fname);
if (i.dli_sname == NULL)
return 1;
#if __LONG_DOUBLE_USES_FLOAT128 == 1
/* On architectures which redirect long double to
_Float128 (e.g powerpc64le), printf will resolve
to __printfieee128 due to header redirects. There
is no _IO_printfieee128 alias. */
return strcmp (i.dli_sname, "__printfieee128") != 0;
#else
return i.dli_sname == NULL
|| (strcmp (i.dli_sname, "printf") != 0
/* On architectures which create PIC code by default
@ -20,6 +30,7 @@ do_test (void)
are aliased and which one comes first in the
hash table is up to the linker. */
&& strcmp (i.dli_sname, "_IO_printf") != 0);
#endif
}
#include <support/test-driver.c>

4
stdio-common/tst-vfprintf-user-type.c
View File

@ -147,7 +147,11 @@ do_test (void)
/* Alias declaration for asprintf, to avoid the format string
attribute and the associated warning. */
#if __LONG_DOUBLE_USES_FLOAT128 == 1
extern int asprintf_alias (char **, const char *, ...) __asm__ ("__asprintfieee128");
#else
extern int asprintf_alias (char **, const char *, ...) __asm__ ("asprintf");
#endif
TEST_VERIFY (asprintf_alias == asprintf);
char *str = NULL;
TEST_VERIFY (asprintf_alias (&str, "[[%P]]", 123L, 456.0) >= 0);