Fix gen-auto-libm-tests sticky bit setting for negative results.

gen-auto-libm-tests has a bug in the logic for setting a sticky bit
based on the ternary value from MPFR: it is correct for positive
results, but for negative results mpz_setbit acts as if a two's
complement representation is used, whereas the low bit needs setting
based on the sign-magnitude representation GMP actually uses.  (This
showed up in converting fma tests to use auto-libm-test-in /
gen-auto-libm-tests.)

This patch fixes the problem by negating the mpz_t value to set its
low bit.  There are lots of changes to auto-libm-test-out (mainly 1ulp
fixes to ldbl-128 expected results), but only a few ulps updates are
needed on x86 / x86_64.  In one case, a corrected expectation showed
up a spurious underflow exception where the correct result is slightly
outside the underflowing range.

Tested x86_64 and x86 and ulps updated accordingly.

	* math/gen-auto-libm-tests.c (adjust_real): Ensure integers are
	non-negative before setting low bit.
	* math/auto-libm-test-in: Mark one asin test possibly having
	spurious underflow.
	* math/auto-libm-test-out: Regenerated.
	* sysdeps/i386/fpu/libm-test-ulps: Update.
	* sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
This commit is contained in:
Joseph Myers 2014-02-18 14:45:41 +00:00
parent ef114eafbf
commit a4fb786185
6 changed files with 4479 additions and 4338 deletions

View File

@ -1,3 +1,13 @@
2014-02-18 Joseph Myers <joseph@codesourcery.com>
* math/gen-auto-libm-tests.c (adjust_real): Ensure integers are
non-negative before setting low bit.
* math/auto-libm-test-in: Mark one asin test possibly having
spurious underflow.
* math/auto-libm-test-out: Regenerated.
* sysdeps/i386/fpu/libm-test-ulps: Update.
* sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
2014-02-17 David Holsgrove <david.holsgrove@xilinx.com>
* sysdeps/microblaze: Move directory from ports/sysdeps/microblaze.

View File

@ -61,8 +61,9 @@ asin -0x0.ffffffffffffp0
asin 0x0.ffffffffffffffffp0
asin -0x0.ffffffffffffffffp0
# Bug 16351: underflow exception may be missing.
# Bug 16599: spurious underflow may occur.
asin min missing-underflow
asin -min missing-underflow
asin -min missing-underflow spurious-underflow:dbl-64:x86
asin min_subnorm missing-underflow
asin -min_subnorm missing-underflow

File diff suppressed because it is too large Load Diff

View File

@ -987,7 +987,14 @@ adjust_real (mpfr_t r, bool inexact)
mpz_t tmp;
mpz_init (tmp);
mpfr_exp_t e = mpfr_get_z_2exp (tmp, r);
mpz_setbit (tmp, 0);
if (mpz_sgn (tmp) < 0)
{
mpz_neg (tmp, tmp);
mpz_setbit (tmp, 0);
mpz_neg (tmp, tmp);
}
else
mpz_setbit (tmp, 0);
assert_exact (mpfr_set_z_2exp (r, tmp, e, MPFR_RNDN));
mpz_clear (tmp);
}

View File

@ -53,28 +53,47 @@ ildouble: 1
ldouble: 1
# asin_downward
Test "asin_downward (-0x2p-16384)":
ildouble: 1
ldouble: 1
Test "asin_downward (-0x4p-1024)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x4p-1076)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x4p-128)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x4p-16384)":
ildouble: 1
ldouble: 1
Test "asin_downward (-0x8p-152)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x8p-16448)":
ildouble: 1
ldouble: 1
Test "asin_downward (-0x8p-4)":
ildouble: 1
ldouble: 1
Test "asin_downward (-0x8p-972)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0xf.fffffff8p-4)":
ildouble: 1
ldouble: 1
@ -136,9 +155,13 @@ Test "asin_upward (-0x2p-16384)":
ildouble: 1
ldouble: 1
Test "asin_upward (-0x4p-1024)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_upward (-0x4p-1076)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_upward (-0x4p-128)":
@ -3894,6 +3917,9 @@ ifloat: 1
Test "Imaginary part of: ccos (0x4p-1076 + 0x5.ap+8 i)":
double: 1
idouble: 1
Test "Imaginary part of: ccos (0x4p-16328 + 0x1p-120 i)":
ildouble: 1
ldouble: 1
Test "Real part of: ccos (0xcp-4 + 0x1.4p+0 i)":
double: 1
float: 1
@ -6840,6 +6866,13 @@ float: 1
ifloat: 1
ildouble: 2
ldouble: 2
Test "Imaginary part of: ctan_downward (-0xc.35p+12 - 0xc.35p+12 i)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "Real part of: ctan_downward (0x1.921fb4p+0 + +0 i)":
ildouble: 1
ldouble: 1
@ -6982,6 +7015,13 @@ ifloat: 1
Test "Imaginary part of: ctan_downward (0x8p+16380 + 0x1p+0 i)":
ildouble: 1
ldouble: 1
Test "Imaginary part of: ctan_downward (0xc.35p+12 - 0xc.35p+12 i)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "Real part of: ctan_downward (0xcp-4 + 0x1.4p+0 i)":
double: 1
idouble: 1
@ -7701,6 +7741,20 @@ double: 2
idouble: 2
ildouble: 1
ldouble: 1
Test "Real part of: ctanh_downward (-0xc.35p+12 + 0xc.35p+12 i)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "Real part of: ctanh_downward (-0xc.35p+12 - 0xc.35p+12 i)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "Imaginary part of: ctanh_downward (0x1.63p+8 + 0x1p+0 i)":
ildouble: 1
ldouble: 1

View File

@ -123,11 +123,49 @@ double: 1
Test "asin_downward (-0x1p+0)":
double: 1
idouble: 1
Test "asin_downward (-0x2p-16384)":
ildouble: 1
ldouble: 1
Test "asin_downward (-0x4p-1024)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x4p-1076)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x4p-128)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x4p-16384)":
ildouble: 1
ldouble: 1
Test "asin_downward (-0x8p-152)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x8p-16448)":
ildouble: 1
ldouble: 1
Test "asin_downward (-0x8p-4)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0x8p-972)":
double: 1
idouble: 1
ildouble: 1
ldouble: 1
Test "asin_downward (-0xf.fffffff8p-4)":
double: 1
idouble: 1
@ -5127,6 +5165,9 @@ ldouble: 1
Test "Imaginary part of: ccos (0x4p-1076 + 0x5.ap+8 i)":
double: 1
idouble: 1
Test "Imaginary part of: ccos (0x4p-16328 + 0x1p-120 i)":
ildouble: 1
ldouble: 1
Test "Real part of: ccos (0xcp-4 + 0x1.4p+0 i)":
double: 1
float: 1
@ -8485,6 +8526,13 @@ double: 2
idouble: 2
ildouble: 2
ldouble: 2
Test "Imaginary part of: ctan_downward (-0xc.35p+12 - 0xc.35p+12 i)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "Real part of: ctan_downward (0x1.921fb4p+0 + +0 i)":
float: 1
ifloat: 1
@ -8631,6 +8679,13 @@ ifloat: 1
Test "Imaginary part of: ctan_downward (0x8p+16380 + 0x1p+0 i)":
ildouble: 1
ldouble: 1
Test "Imaginary part of: ctan_downward (0xc.35p+12 - 0xc.35p+12 i)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "Real part of: ctan_downward (0xcp-4 + 0x1.4p+0 i)":
float: 1
ifloat: 1
@ -9479,6 +9534,20 @@ idouble: 1
ifloat: 3
ildouble: 1
ldouble: 1
Test "Real part of: ctanh_downward (-0xc.35p+12 + 0xc.35p+12 i)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "Real part of: ctanh_downward (-0xc.35p+12 - 0xc.35p+12 i)":
double: 1
float: 1
idouble: 1
ifloat: 1
ildouble: 1
ldouble: 1
Test "Imaginary part of: ctanh_downward (0x1.63p+8 + 0x1p+0 i)":
ildouble: 1
ldouble: 1