mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-11-27 03:41:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

tests: fix warn unused result on asprintf calls

Browse Source 
When enabling _FORTIFY_SOURCE, some functions now lead to warnings when
their result is not checked.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
This commit is contained in:
Frédéric Bérat 2023-06-02 17:28:06 +02:00 committed by Siddhesh Poyarekar
parent 7d42120928
commit 8c4f69d711
10 changed files with 29 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
argp/argp-test.c
View File

@ -25,6 +25,8 @@
#include <string.h>
#include <argp.h>
#include <support/support.h>
const char *argp_program_version = "argp-test 1.0";
struct argp_option sub_options[] =
@ -178,12 +180,12 @@ help_filter (int key, const char *text, void *input)
if (key == ARGP_KEY_HELP_POST_DOC && text)
{
time_t now = time (0);
asprintf (&new_text, text, ctime (&now));
new_text = xasprintf (text, ctime (&now));
}
else if (key == 'f')
/* Show the default for the --foonly option. */
asprintf (&new_text, "%s (ZOT defaults to %x)",
text, params->foonly_default);
new_text = xasprintf ("%s (ZOT defaults to %x)",
text, params->foonly_default);
else
new_text = (char *)text;

8
posix/tst-execl2.c
View File

@ -18,12 +18,8 @@ prepare (int argc, char *argv[])
{
char *buf;
int off;
asprintf (&buf, "cp %s %n%s-copy", argv[0], &off, argv[0]);
if (buf == NULL)
{
puts ("asprintf failed");
exit (1);
}
buf = xasprintf ("cp %s %n%s-copy", argv[0], &off, argv[0]);
if (system (buf) != 0)
{
puts ("system failed");

8
posix/tst-execle2.c
View File

@ -18,12 +18,8 @@ prepare (int argc, char *argv[])
{
char *buf;
int off;
asprintf (&buf, "cp %s %n%s-copy", argv[0], &off, argv[0]);
if (buf == NULL)
{
puts ("asprintf failed");
exit (1);
}
buf = xasprintf ("cp %s %n%s-copy", argv[0], &off, argv[0]);
if (system (buf) != 0)
{
puts ("system failed");

17
posix/tst-execlp2.c
View File

@ -22,12 +22,8 @@ prepare (int argc, char *argv[])
{
char *buf;
int off;
asprintf (&buf, "cp %s %n%s-copy", argv[0], &off, argv[0]);
if (buf == NULL)
{
puts ("asprintf failed");
exit (1);
}
buf = xasprintf ("cp %s %n%s-copy", argv[0], &off, argv[0]);
if (system (buf) != 0)
{
puts ("system failed");
@ -58,13 +54,8 @@ do_test (void)
puts ("canonicalize_file_name failed");
return 1;
}
char *path;
asprintf (&path, "%s:../libio:../elf", bindir);
if (path == NULL)
{
puts ("asprintf failed");
return 1;
}
char *path = xasprintf ("%s:../libio:../elf", bindir);
setenv ("PATH", path, 1);

8
posix/tst-execv2.c
View File

@ -18,12 +18,8 @@ prepare (int argc, char *argv[])
{
char *buf;
int off;
asprintf (&buf, "cp %s %n%s-copy", argv[0], &off, argv[0]);
if (buf == NULL)
{
puts ("asprintf failed");
exit (1);
}
buf = xasprintf ("cp %s %n%s-copy", argv[0], &off, argv[0]);
if (system (buf) != 0)
{
puts ("system failed");

8
posix/tst-execve2.c
View File

@ -18,12 +18,8 @@ prepare (int argc, char *argv[])
{
char *buf;
int off;
asprintf (&buf, "cp %s %n%s-copy", argv[0], &off, argv[0]);
if (buf == NULL)
{
puts ("asprintf failed");
exit (1);
}
buf = xasprintf ("cp %s %n%s-copy", argv[0], &off, argv[0]);
if (system (buf) != 0)
{
puts ("system failed");

17
posix/tst-execvp2.c
View File

@ -25,12 +25,8 @@ prepare (int argc, char *argv[])
{
char *buf;
int off;
asprintf (&buf, "cp %s %n%s-copy", argv[0], &off, argv[0]);
if (buf == NULL)
{
puts ("asprintf failed");
exit (1);
}
buf = xasprintf ("cp %s %n%s-copy", argv[0], &off, argv[0]);
if (system (buf) != 0)
{
puts ("system failed");
@ -61,13 +57,8 @@ do_test (void)
puts ("canonicalize_file_name failed");
return 1;
}
char *path;
asprintf (&path, "%s:../libio:../elf", bindir);
if (path == NULL)
{
puts ("asprintf failed");
return 1;
}
char *path = xasprintf ("%s:../libio:../elf", bindir);
setenv ("PATH", path, 1);

4
stdio-common/bug5.c
View File

@ -7,6 +7,8 @@
#include <stdlib.h>
#include <unistd.h>
#include <support/support.h>
static char buf[8192];
int
@ -60,7 +62,7 @@ main (void)
the perhaps incompatible new shared libraries. */
unsetenv ("LD_LIBRARY_PATH");
asprintf (&printbuf, "cmp %s %s", inname, outname);
printbuf = xasprintf ("cmp %s %s", inname, outname);
result = system (printbuf);
remove (inname);
remove (outname);

4
stdio-common/test-fwrite.c
View File

@ -1,6 +1,8 @@
#include <stdio.h>
#include <string.h>
#include <support/support.h>
static int
do_test (void)
{
@ -57,7 +59,7 @@ do_test (void)
return 1;
}
asprintf (&line, "\
line = xasprintf ("\
GDB is free software and you are welcome to distribute copies of it\n\
under certain conditions; type \"show copying\" to see the conditions.\n\
There is absolutely no warranty for GDB; type \"show warranty\" for details.\n\

5
stdio-common/tst-fseek.c
View File

@ -25,6 +25,7 @@
#include <time.h>
#include <sys/stat.h>
#include <support/support.h>
static int
do_test (void)
@ -44,9 +45,7 @@ do_test (void)
if (tmpdir == NULL || tmpdir[0] == '\0')
tmpdir = "/tmp";
asprintf (&fname, "%s/tst-fseek.XXXXXX", tmpdir);
if (fname == NULL)
error (EXIT_FAILURE, errno, "cannot generate name for temporary file");
fname = xasprintf ("%s/tst-fseek.XXXXXX", tmpdir);
/* Create a temporary file. */
fd = mkstemp (fname);