From 84a9d5835a8483a805e5c618e952bc08697fce5d Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sat, 15 Jan 2022 21:58:39 +0100 Subject: [PATCH] hurd: Fix exec() leak on proc_task2proc failure env is allocated after args, so should be freed before it. --- hurd/hurdexec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hurd/hurdexec.c b/hurd/hurdexec.c index 546cc69960..d5a20cb9b0 100644 --- a/hurd/hurdexec.c +++ b/hurd/hurdexec.c @@ -469,10 +469,10 @@ retry: /* Got a signal while inside an RPC of the critical section, retry again */ goto retry; - outargs: - free (args); outenv: free (env); + outargs: + free (args); return err; } libc_hidden_def (_hurd_exec_paths)