From 666a9871f7afc40aebcc28eab8890ab99ee01a47 Mon Sep 17 00:00:00 2001 From: Ulrich Drepper Date: Thu, 23 Jul 2009 12:53:50 -0700 Subject: [PATCH] Avoid warnings in test cases. The posix/tst-rfc3484* test cases caused warnings in newer gccs because the unused but copied sin_zero part of sockaddr_in wasn't explicitly initialized. --- ChangeLog | 5 +++++ posix/tst-rfc3484-2.c | 2 ++ posix/tst-rfc3484-3.c | 2 ++ posix/tst-rfc3484.c | 2 ++ 4 files changed, 11 insertions(+) diff --git a/ChangeLog b/ChangeLog index 79aeb83274..7bc9fc348f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2009-07-23 Ulrich Drepper + * posix/tst-rfc3484.c (do_test): Initialize entire sockaddr_in + structure before copying it to avoid warning. + * posix/tst-rfc3484-2.c (do_test): Likewise. + * posix/tst-rfc3484-3.c (do_test): Likewise. + [BZ #10416] * include/unistd.h: Make header file suitable for C++ test cases. Patch by Duncan Simpson . diff --git a/posix/tst-rfc3484-2.c b/posix/tst-rfc3484-2.c index c85fdd0742..bf5f6cff7e 100644 --- a/posix/tst-rfc3484-2.c +++ b/posix/tst-rfc3484-2.c @@ -82,6 +82,8 @@ do_test (void) struct sockaddr_in so1; so1.sin_family = AF_INET; so1.sin_addr.s_addr = h (0xc0a85f19); + /* Clear the rest of the structure to avoid warnings. */ + memset (so1.sin_zero, '\0', sizeof (so1.sin_zero)); struct sockaddr_in sa1; sa1.sin_family = AF_INET; diff --git a/posix/tst-rfc3484-3.c b/posix/tst-rfc3484-3.c index 3aa4563c0c..8eba74e48e 100644 --- a/posix/tst-rfc3484-3.c +++ b/posix/tst-rfc3484-3.c @@ -113,6 +113,8 @@ do_test (void) struct sockaddr_in so; so.sin_family = AF_INET; so.sin_addr.s_addr = h (0x0aa85f19); + /* Clear the rest of the structure to avoid warnings. */ + memset (so.sin_zero, '\0', sizeof (so.sin_zero)); for (int i = 0; i < naddrs; ++i) { diff --git a/posix/tst-rfc3484.c b/posix/tst-rfc3484.c index 15d0c94a5e..26835cf8b2 100644 --- a/posix/tst-rfc3484.c +++ b/posix/tst-rfc3484.c @@ -102,6 +102,8 @@ do_test (void) struct sockaddr_in so; so.sin_family = AF_INET; so.sin_addr.s_addr = h (0xc0a85f19); + /* Clear the rest of the structure to avoid warnings. */ + memset (so.sin_zero, '\0', sizeof (so.sin_zero)); for (int i = 0; i < naddrs; ++i) {