mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2025-02-11 12:50:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove sysdeps/x86/fpu/bits/mathinline.h __finite inline.

Browse Source 
Continuing the removals of inline functions from the x86
bits/mathinline.h, this patch removes an inline of __finite (which was
not actually architecture-specific at all beyond its
endianness-dependence).

This inline is not normally used with GCC 4.4 or later, because
isfinite now uses __builtin_isfinite except for -fsignaling-nans.
Allowing __builtin_isfinite etc. to work properly even for
-fsignaling-nans, by implementing versions of those built-in functions
that use integer arithmetic in GCC, is
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66462> (a patch was
committed but had to be reverted because it caused problems, and that
patch didn't address all formats for all architectures, only some, so
by itself would not have been sufficient to allow glibc to use
__builtin_isfinite unconditionally for new-enough GCC).

Tested for x86_64 and x86.

	* sysdeps/x86/fpu/bits/mathinline.h [__USE_MISC] (__finite):
	Remove inline function.
This commit is contained in:
Joseph Myers 2018-03-16 18:36:53 +00:00
parent 34ba96b89c
commit 5d75b75fb7
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -1,5 +1,8 @@
2018-03-16 Joseph Myers <joseph@codesourcery.com> 2018-03-16 Joseph Myers <joseph@codesourcery.com>
* sysdeps/x86/fpu/bits/mathinline.h [__USE_MISC] (__finite):
Remove inline function.
* sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/i386/fpu/libm-test-ulps: Update.
* sysdeps/i386/i686/fpu/multiarch/libm-test-ulps: Likewise. * sysdeps/i386/i686/fpu/multiarch/libm-test-ulps: Likewise.

13
sysdeps/x86/fpu/bits/mathinline.h
View File

@ -306,19 +306,6 @@ __inline_mathcodeNP2 (hypot, __x, __y,
# endif # endif
# ifdef __USE_MISC
/* This function is used in the `isfinite' macro. */
__MATH_INLINE int
__NTH (__finite (double __x))
{
return (__extension__
(((((union { double __d; int __i[2]; }) {__d: __x}).__i[1]
| 0x800fffffu) + 1) >> 31));
}
# endif /* __USE_MISC */
/* Undefine some of the large macros which are not used anymore. */ /* Undefine some of the large macros which are not used anymore. */
# ifdef __FAST_MATH__ # ifdef __FAST_MATH__
# undef __expm1_code # undef __expm1_code