mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-11-27 03:41:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix posix/tst-spawn test

Browse Source 
The test spawns two children but only waited for one.
The fix avoids printing to stderr.

	* posix/tst-spawn.c (do_test): Wait for both children.
This commit is contained in:
Szabolcs Nagy 2017-09-26 17:40:09 +01:00
parent 7bacdcfc42
commit 5ba41de9ed
2 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -1,3 +1,7 @@
2017-10-12 Szabolcs Nagy <szabolcs.nagy@arm.com>
* posix/tst-spawn.c (do_test): Wait for both children.
2017-10-12 H.J. Lu <hongjiu.lu@intel.com>
[BZ #22284]

20
posix/tst-spawn.c
View File

@ -23,9 +23,10 @@
#include <spawn.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <wait.h>
#include <sys/param.h>
#include <support/check.h>
#include <support/xunistd.h>
/* Nonzero if the program gets called via `exec'. */
@ -249,13 +250,16 @@ do_test (int argc, char *argv[])
error (EXIT_FAILURE, errno, "posix_spawn_file_actions_destroy");
free (name3_copy);
/* Wait for the child. */
if (waitpid (pid, &status, 0) != pid)
error (EXIT_FAILURE, errno, "wrong child");
/* Wait for the children. */
TEST_VERIFY (xwaitpid (pid, &status, 0) == pid);
TEST_VERIFY (WIFEXITED (status));
TEST_VERIFY (!WIFSIGNALED (status));
TEST_VERIFY (WEXITSTATUS (status) == 0);
if (WTERMSIG (status) != 0)
error (EXIT_FAILURE, 0, "Child terminated incorrectly");
status = WEXITSTATUS (status);
xwaitpid (-1, &status, 0);
TEST_VERIFY (WIFEXITED (status));
TEST_VERIFY (!WIFSIGNALED (status));
TEST_VERIFY (WEXITSTATUS (status) == 0);
return status;
return 0;
}