mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-11-27 03:41:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken overflow check in posix_fallocate [BZ 18873]

Browse Source 
* sysdeps/posix/posix_fallocate.c (posix_fallocate):
* sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
Fix parenthesization typo.
This commit is contained in:
Paul Eggert 2015-08-25 23:42:01 -07:00 committed by Florian Weimer
parent 3f563e90e8
commit 543ef578c3
4 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2015-08-31 Paul Eggert <eggert@cs.ucla.edu>
[BZ #18873]
Fix broken overflow check in posix_fallocate
* sysdeps/posix/posix_fallocate.c (posix_fallocate):
* sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
Fix parenthesization typo.
2015-08-28 Mike Frysinger <vapier@gentoo.org>
[BZ #18887]

2
NEWS
View File

@ -12,7 +12,7 @@ Version 2.23
2898, 14341, 15786, 16141, 16517, 16519, 16520, 16734, 16973, 17787,
17905, 18084, 18086, 18240, 18265, 18370, 18421, 18480, 18525, 18610,
18618, 18647, 18661, 18674, 18681, 18778, 18781, 18787, 18789, 18790,
18795, 18796, 18820, 18823, 18824, 18863, 18887.
18795, 18796, 18820, 18823, 18824, 18863, 18873, 18887.
* The obsolete header <regexp.h> has been removed. Programs that require
this header must be updated to use <regex.h> instead.

2
sysdeps/posix/posix_fallocate.c
View File

@ -37,7 +37,7 @@ posix_fallocate (int fd, __off_t offset, __off_t len)
/* Perform overflow check. The outer cast relies on a GCC
extension. */
if ((__off_t) ((uint64_t) offset) + ((uint64_t) len) < 0)
if ((__off_t) ((uint64_t) offset + (uint64_t) len) < 0)
return EFBIG;
/* pwrite below will not do the right thing in O_APPEND mode. */

2
sysdeps/posix/posix_fallocate64.c
View File

@ -37,7 +37,7 @@ __posix_fallocate64_l64 (int fd, __off64_t offset, __off64_t len)
/* Perform overflow check. The outer cast relies on a GCC
extension. */
if ((__off64_t) ((uint64_t) offset) + ((uint64_t) len) < 0)
if ((__off64_t) ((uint64_t) offset + (uint64_t) len) < 0)
return EFBIG;
/* pwrite64 below will not do the right thing in O_APPEND mode. */