mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-11-21 01:12:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix ldbl-128 lgammal for small negative arguments (bug 16337).

Browse Source 
This patch fixes bug 16337, ldbl-128 lgammal spurious overflows for
small negative arguments (the arguments in question are already in the
testsuite).  The implementation uses the reflection formula to compute
lgamma of negative x from lgamma of -x, effectively resulting in a
calculation -log(x^2) + log(-x); cancellation isn't problematic in
this case (bugs for problematic cancellation in lgamma are 2542, 2543,
2558), but the x^2 calculation can underflow (in which case there is
spurious logic to return an overflowing value - lgamma can only ever
correctly overflow for large positive arguments, though tgamma can
overflow for small arguments of either sign as well as large positive
arguments).  The fix is simply to calculate the result directly with
logl when the argument is a small enough negative number.

Tested mips64.

	* sysdeps/ieee754/ldbl-128/e_lgammal_r.c (__ieee754_lgammal_r):
	Calculate results for small negative arguments directly rather
	than using reflection formula with special underflow handling.
This commit is contained in:
Joseph Myers 2013-12-22 20:50:16 +00:00
parent ef7344f09c
commit 4f40e4b307
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,5 +1,10 @@
2013-12-22 Joseph Myers <joseph@codesourcery.com> 2013-12-22 Joseph Myers <joseph@codesourcery.com>
[BZ #16337]
* sysdeps/ieee754/ldbl-128/e_lgammal_r.c (__ieee754_lgammal_r):
Calculate results for small negative arguments directly rather
than using reflection formula with special underflow handling.
* sysdeps/mach/hurd/Implies: Change unix/bsd/bsd4.4 to unix/bsd. * sysdeps/mach/hurd/Implies: Change unix/bsd/bsd4.4 to unix/bsd.
* sysdeps/unix/bsd/syscalls.list (chflags): Add entry from * sysdeps/unix/bsd/syscalls.list (chflags): Add entry from
sysdeps/unix/bsd/bsd4.4/syscalls.list. sysdeps/unix/bsd/bsd4.4/syscalls.list.

2
NEWS
View File

@ -22,7 +22,7 @@ Version 2.19
15966, 15985, 15988, 15997, 16032, 16034, 16036, 16037, 16038, 16041, 15966, 15985, 15988, 15997, 16032, 16034, 16036, 16037, 16038, 16041,
16055, 16071, 16072, 16074, 16077, 16078, 16103, 16112, 16143, 16144, 16055, 16071, 16072, 16074, 16077, 16078, 16103, 16112, 16143, 16144,
16146, 16150, 16151, 16153, 16167, 16172, 16195, 16214, 16245, 16271, 16146, 16150, 16151, 16153, 16167, 16172, 16195, 16214, 16245, 16271,
16274, 16283, 16289, 16293, 16314, 16316, 16330, 16338, 16356. 16274, 16283, 16289, 16293, 16314, 16316, 16330, 16337, 16338, 16356.
* The public headers no longer use __unused nor __block. This change is to * The public headers no longer use __unused nor __block. This change is to
support compiling programs that are derived from BSD sources and use support compiling programs that are derived from BSD sources and use

4
sysdeps/ieee754/ldbl-128/e_lgammal_r.c
View File

@ -782,6 +782,8 @@ __ieee754_lgammal_r (long double x, int *signgamp)
*signgamp = -1; *signgamp = -1;
else else
*signgamp = 1; *signgamp = 1;
if (q < 0x1p-120L)
return -__logl (q);
z = q - p; z = q - p;
if (z > 0.5L) if (z > 0.5L)
{ {
@ -789,8 +791,6 @@ __ieee754_lgammal_r (long double x, int *signgamp)
z = p - q; z = p - q;
} }
z = q * __sinl (PIL * z); z = q * __sinl (PIL * z);
if (z == 0.0L)
return (*signgamp * huge * huge);
w = __ieee754_lgammal_r (q, &i); w = __ieee754_lgammal_r (q, &i);
z = __logl (PIL / z) - w; z = __logl (PIL / z) - w;
return (z); return (z);