mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2025-03-31 14:01:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Simplify x86 nearbyint functions.

Browse Source 
The i386 implementations of nearbyint functions, and x86_64
nearbyintl, contain code to mask the "inexact" exception.  However,
the fnstenv instruction has the effect of masking all exceptions, so
this masking code has been redundant since fnstenv was added to those
implementations (by commit 846d9a4a3acdb4939ca7bf6aed48f9f6f26911be;
commit 71d1b0166b4ace0d804af2993b3815758b852efc added the test
math/test-nearbyint-except-2.c that verifies these functions do work
when called with "inexact" traps enabled); this patch removes the
redundant code.

Tested for x86_64 and x86.

	* sysdeps/i386/fpu/s_nearbyint.S (__nearbyint): Do not mask
	"inexact" exceptions after fnstenv.
	* sysdeps/i386/fpu/s_nearbyintf.S (__nearbyintf): Likewise.
	* sysdeps/i386/fpu/s_nearbyintl.S (__nearbyintl): Likewise.
	* sysdeps/x86_64/fpu/s_nearbyintl.S (__nearbyintl): Likewise.
This commit is contained in:
Joseph Myers 2016-06-22 15:40:30 +00:00
parent 11f4944d7f
commit 4e9bf327ad
5 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2016-06-22 Joseph Myers <joseph@codesourcery.com>
* sysdeps/i386/fpu/s_nearbyint.S (__nearbyint): Do not mask
"inexact" exceptions after fnstenv.
* sysdeps/i386/fpu/s_nearbyintf.S (__nearbyintf): Likewise.
* sysdeps/i386/fpu/s_nearbyintl.S (__nearbyintl): Likewise.
* sysdeps/x86_64/fpu/s_nearbyintl.S (__nearbyintl): Likewise.
2015-06-22 Zack Weinberg <zackw@panix.com>
* sysdeps/generic/bits/hwcap.h: Moved to ...

4
sysdeps/i386/fpu/s_nearbyint.S
View File

@ -11,10 +11,6 @@ ENTRY(__nearbyint)
subl $32, %esp
cfi_adjust_cfa_offset (32)
fnstenv 4(%esp)
movl 4(%esp), %eax
orl $0x20, %eax
movl %eax, (%esp)
fldcw (%esp)
frndint
fldenv 4(%esp)
addl $32, %esp

4
sysdeps/i386/fpu/s_nearbyintf.S
View File

@ -11,10 +11,6 @@ ENTRY(__nearbyintf)
subl $32, %esp
cfi_adjust_cfa_offset (32)
fnstenv 4(%esp)
movl 4(%esp), %eax
orl $0x20, %eax
movl %eax, (%esp)
fldcw (%esp)
frndint
fldenv 4(%esp)
addl $32, %esp

4
sysdeps/i386/fpu/s_nearbyintl.S
View File

@ -11,10 +11,6 @@ ENTRY(__nearbyintl)
subl $32, %esp
cfi_adjust_cfa_offset (32)
fnstenv 4(%esp)
movl 4(%esp), %eax
orl $0x20, %eax
movl %eax, (%esp)
fldcw (%esp)
frndint
fnstsw
andl $0x1, %eax

4
sysdeps/x86_64/fpu/s_nearbyintl.S
View File

@ -9,10 +9,6 @@
ENTRY(__nearbyintl)
fldt 8(%rsp)
fnstenv -28(%rsp)
movl -28(%rsp), %eax
orl $0x20, %eax
movl %eax, -32(%rsp)
fldcw -32(%rsp)
frndint
fnstsw
andl $0x1, %eax