mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-12-15 04:20:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

mips: increase stack alignment in clone to match the ABI

Browse Source 
In "mips: align stack in clone [BZ #28223]"
(commit 1f51cd9a86) I made a mistake: I
misbelieved one "word" was 2-byte and "doubleword" should be 4-byte.
But in MIPS ABI one "word" is defined 32-bit (4-byte), so "doubleword" is
8-byte [1], and "quadword" is 16-byte [2].

[1]: "System V Application Binary Interface: MIPS(R) RISC Processor
      Supplement, 3rd edition", page 3-31
[2]: "MIPSpro(TM) 64-Bit Porting and Transition Guide", page 23

(cherry picked from commit 0f62fe0532)
This commit is contained in:
Xi Ruoyao 2021-08-13 16:01:14 +00:00 committed by Aurelien Jarno
parent 7af07fe795
commit 4db172a54d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sysdeps/unix/sysv/linux/mips/clone.S
View File

@ -55,11 +55,11 @@ NESTED(__clone,4*SZREG,sp)
.set at .set at
#endif #endif
/* Align stack to 4/8 bytes per the ABI. */ /* Align stack to 8/16 bytes per the ABI. */
#if _MIPS_SIM == _ABIO32 #if _MIPS_SIM == _ABIO32
li t0,-4
#else
li t0,-8 li t0,-8
#else
li t0,-16
#endif #endif
and a1,a1,t0 and a1,a1,t0