From 4a08113c4ee0ec9f83ef2ae8a4c5893e80d451f7 Mon Sep 17 00:00:00 2001 From: Ulrich Drepper Date: Wed, 18 Feb 2004 20:02:17 +0000 Subject: [PATCH] Update. 2004-02-18 Jakub Jelinek * sysdeps/unix/sysv/linux/x86_64/pthread_rwlock_unlock.S (__pthread_rwlock_unlock): Access WRITER as 32-bit value. * Makefile (tests): Add tst-rwlock13. * tst-rwlock13.c: New test. --- nptl/ChangeLog | 7 ++ nptl/Makefile | 2 +- .../sysv/linux/x86_64/pthread_rwlock_unlock.S | 4 +- nptl/tst-rwlock13.c | 71 +++++++++++++++++++ 4 files changed, 81 insertions(+), 3 deletions(-) create mode 100644 nptl/tst-rwlock13.c diff --git a/nptl/ChangeLog b/nptl/ChangeLog index 2e18bfb6f9..ad2073d224 100644 --- a/nptl/ChangeLog +++ b/nptl/ChangeLog @@ -1,3 +1,10 @@ +2004-02-18 Jakub Jelinek + + * sysdeps/unix/sysv/linux/x86_64/pthread_rwlock_unlock.S + (__pthread_rwlock_unlock): Access WRITER as 32-bit value. + * Makefile (tests): Add tst-rwlock13. + * tst-rwlock13.c: New test. + 2004-02-16 Ulrich Drepper * sysdeps/unix/sysv/linux/i386/i486/pthread_cond_timedwait.S diff --git a/nptl/Makefile b/nptl/Makefile index 715dd766ff..2c020819f1 100644 --- a/nptl/Makefile +++ b/nptl/Makefile @@ -196,7 +196,7 @@ tests = tst-attr1 tst-attr2 tst-attr3 \ tst-cond8 tst-cond9 tst-cond10 tst-cond11 tst-cond12 tst-cond13 \ tst-rwlock1 tst-rwlock2 tst-rwlock3 tst-rwlock4 tst-rwlock5 \ tst-rwlock6 tst-rwlock7 tst-rwlock8 tst-rwlock9 tst-rwlock10 \ - tst-rwlock11 tst-rwlock12 \ + tst-rwlock11 tst-rwlock12 tst-rwlock13 \ tst-once1 tst-once2 tst-once3 tst-once4 \ tst-key1 tst-key2 tst-key3 tst-key4 \ tst-sem1 tst-sem2 tst-sem3 tst-sem4 tst-sem5 tst-sem6 tst-sem7 \ diff --git a/nptl/sysdeps/unix/sysv/linux/x86_64/pthread_rwlock_unlock.S b/nptl/sysdeps/unix/sysv/linux/x86_64/pthread_rwlock_unlock.S index 89652cc5d7..ac69fc0eae 100644 --- a/nptl/sysdeps/unix/sysv/linux/x86_64/pthread_rwlock_unlock.S +++ b/nptl/sysdeps/unix/sysv/linux/x86_64/pthread_rwlock_unlock.S @@ -49,12 +49,12 @@ __pthread_rwlock_unlock: #endif jnz 1f -2: cmpq $0, WRITER(%rdi) +2: cmpl $0, WRITER(%rdi) jne 5f decl NR_READERS(%rdi) jnz 6f -5: movq $0, WRITER(%rdi) +5: movl $0, WRITER(%rdi) movq $1, %rsi leaq WRITERS_WAKEUP(%rdi), %r10 diff --git a/nptl/tst-rwlock13.c b/nptl/tst-rwlock13.c new file mode 100644 index 0000000000..61d5b83e12 --- /dev/null +++ b/nptl/tst-rwlock13.c @@ -0,0 +1,71 @@ +/* Copyright (C) 2004 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, write to the Free + Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA + 02111-1307 USA. */ + +#include +#include +#include + + +static int +do_test (void) +{ + pthread_rwlock_t r; + int ret; + + memset (&r, 0xaa, sizeof (r)); + if ((ret = pthread_rwlock_init (&r, NULL)) != 0) + { + printf ("rwlock_init failed: %d\n", ret); + return 1; + } + + if ((ret = pthread_rwlock_rdlock (&r)) != 0) + { + printf ("rwlock_rdlock failed: %d\n", ret); + return 1; + } + + if ((ret = pthread_rwlock_unlock (&r)) != 0) + { + printf ("rwlock_unlock failed: %d\n", ret); + return 1; + } + + if ((ret = pthread_rwlock_wrlock (&r)) != 0) + { + printf ("rwlock_wrlock failed: %d\n", ret); + return 1; + } + + if ((ret = pthread_rwlock_unlock (&r)) != 0) + { + printf ("second rwlock_unlock failed: %d\n", ret); + return 1; + } + + if ((ret = pthread_rwlock_destroy (&r)) != 0) + { + printf ("second rwlock_destroy failed: %d\n", ret); + return 1; + } + + return 0; +} + +#define TEST_FUNCTION do_test () +#include "../test-skeleton.c"