mirror/glibc
2
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2024-11-27 03:41:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix implicit-fallthrough warnings in tst-setjmp.c.

Browse Source 
Building the testsuite with -Wextra (together with
-Wno-cast-function-type -Wno-clobbered -Wno-expansion-to-defined
-Wno-missing-field-initializers -Wno-old-style-declaration
-Wno-shift-negative-value -Wno-sign-compare -Wno-type-limits
-Wno-unused-parameter, which reflect the set of -Wextra warnings for
which glibc itself is not currently clean on x86_64) showed up
implicit-fallthrough warnings in tst-setjmp.c.  Those warnings appear
to be false positives, arising from a function "jump" that calls
longjmp not itself being marked as noreturn; thus, this patch adds the
noreturn marking to that function to fix the warnings.

Tested for x86_64.

	* setjmp/tst-setjmp.c (jump): Use __attribute__ ((__noreturn__)).
This commit is contained in:
Joseph Myers 2019-02-15 13:44:17 +00:00
parent 56a731d4ad
commit 365f05c7a5
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -1,3 +1,7 @@
2019-02-15 Joseph Myers <joseph@codesourcery.com>
* setjmp/tst-setjmp.c (jump): Use __attribute__ ((__noreturn__)).
2019-02-14 Jan Kratochvil <jan.kratochvil@redhat.com>
* scripts/test_printers_common.py: Set TERM to a known harmless

2
setjmp/tst-setjmp.c
View File

@ -22,7 +22,7 @@
static jmp_buf env;
static int last_value = -1, lose = 0;
static void
static __attribute__ ((__noreturn__)) void
jump (int val)
{
longjmp (env, val);