mirror of
git://sourceware.org/git/glibc.git
synced 2024-11-27 03:41:23 +08:00
Use $(pie-default) with conformtest
My glibc bot showed that my conformtest changes fail the build of the
conformtest execution tests for x86_64-linux-gnu-static-pie, because
linking the newly built object with the newly built libc and the
associated options normally used for linking requires it to be built
as PIE. Add $(pie-default) to the compiler command used so that PIE
options are used when required.
There's a case for using the whole of $(CFLAGS-.o) (which includes
$(pie-default)), but that raises questions of any impact from using
optimization flags from CFLAGS in these tests. So for now just use
$(pie-default) as the key part of $(CFLAGS-.o) that's definitely
needed.
Tested with build-many-glibcs.py for x86_64-linux-gnu-static-pie.
(cherry picked from commit 885762aa31
)
This commit is contained in:
parent
0dcbf4c870
commit
1fe4b8d693
@ -175,7 +175,8 @@ $(conformtest-header-tests): $(objpfx)%/conform.out: \
|
||||
conformtest.py $(conformtest-headers-data)
|
||||
(set -e; std_hdr=$*; std=$${std_hdr%%/*}; hdr=$${std_hdr#*/}; \
|
||||
mkdir -p $(@D); \
|
||||
$(PYTHON) $< --cc='$(CC)' --flags='$(conformtest-cc-flags)' \
|
||||
$(PYTHON) $< --cc='$(CC) $(pie-default)' \
|
||||
--flags='$(conformtest-cc-flags)' \
|
||||
--ldflags='$(+link-tests-before-inputs)' \
|
||||
--libs='$(+link-tests-after-inputs)' \
|
||||
--run-program-prefix='$(run-program-prefix)' \
|
||||
|
Loading…
Reference in New Issue
Block a user