From 00d54af7c86cdcabc18c00619c229f49f4978610 Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Tue, 5 Dec 2017 18:09:22 +0000 Subject: [PATCH] [PATCH] fix sinf(NAN) sinf(NAN) should not signal invalid fp exception so use isless instead of < where NAN is compared. this makes the sinf tests pass on aarch64. * sysdeps/ieee754/flt-32/s_sinf.c (sinf): Use isless. --- ChangeLog | 4 ++++ sysdeps/ieee754/flt-32/s_sinf.c | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index bcc49a1dc5..15da4e7937 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2017-12-05 Szabolcs Nagy + + * sysdeps/ieee754/flt-32/s_sinf.c (sinf): Use isless. + 2017-12-05 Joseph Myers * stdlib/strfromd.c: Include . diff --git a/sysdeps/ieee754/flt-32/s_sinf.c b/sysdeps/ieee754/flt-32/s_sinf.c index 0b76477d22..8b98573ae4 100644 --- a/sysdeps/ieee754/flt-32/s_sinf.c +++ b/sysdeps/ieee754/flt-32/s_sinf.c @@ -128,7 +128,7 @@ SINF_FUNC (float x) double theta = x; double abstheta = fabs (theta); /* If |x|< Pi/4. */ - if (abstheta < M_PI_4) + if (isless (abstheta, M_PI_4)) { if (abstheta >= 0x1p-5) /* |x| >= 2^-5. */ { @@ -162,8 +162,8 @@ SINF_FUNC (float x) } else /* |x| >= Pi/4. */ { - unsigned int signbit = (x < 0); - if (abstheta < 9 * M_PI_4) /* |x| < 9*Pi/4. */ + unsigned int signbit = isless (x, 0); + if (isless (abstheta, 9 * M_PI_4)) /* |x| < 9*Pi/4. */ { /* There are cases where FE_UPWARD rounding mode can produce a result of abstheta * inv_PI_4 == 9,