2017-06-02 17:59:28 +08:00
|
|
|
/* Capture output from a subprocess.
|
2021-01-03 03:32:25 +08:00
|
|
|
Copyright (C) 2017-2021 Free Software Foundation, Inc.
|
2017-06-02 17:59:28 +08:00
|
|
|
This file is part of the GNU C Library.
|
|
|
|
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
|
|
modify it under the terms of the GNU Lesser General Public
|
|
|
|
License as published by the Free Software Foundation; either
|
|
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
Lesser General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
|
|
License along with the GNU C Library; if not, see
|
Prefer https to http for gnu.org and fsf.org URLs
Also, change sources.redhat.com to sourceware.org.
This patch was automatically generated by running the following shell
script, which uses GNU sed, and which avoids modifying files imported
from upstream:
sed -ri '
s,(http|ftp)(://(.*\.)?(gnu|fsf|sourceware)\.org($|[^.]|\.[^a-z])),https\2,g
s,(http|ftp)(://(.*\.)?)sources\.redhat\.com($|[^.]|\.[^a-z]),https\2sourceware.org\4,g
' \
$(find $(git ls-files) -prune -type f \
! -name '*.po' \
! -name 'ChangeLog*' \
! -path COPYING ! -path COPYING.LIB \
! -path manual/fdl-1.3.texi ! -path manual/lgpl-2.1.texi \
! -path manual/texinfo.tex ! -path scripts/config.guess \
! -path scripts/config.sub ! -path scripts/install-sh \
! -path scripts/mkinstalldirs ! -path scripts/move-if-change \
! -path INSTALL ! -path locale/programs/charmap-kw.h \
! -path po/libc.pot ! -path sysdeps/gnu/errlist.c \
! '(' -name configure \
-execdir test -f configure.ac -o -f configure.in ';' ')' \
! '(' -name preconfigure \
-execdir test -f preconfigure.ac ';' ')' \
-print)
and then by running 'make dist-prepare' to regenerate files built
from the altered files, and then executing the following to cleanup:
chmod a+x sysdeps/unix/sysv/linux/riscv/configure
# Omit irrelevant whitespace and comment-only changes,
# perhaps from a slightly-different Autoconf version.
git checkout -f \
sysdeps/csky/configure \
sysdeps/hppa/configure \
sysdeps/riscv/configure \
sysdeps/unix/sysv/linux/csky/configure
# Omit changes that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/powerpc/powerpc64/ppc-mcount.S: trailing lines
git checkout -f \
sysdeps/powerpc/powerpc64/ppc-mcount.S \
sysdeps/unix/sysv/linux/s390/s390-64/syscall.S
# Omit change that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S: last line does not end in newline
git checkout -f sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
2019-09-07 13:40:42 +08:00
|
|
|
<https://www.gnu.org/licenses/>. */
|
2017-06-02 17:59:28 +08:00
|
|
|
|
support: Add support_capture_subprogram
Its API is similar to support_capture_subprocess, but rather creates a
new process based on the input path and arguments. Under the hoods it
uses posix_spawn to create the new process.
It also allows the use of other support_capture_* functions to check
for expected results and free the resources.
Checked on x86_64-linux-gnu.
* support/Makefile (libsupport-routines): Add support_subprocess,
xposix_spawn, xposix_spawn_file_actions_addclose, and
xposix_spawn_file_actions_adddup2.
(tst-support_capture_subprocess-ARGS): New rule.
* support/capture_subprocess.h (support_capture_subprogram): New
prototype.
* support/support_capture_subprocess.c (support_capture_subprocess):
Refactor to use support_subprocess and support_capture_poll.
(support_capture_subprogram): New function.
* support/tst-support_capture_subprocess.c (write_mode_to_str,
str_to_write_mode, test_common, parse_int, handle_restart,
do_subprocess, do_subprogram, do_multiple_tests): New functions.
(do_test): Add support_capture_subprogram tests.
* support/subprocess.h: New file.
* support/support_subprocess.c: Likewise.
* support/xposix_spawn.c: Likewise.
* support/xposix_spawn_file_actions_addclose.c: Likewise.
* support/xposix_spawn_file_actions_adddup2.c: Likewise.
* support/xspawn.h: Likewise.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2019-04-13 04:39:53 +08:00
|
|
|
#include <support/subprocess.h>
|
2017-06-02 17:59:28 +08:00
|
|
|
#include <support/capture_subprocess.h>
|
|
|
|
|
|
|
|
#include <errno.h>
|
2021-04-09 23:25:45 +08:00
|
|
|
#include <fcntl.h>
|
2017-06-02 17:59:28 +08:00
|
|
|
#include <stdlib.h>
|
|
|
|
#include <support/check.h>
|
|
|
|
#include <support/xunistd.h>
|
|
|
|
#include <support/xsocket.h>
|
support: Add support_capture_subprogram
Its API is similar to support_capture_subprocess, but rather creates a
new process based on the input path and arguments. Under the hoods it
uses posix_spawn to create the new process.
It also allows the use of other support_capture_* functions to check
for expected results and free the resources.
Checked on x86_64-linux-gnu.
* support/Makefile (libsupport-routines): Add support_subprocess,
xposix_spawn, xposix_spawn_file_actions_addclose, and
xposix_spawn_file_actions_adddup2.
(tst-support_capture_subprocess-ARGS): New rule.
* support/capture_subprocess.h (support_capture_subprogram): New
prototype.
* support/support_capture_subprocess.c (support_capture_subprocess):
Refactor to use support_subprocess and support_capture_poll.
(support_capture_subprogram): New function.
* support/tst-support_capture_subprocess.c (write_mode_to_str,
str_to_write_mode, test_common, parse_int, handle_restart,
do_subprocess, do_subprogram, do_multiple_tests): New functions.
(do_test): Add support_capture_subprogram tests.
* support/subprocess.h: New file.
* support/support_subprocess.c: Likewise.
* support/xposix_spawn.c: Likewise.
* support/xposix_spawn_file_actions_addclose.c: Likewise.
* support/xposix_spawn_file_actions_adddup2.c: Likewise.
* support/xspawn.h: Likewise.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2019-04-13 04:39:53 +08:00
|
|
|
#include <support/xspawn.h>
|
2021-04-09 23:25:45 +08:00
|
|
|
#include <support/support.h>
|
|
|
|
#include <support/test-driver.h>
|
2017-06-02 17:59:28 +08:00
|
|
|
|
|
|
|
static void
|
|
|
|
transfer (const char *what, struct pollfd *pfd, struct xmemstream *stream)
|
|
|
|
{
|
|
|
|
if (pfd->revents != 0)
|
|
|
|
{
|
|
|
|
char buf[1024];
|
|
|
|
ssize_t ret = TEMP_FAILURE_RETRY (read (pfd->fd, buf, sizeof (buf)));
|
|
|
|
if (ret < 0)
|
|
|
|
{
|
|
|
|
support_record_failure ();
|
2021-03-15 18:30:06 +08:00
|
|
|
printf ("error: reading from subprocess %s: %m\n", what);
|
2017-06-02 17:59:28 +08:00
|
|
|
pfd->events = 0;
|
|
|
|
pfd->revents = 0;
|
|
|
|
}
|
|
|
|
else if (ret == 0)
|
|
|
|
{
|
|
|
|
/* EOF reached. Stop listening. */
|
|
|
|
pfd->events = 0;
|
|
|
|
pfd->revents = 0;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
/* Store the data just read. */
|
|
|
|
TEST_VERIFY (fwrite (buf, ret, 1, stream->out) == 1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
support: Add support_capture_subprogram
Its API is similar to support_capture_subprocess, but rather creates a
new process based on the input path and arguments. Under the hoods it
uses posix_spawn to create the new process.
It also allows the use of other support_capture_* functions to check
for expected results and free the resources.
Checked on x86_64-linux-gnu.
* support/Makefile (libsupport-routines): Add support_subprocess,
xposix_spawn, xposix_spawn_file_actions_addclose, and
xposix_spawn_file_actions_adddup2.
(tst-support_capture_subprocess-ARGS): New rule.
* support/capture_subprocess.h (support_capture_subprogram): New
prototype.
* support/support_capture_subprocess.c (support_capture_subprocess):
Refactor to use support_subprocess and support_capture_poll.
(support_capture_subprogram): New function.
* support/tst-support_capture_subprocess.c (write_mode_to_str,
str_to_write_mode, test_common, parse_int, handle_restart,
do_subprocess, do_subprogram, do_multiple_tests): New functions.
(do_test): Add support_capture_subprogram tests.
* support/subprocess.h: New file.
* support/support_subprocess.c: Likewise.
* support/xposix_spawn.c: Likewise.
* support/xposix_spawn_file_actions_addclose.c: Likewise.
* support/xposix_spawn_file_actions_adddup2.c: Likewise.
* support/xspawn.h: Likewise.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2019-04-13 04:39:53 +08:00
|
|
|
static void
|
|
|
|
support_capture_poll (struct support_capture_subprocess *result,
|
|
|
|
struct support_subprocess *proc)
|
2017-06-02 17:59:28 +08:00
|
|
|
{
|
|
|
|
struct pollfd fds[2] =
|
|
|
|
{
|
support: Add support_capture_subprogram
Its API is similar to support_capture_subprocess, but rather creates a
new process based on the input path and arguments. Under the hoods it
uses posix_spawn to create the new process.
It also allows the use of other support_capture_* functions to check
for expected results and free the resources.
Checked on x86_64-linux-gnu.
* support/Makefile (libsupport-routines): Add support_subprocess,
xposix_spawn, xposix_spawn_file_actions_addclose, and
xposix_spawn_file_actions_adddup2.
(tst-support_capture_subprocess-ARGS): New rule.
* support/capture_subprocess.h (support_capture_subprogram): New
prototype.
* support/support_capture_subprocess.c (support_capture_subprocess):
Refactor to use support_subprocess and support_capture_poll.
(support_capture_subprogram): New function.
* support/tst-support_capture_subprocess.c (write_mode_to_str,
str_to_write_mode, test_common, parse_int, handle_restart,
do_subprocess, do_subprogram, do_multiple_tests): New functions.
(do_test): Add support_capture_subprogram tests.
* support/subprocess.h: New file.
* support/support_subprocess.c: Likewise.
* support/xposix_spawn.c: Likewise.
* support/xposix_spawn_file_actions_addclose.c: Likewise.
* support/xposix_spawn_file_actions_adddup2.c: Likewise.
* support/xspawn.h: Likewise.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2019-04-13 04:39:53 +08:00
|
|
|
{ .fd = proc->stdout_pipe[0], .events = POLLIN },
|
|
|
|
{ .fd = proc->stderr_pipe[0], .events = POLLIN },
|
2017-06-02 17:59:28 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
do
|
|
|
|
{
|
|
|
|
xpoll (fds, 2, -1);
|
support: Add support_capture_subprogram
Its API is similar to support_capture_subprocess, but rather creates a
new process based on the input path and arguments. Under the hoods it
uses posix_spawn to create the new process.
It also allows the use of other support_capture_* functions to check
for expected results and free the resources.
Checked on x86_64-linux-gnu.
* support/Makefile (libsupport-routines): Add support_subprocess,
xposix_spawn, xposix_spawn_file_actions_addclose, and
xposix_spawn_file_actions_adddup2.
(tst-support_capture_subprocess-ARGS): New rule.
* support/capture_subprocess.h (support_capture_subprogram): New
prototype.
* support/support_capture_subprocess.c (support_capture_subprocess):
Refactor to use support_subprocess and support_capture_poll.
(support_capture_subprogram): New function.
* support/tst-support_capture_subprocess.c (write_mode_to_str,
str_to_write_mode, test_common, parse_int, handle_restart,
do_subprocess, do_subprogram, do_multiple_tests): New functions.
(do_test): Add support_capture_subprogram tests.
* support/subprocess.h: New file.
* support/support_subprocess.c: Likewise.
* support/xposix_spawn.c: Likewise.
* support/xposix_spawn_file_actions_addclose.c: Likewise.
* support/xposix_spawn_file_actions_adddup2.c: Likewise.
* support/xspawn.h: Likewise.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2019-04-13 04:39:53 +08:00
|
|
|
transfer ("stdout", &fds[0], &result->out);
|
|
|
|
transfer ("stderr", &fds[1], &result->err);
|
2017-06-02 17:59:28 +08:00
|
|
|
}
|
|
|
|
while (fds[0].events != 0 || fds[1].events != 0);
|
|
|
|
|
support: Add support_capture_subprogram
Its API is similar to support_capture_subprocess, but rather creates a
new process based on the input path and arguments. Under the hoods it
uses posix_spawn to create the new process.
It also allows the use of other support_capture_* functions to check
for expected results and free the resources.
Checked on x86_64-linux-gnu.
* support/Makefile (libsupport-routines): Add support_subprocess,
xposix_spawn, xposix_spawn_file_actions_addclose, and
xposix_spawn_file_actions_adddup2.
(tst-support_capture_subprocess-ARGS): New rule.
* support/capture_subprocess.h (support_capture_subprogram): New
prototype.
* support/support_capture_subprocess.c (support_capture_subprocess):
Refactor to use support_subprocess and support_capture_poll.
(support_capture_subprogram): New function.
* support/tst-support_capture_subprocess.c (write_mode_to_str,
str_to_write_mode, test_common, parse_int, handle_restart,
do_subprocess, do_subprogram, do_multiple_tests): New functions.
(do_test): Add support_capture_subprogram tests.
* support/subprocess.h: New file.
* support/support_subprocess.c: Likewise.
* support/xposix_spawn.c: Likewise.
* support/xposix_spawn_file_actions_addclose.c: Likewise.
* support/xposix_spawn_file_actions_adddup2.c: Likewise.
* support/xspawn.h: Likewise.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2019-04-13 04:39:53 +08:00
|
|
|
xfclose_memstream (&result->out);
|
|
|
|
xfclose_memstream (&result->err);
|
|
|
|
|
|
|
|
result->status = support_process_wait (proc);
|
|
|
|
}
|
|
|
|
|
|
|
|
struct support_capture_subprocess
|
|
|
|
support_capture_subprocess (void (*callback) (void *), void *closure)
|
|
|
|
{
|
|
|
|
struct support_capture_subprocess result;
|
|
|
|
xopen_memstream (&result.out);
|
|
|
|
xopen_memstream (&result.err);
|
|
|
|
|
|
|
|
struct support_subprocess proc = support_subprocess (callback, closure);
|
|
|
|
|
|
|
|
support_capture_poll (&result, &proc);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct support_capture_subprocess
|
|
|
|
support_capture_subprogram (const char *file, char *const argv[])
|
|
|
|
{
|
|
|
|
struct support_capture_subprocess result;
|
|
|
|
xopen_memstream (&result.out);
|
|
|
|
xopen_memstream (&result.err);
|
|
|
|
|
|
|
|
struct support_subprocess proc = support_subprogram (file, argv);
|
|
|
|
|
|
|
|
support_capture_poll (&result, &proc);
|
2017-06-02 17:59:28 +08:00
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2021-04-09 23:25:45 +08:00
|
|
|
/* Copies the executable into a restricted directory, so that we can
|
|
|
|
safely make it SGID with the TARGET group ID. Then runs the
|
|
|
|
executable. */
|
|
|
|
static int
|
|
|
|
copy_and_spawn_sgid (char *child_id, gid_t gid)
|
|
|
|
{
|
|
|
|
char *dirname = xasprintf ("%s/tst-tunables-setuid.%jd",
|
|
|
|
test_dir, (intmax_t) getpid ());
|
|
|
|
char *execname = xasprintf ("%s/bin", dirname);
|
|
|
|
int infd = -1;
|
|
|
|
int outfd = -1;
|
|
|
|
int ret = 1, status = 1;
|
|
|
|
|
|
|
|
TEST_VERIFY (mkdir (dirname, 0700) == 0);
|
|
|
|
if (support_record_failure_is_failed ())
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
infd = open ("/proc/self/exe", O_RDONLY);
|
|
|
|
if (infd < 0)
|
|
|
|
FAIL_UNSUPPORTED ("unsupported: Cannot read binary from procfs\n");
|
|
|
|
|
|
|
|
outfd = open (execname, O_WRONLY | O_CREAT | O_EXCL, 0700);
|
|
|
|
TEST_VERIFY (outfd >= 0);
|
|
|
|
if (support_record_failure_is_failed ())
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
char buf[4096];
|
|
|
|
for (;;)
|
|
|
|
{
|
|
|
|
ssize_t rdcount = read (infd, buf, sizeof (buf));
|
|
|
|
TEST_VERIFY (rdcount >= 0);
|
|
|
|
if (support_record_failure_is_failed ())
|
|
|
|
goto err;
|
|
|
|
if (rdcount == 0)
|
|
|
|
break;
|
|
|
|
char *p = buf;
|
|
|
|
char *end = buf + rdcount;
|
|
|
|
while (p != end)
|
|
|
|
{
|
|
|
|
ssize_t wrcount = write (outfd, buf, end - p);
|
|
|
|
if (wrcount == 0)
|
|
|
|
errno = ENOSPC;
|
|
|
|
TEST_VERIFY (wrcount > 0);
|
|
|
|
if (support_record_failure_is_failed ())
|
|
|
|
goto err;
|
|
|
|
p += wrcount;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
TEST_VERIFY (fchown (outfd, getuid (), gid) == 0);
|
|
|
|
if (support_record_failure_is_failed ())
|
|
|
|
goto err;
|
|
|
|
TEST_VERIFY (fchmod (outfd, 02750) == 0);
|
|
|
|
if (support_record_failure_is_failed ())
|
|
|
|
goto err;
|
|
|
|
TEST_VERIFY (close (outfd) == 0);
|
|
|
|
if (support_record_failure_is_failed ())
|
|
|
|
goto err;
|
|
|
|
TEST_VERIFY (close (infd) == 0);
|
|
|
|
if (support_record_failure_is_failed ())
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
/* We have the binary, now spawn the subprocess. Avoid using
|
|
|
|
support_subprogram because we only want the program exit status, not the
|
|
|
|
contents. */
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
char * const args[] = {execname, child_id, NULL};
|
|
|
|
|
|
|
|
status = support_subprogram_wait (args[0], args);
|
|
|
|
|
|
|
|
err:
|
|
|
|
if (outfd >= 0)
|
|
|
|
close (outfd);
|
|
|
|
if (infd >= 0)
|
|
|
|
close (infd);
|
|
|
|
if (execname != NULL)
|
|
|
|
{
|
|
|
|
unlink (execname);
|
|
|
|
free (execname);
|
|
|
|
}
|
|
|
|
if (dirname != NULL)
|
|
|
|
{
|
|
|
|
rmdir (dirname);
|
|
|
|
free (dirname);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ret != 0)
|
|
|
|
FAIL_EXIT1("Failed to make sgid executable for test\n");
|
|
|
|
|
|
|
|
return status;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
support_capture_subprogram_self_sgid (char *child_id)
|
|
|
|
{
|
|
|
|
gid_t target = 0;
|
|
|
|
const int count = 64;
|
|
|
|
gid_t groups[count];
|
|
|
|
|
|
|
|
/* Get a GID which is not our current GID, but is present in the
|
|
|
|
supplementary group list. */
|
|
|
|
int ret = getgroups (count, groups);
|
|
|
|
if (ret < 0)
|
|
|
|
FAIL_UNSUPPORTED("Could not get group list for user %jd\n",
|
|
|
|
(intmax_t) getuid ());
|
|
|
|
|
|
|
|
gid_t current = getgid ();
|
|
|
|
for (int i = 0; i < ret; ++i)
|
|
|
|
{
|
|
|
|
if (groups[i] != current)
|
|
|
|
{
|
|
|
|
target = groups[i];
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (target == 0)
|
|
|
|
FAIL_UNSUPPORTED("Could not find a suitable GID for user %jd\n",
|
|
|
|
(intmax_t) getuid ());
|
|
|
|
|
|
|
|
return copy_and_spawn_sgid (child_id, target);
|
|
|
|
}
|
|
|
|
|
2017-06-02 17:59:28 +08:00
|
|
|
void
|
|
|
|
support_capture_subprocess_free (struct support_capture_subprocess *p)
|
|
|
|
{
|
|
|
|
free (p->out.buffer);
|
|
|
|
free (p->err.buffer);
|
|
|
|
}
|