glibc/stdlib/tst-strtod-nan-locale-main.c

90 lines
2.5 KiB
C
Raw Permalink Normal View History

Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
/* Test strtod functions work with all ASCII letters in NAN(...) in
Turkish locales (bug 19266).
Copyright (C) 2015-2022 Free Software Foundation, Inc.
Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
Prefer https to http for gnu.org and fsf.org URLs Also, change sources.redhat.com to sourceware.org. This patch was automatically generated by running the following shell script, which uses GNU sed, and which avoids modifying files imported from upstream: sed -ri ' s,(http|ftp)(://(.*\.)?(gnu|fsf|sourceware)\.org($|[^.]|\.[^a-z])),https\2,g s,(http|ftp)(://(.*\.)?)sources\.redhat\.com($|[^.]|\.[^a-z]),https\2sourceware.org\4,g ' \ $(find $(git ls-files) -prune -type f \ ! -name '*.po' \ ! -name 'ChangeLog*' \ ! -path COPYING ! -path COPYING.LIB \ ! -path manual/fdl-1.3.texi ! -path manual/lgpl-2.1.texi \ ! -path manual/texinfo.tex ! -path scripts/config.guess \ ! -path scripts/config.sub ! -path scripts/install-sh \ ! -path scripts/mkinstalldirs ! -path scripts/move-if-change \ ! -path INSTALL ! -path locale/programs/charmap-kw.h \ ! -path po/libc.pot ! -path sysdeps/gnu/errlist.c \ ! '(' -name configure \ -execdir test -f configure.ac -o -f configure.in ';' ')' \ ! '(' -name preconfigure \ -execdir test -f preconfigure.ac ';' ')' \ -print) and then by running 'make dist-prepare' to regenerate files built from the altered files, and then executing the following to cleanup: chmod a+x sysdeps/unix/sysv/linux/riscv/configure # Omit irrelevant whitespace and comment-only changes, # perhaps from a slightly-different Autoconf version. git checkout -f \ sysdeps/csky/configure \ sysdeps/hppa/configure \ sysdeps/riscv/configure \ sysdeps/unix/sysv/linux/csky/configure # Omit changes that caused a pre-commit check to fail like this: # remote: *** error: sysdeps/powerpc/powerpc64/ppc-mcount.S: trailing lines git checkout -f \ sysdeps/powerpc/powerpc64/ppc-mcount.S \ sysdeps/unix/sysv/linux/s390/s390-64/syscall.S # Omit change that caused a pre-commit check to fail like this: # remote: *** error: sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S: last line does not end in newline git checkout -f sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
2019-09-07 13:40:42 +08:00
<https://www.gnu.org/licenses/>. */
Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
#include <locale.h>
#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#include <wchar.h>
float128: Add strtof128, wcstof128, and related functions. The implementations are contained with sysdeps/ieee754/float128 as they are only built when _Float128 is enabled within libc/m. * include/gmp.h (__mpn_construct_float128): New declaration. * include/stdlib.h: Include bits/floatn.h for _Float128 tests. (__strtof128_l): New declaration. (__strtof128_nan): Likewise. (__wcstof128_nan): Likewise. (__strtof128_internal): Likewise. (____strtof128_l_internal): Likewise. * include/wchar.h: Include bits/floatn.h for _Float128 tests. (__wcstof128_l): New declaration. (__wcstof128_internal): Likewise. * stdlib/Makefile (bug-strtod2): Link libm too. * stdlib/stdlib.h (strtof128): New declaration. (strtof128_l): Likewise. * stdlib/tst-strtod-nan-locale-main.c: Updated to use tst-strtod.h macros to ensure float128 gets tested too. * stdlib/tst-strtod-round-skeleton.c (CHOOSE_f128): New macro. * stdlib/tst-strtod.h: Include bits/floatn.h for _Float128 tests. (IF_FLOAT128): New macro. (GEN_TEST_STRTOD): Update to optionally include _Float128 in the tests. (STRTOD_TEST_FOREACH): Likewise. * sysdeps/ieee754/float128/Makefile: Insert new strtof128 and wcstof128 functions into libc. * sysdeps/ieee754/float128/Versions: Add exports for the above new functions. * sysdeps/ieee754/float128/mpn2float128.c: New file. * sysdeps/ieee754/float128/strtod_nan_float128.h: New file. * sysdeps/ieee754/float128/strtof128.c: New file. * sysdeps/ieee754/float128/strtof128_l.c: New file. * sysdeps/ieee754/float128/strtof128_nan.c: New file. * sysdeps/ieee754/float128/wcstof128.c: New file. * sysdeps/ieee754/float128/wcstof128_l.c: New file. * sysdeps/ieee754/float128/wcstof128_nan.c: New fike. * wcsmbs/Makefile: (CFLAGS-wcstof128.c): Append strtox-CFLAGS. (CFLAGS-wcstof128_l): Likewise. * wcsmbs/wchar.h: Include bits/floatn.h for _Float128 tests. (wcstof128): New declaration. (wcstof128_l): Likewise.
2016-07-26 02:10:00 +08:00
#include <stdlib/tst-strtod.h>
Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
#define STR_(X) #X
#define STR(X) STR_(X)
#define FNPFXS STR (FNPFX)
#define CONCAT_(X, Y) X ## Y
#define CONCAT(X, Y) CONCAT_ (X, Y)
#define FNX(FN) CONCAT (FNPFX, FN)
float128: Add strtof128, wcstof128, and related functions. The implementations are contained with sysdeps/ieee754/float128 as they are only built when _Float128 is enabled within libc/m. * include/gmp.h (__mpn_construct_float128): New declaration. * include/stdlib.h: Include bits/floatn.h for _Float128 tests. (__strtof128_l): New declaration. (__strtof128_nan): Likewise. (__wcstof128_nan): Likewise. (__strtof128_internal): Likewise. (____strtof128_l_internal): Likewise. * include/wchar.h: Include bits/floatn.h for _Float128 tests. (__wcstof128_l): New declaration. (__wcstof128_internal): Likewise. * stdlib/Makefile (bug-strtod2): Link libm too. * stdlib/stdlib.h (strtof128): New declaration. (strtof128_l): Likewise. * stdlib/tst-strtod-nan-locale-main.c: Updated to use tst-strtod.h macros to ensure float128 gets tested too. * stdlib/tst-strtod-round-skeleton.c (CHOOSE_f128): New macro. * stdlib/tst-strtod.h: Include bits/floatn.h for _Float128 tests. (IF_FLOAT128): New macro. (GEN_TEST_STRTOD): Update to optionally include _Float128 in the tests. (STRTOD_TEST_FOREACH): Likewise. * sysdeps/ieee754/float128/Makefile: Insert new strtof128 and wcstof128 functions into libc. * sysdeps/ieee754/float128/Versions: Add exports for the above new functions. * sysdeps/ieee754/float128/mpn2float128.c: New file. * sysdeps/ieee754/float128/strtod_nan_float128.h: New file. * sysdeps/ieee754/float128/strtof128.c: New file. * sysdeps/ieee754/float128/strtof128_l.c: New file. * sysdeps/ieee754/float128/strtof128_nan.c: New file. * sysdeps/ieee754/float128/wcstof128.c: New file. * sysdeps/ieee754/float128/wcstof128_l.c: New file. * sysdeps/ieee754/float128/wcstof128_nan.c: New fike. * wcsmbs/Makefile: (CFLAGS-wcstof128.c): Append strtox-CFLAGS. (CFLAGS-wcstof128_l): Likewise. * wcsmbs/wchar.h: Include bits/floatn.h for _Float128 tests. (wcstof128): New declaration. (wcstof128_l): Likewise.
2016-07-26 02:10:00 +08:00
#define TEST_STRTOD(FSUF, FTYPE, FTOSTR, LSUF, CSUF) \
static int \
test_strto ## FSUF (const char * loc, CHAR * s) \
{ \
CHAR *ep; \
FTYPE val = FNX (FSUF) (s, &ep); \
if (isnan (val) && *ep == 0) \
printf ("PASS: %s: " FNPFXS #FSUF " (" SFMT ")\n", loc, s); \
else \
Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
{ \
float128: Add strtof128, wcstof128, and related functions. The implementations are contained with sysdeps/ieee754/float128 as they are only built when _Float128 is enabled within libc/m. * include/gmp.h (__mpn_construct_float128): New declaration. * include/stdlib.h: Include bits/floatn.h for _Float128 tests. (__strtof128_l): New declaration. (__strtof128_nan): Likewise. (__wcstof128_nan): Likewise. (__strtof128_internal): Likewise. (____strtof128_l_internal): Likewise. * include/wchar.h: Include bits/floatn.h for _Float128 tests. (__wcstof128_l): New declaration. (__wcstof128_internal): Likewise. * stdlib/Makefile (bug-strtod2): Link libm too. * stdlib/stdlib.h (strtof128): New declaration. (strtof128_l): Likewise. * stdlib/tst-strtod-nan-locale-main.c: Updated to use tst-strtod.h macros to ensure float128 gets tested too. * stdlib/tst-strtod-round-skeleton.c (CHOOSE_f128): New macro. * stdlib/tst-strtod.h: Include bits/floatn.h for _Float128 tests. (IF_FLOAT128): New macro. (GEN_TEST_STRTOD): Update to optionally include _Float128 in the tests. (STRTOD_TEST_FOREACH): Likewise. * sysdeps/ieee754/float128/Makefile: Insert new strtof128 and wcstof128 functions into libc. * sysdeps/ieee754/float128/Versions: Add exports for the above new functions. * sysdeps/ieee754/float128/mpn2float128.c: New file. * sysdeps/ieee754/float128/strtod_nan_float128.h: New file. * sysdeps/ieee754/float128/strtof128.c: New file. * sysdeps/ieee754/float128/strtof128_l.c: New file. * sysdeps/ieee754/float128/strtof128_nan.c: New file. * sysdeps/ieee754/float128/wcstof128.c: New file. * sysdeps/ieee754/float128/wcstof128_l.c: New file. * sysdeps/ieee754/float128/wcstof128_nan.c: New fike. * wcsmbs/Makefile: (CFLAGS-wcstof128.c): Append strtox-CFLAGS. (CFLAGS-wcstof128_l): Likewise. * wcsmbs/wchar.h: Include bits/floatn.h for _Float128 tests. (wcstof128): New declaration. (wcstof128_l): Likewise.
2016-07-26 02:10:00 +08:00
printf ("FAIL: %s: " FNPFXS #FSUF " (" SFMT ")\n", loc, s); \
return 1; \
Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
} \
float128: Add strtof128, wcstof128, and related functions. The implementations are contained with sysdeps/ieee754/float128 as they are only built when _Float128 is enabled within libc/m. * include/gmp.h (__mpn_construct_float128): New declaration. * include/stdlib.h: Include bits/floatn.h for _Float128 tests. (__strtof128_l): New declaration. (__strtof128_nan): Likewise. (__wcstof128_nan): Likewise. (__strtof128_internal): Likewise. (____strtof128_l_internal): Likewise. * include/wchar.h: Include bits/floatn.h for _Float128 tests. (__wcstof128_l): New declaration. (__wcstof128_internal): Likewise. * stdlib/Makefile (bug-strtod2): Link libm too. * stdlib/stdlib.h (strtof128): New declaration. (strtof128_l): Likewise. * stdlib/tst-strtod-nan-locale-main.c: Updated to use tst-strtod.h macros to ensure float128 gets tested too. * stdlib/tst-strtod-round-skeleton.c (CHOOSE_f128): New macro. * stdlib/tst-strtod.h: Include bits/floatn.h for _Float128 tests. (IF_FLOAT128): New macro. (GEN_TEST_STRTOD): Update to optionally include _Float128 in the tests. (STRTOD_TEST_FOREACH): Likewise. * sysdeps/ieee754/float128/Makefile: Insert new strtof128 and wcstof128 functions into libc. * sysdeps/ieee754/float128/Versions: Add exports for the above new functions. * sysdeps/ieee754/float128/mpn2float128.c: New file. * sysdeps/ieee754/float128/strtod_nan_float128.h: New file. * sysdeps/ieee754/float128/strtof128.c: New file. * sysdeps/ieee754/float128/strtof128_l.c: New file. * sysdeps/ieee754/float128/strtof128_nan.c: New file. * sysdeps/ieee754/float128/wcstof128.c: New file. * sysdeps/ieee754/float128/wcstof128_l.c: New file. * sysdeps/ieee754/float128/wcstof128_nan.c: New fike. * wcsmbs/Makefile: (CFLAGS-wcstof128.c): Append strtox-CFLAGS. (CFLAGS-wcstof128_l): Likewise. * wcsmbs/wchar.h: Include bits/floatn.h for _Float128 tests. (wcstof128): New declaration. (wcstof128_l): Likewise.
2016-07-26 02:10:00 +08:00
return 0; \
}
GEN_TEST_STRTOD_FOREACH (TEST_STRTOD)
Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
static int
test_one_locale (const char *loc)
{
if (setlocale (LC_ALL, loc) == NULL)
{
printf ("setlocale (LC_ALL, \"%s\") failed\n", loc);
return 1;
}
int result = 0;
for (int i = 10; i < 36; i++)
{
CHAR s[7];
s[0] = L_('N');
s[1] = L_('A');
s[2] = L_('N');
s[3] = L_('(');
s[4] = L_('A') + i - 10;
s[5] = L_(')');
s[6] = 0;
float128: Add strtof128, wcstof128, and related functions. The implementations are contained with sysdeps/ieee754/float128 as they are only built when _Float128 is enabled within libc/m. * include/gmp.h (__mpn_construct_float128): New declaration. * include/stdlib.h: Include bits/floatn.h for _Float128 tests. (__strtof128_l): New declaration. (__strtof128_nan): Likewise. (__wcstof128_nan): Likewise. (__strtof128_internal): Likewise. (____strtof128_l_internal): Likewise. * include/wchar.h: Include bits/floatn.h for _Float128 tests. (__wcstof128_l): New declaration. (__wcstof128_internal): Likewise. * stdlib/Makefile (bug-strtod2): Link libm too. * stdlib/stdlib.h (strtof128): New declaration. (strtof128_l): Likewise. * stdlib/tst-strtod-nan-locale-main.c: Updated to use tst-strtod.h macros to ensure float128 gets tested too. * stdlib/tst-strtod-round-skeleton.c (CHOOSE_f128): New macro. * stdlib/tst-strtod.h: Include bits/floatn.h for _Float128 tests. (IF_FLOAT128): New macro. (GEN_TEST_STRTOD): Update to optionally include _Float128 in the tests. (STRTOD_TEST_FOREACH): Likewise. * sysdeps/ieee754/float128/Makefile: Insert new strtof128 and wcstof128 functions into libc. * sysdeps/ieee754/float128/Versions: Add exports for the above new functions. * sysdeps/ieee754/float128/mpn2float128.c: New file. * sysdeps/ieee754/float128/strtod_nan_float128.h: New file. * sysdeps/ieee754/float128/strtof128.c: New file. * sysdeps/ieee754/float128/strtof128_l.c: New file. * sysdeps/ieee754/float128/strtof128_nan.c: New file. * sysdeps/ieee754/float128/wcstof128.c: New file. * sysdeps/ieee754/float128/wcstof128_l.c: New file. * sysdeps/ieee754/float128/wcstof128_nan.c: New fike. * wcsmbs/Makefile: (CFLAGS-wcstof128.c): Append strtox-CFLAGS. (CFLAGS-wcstof128_l): Likewise. * wcsmbs/wchar.h: Include bits/floatn.h for _Float128 tests. (wcstof128): New declaration. (wcstof128_l): Likewise.
2016-07-26 02:10:00 +08:00
result |= STRTOD_TEST_FOREACH (test_strto, loc, s);
Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
s[4] = L_('a') + i - 10;
float128: Add strtof128, wcstof128, and related functions. The implementations are contained with sysdeps/ieee754/float128 as they are only built when _Float128 is enabled within libc/m. * include/gmp.h (__mpn_construct_float128): New declaration. * include/stdlib.h: Include bits/floatn.h for _Float128 tests. (__strtof128_l): New declaration. (__strtof128_nan): Likewise. (__wcstof128_nan): Likewise. (__strtof128_internal): Likewise. (____strtof128_l_internal): Likewise. * include/wchar.h: Include bits/floatn.h for _Float128 tests. (__wcstof128_l): New declaration. (__wcstof128_internal): Likewise. * stdlib/Makefile (bug-strtod2): Link libm too. * stdlib/stdlib.h (strtof128): New declaration. (strtof128_l): Likewise. * stdlib/tst-strtod-nan-locale-main.c: Updated to use tst-strtod.h macros to ensure float128 gets tested too. * stdlib/tst-strtod-round-skeleton.c (CHOOSE_f128): New macro. * stdlib/tst-strtod.h: Include bits/floatn.h for _Float128 tests. (IF_FLOAT128): New macro. (GEN_TEST_STRTOD): Update to optionally include _Float128 in the tests. (STRTOD_TEST_FOREACH): Likewise. * sysdeps/ieee754/float128/Makefile: Insert new strtof128 and wcstof128 functions into libc. * sysdeps/ieee754/float128/Versions: Add exports for the above new functions. * sysdeps/ieee754/float128/mpn2float128.c: New file. * sysdeps/ieee754/float128/strtod_nan_float128.h: New file. * sysdeps/ieee754/float128/strtof128.c: New file. * sysdeps/ieee754/float128/strtof128_l.c: New file. * sysdeps/ieee754/float128/strtof128_nan.c: New file. * sysdeps/ieee754/float128/wcstof128.c: New file. * sysdeps/ieee754/float128/wcstof128_l.c: New file. * sysdeps/ieee754/float128/wcstof128_nan.c: New fike. * wcsmbs/Makefile: (CFLAGS-wcstof128.c): Append strtox-CFLAGS. (CFLAGS-wcstof128_l): Likewise. * wcsmbs/wchar.h: Include bits/floatn.h for _Float128 tests. (wcstof128): New declaration. (wcstof128_l): Likewise.
2016-07-26 02:10:00 +08:00
result |= STRTOD_TEST_FOREACH (test_strto, loc, s);
Fix strtod ("NAN(I)") in Turkish locales (bug 19266). The implementations of strtod and related functions use locale-specific conversions to lower case when parsing the contents of a string NAN(n-char-sequence_opt). This has the consequence that NAN(I) is not treated as being of that form (only the initial NAN part is accepted). The syntax of n-char-sequence directly maps to the ASCII letters, digits and underscore as in identifiers, so it is unambiguous that all ASCII letters must be accepted in all locales. This patch, relative to a tree with <https://sourceware.org/ml/libc-alpha/2015-11/msg00258.html> (pending review) applied and depending on that patch, fixes this problem by checking directly for ASCII letters. This will have the side effect of no longer accepting 'İ' (dotted 'I') inside NAN() in Turkish locales, which seems appropriate (that letter wouldn't have been interpreted as having any meaning in the NaN payload anyway, as not acceptable to strtoull). Tested for x86_64 and x86. [BZ #19266] * stdlib/strtod_l.c (____STRTOF_INTERNAL): Check directly for upper case and lower case letters inside NAN(), not using TOLOWER. * stdlib/tst-strtod-nan-locale-main.c: New file. * stdlib/tst-strtod-nan-locale.c: Likewise. * stdlib/Makefile (tests): Add tst-strtod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-strtod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-strtod-nan-locale): Depend on $(libm). * wcsmbs/tst-wcstod-nan-locale.c: New file. * wcsmbs/Makefile (tests): Add tst-wcstod-nan-locale. [$(run-built-tests) = yes] ($(objpfx)tst-wcstod-nan-locale.out): Depend on $(gen-locales). ($(objpfx)tst-wcstod-nan-locale): Depend on $(libm).
2015-11-25 06:21:59 +08:00
}
return result;
}
static int
do_test (void)
{
int result = 0;
result |= test_one_locale ("C");
result |= test_one_locale ("tr_TR.UTF-8");
result |= test_one_locale ("tr_TR.ISO-8859-9");
return result;
}
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"