mirror of
git://gcc.gnu.org/git/gcc.git
synced 2025-04-06 10:50:52 +08:00
c981619632
In the P1771R1 changes JeanHeyd reverted part of Alex' PR88146 fix, but that seems to be incorrect to me. Where P1771R1 suggests warnings for [[nodiscard]] on constructors is handled in a different place - in particular the TARGET_EXPR handling of convert_to_void. When we have CALL_EXPR of a ctor, on most arches that call has void return type and so returns early, and on arm where the ctor returns the this pointer it is undesirable to warn as it warns about all ctor calls, not just the ones where it should warn. The P1771R1 changes added a test for this, but as it was given *.c extension rather than *.C, the test was never run and so this didn't get spotted immediately. The test also had a bug, (?n) can't be used in dg-warning/dg-error because those are implemented by prepending some regexp before the user provided one and (?n) must come at the start of the regexp. Furthermore, while -ftrack-macro-expansion=0 is useful in one nodiscard test which uses macros, I don't see how it would be relevant to all the other cpp2a/nodiscard* tests which don't use any macros. 2021-03-04 Jakub Jelinek <jakub@redhat.com> PR c++/88146 PR c++/99362 gcc/cp/ * cvt.c (convert_to_void): Revert 2019-10-17 changes. Clarify comment. gcc/testsuite/ * g++.dg/cpp2a/nodiscard-constructor.c: Renamed to ... * g++.dg/cpp2a/nodiscard-constructor1.C: ... this. Remove -ftrack-macro-expansion=0 from dg-options. Don't use (?n) in dg-warning regexps, instead replace .* with \[^\n\r]*. * g++.dg/cpp2a/nodiscard-constructor2.C: New test. * g++.dg/cpp2a/nodiscard-reason-only-one.C: Remove -ftrack-macro-expansion=0 from dg-options. * g++.dg/cpp2a/nodiscard-reason-nonstring.C: Likewise. * g++.dg/cpp2a/nodiscard-once.C: Likewise.
This directory contains the GNU Compiler Collection (GCC). The GNU Compiler Collection is free software. See the files whose names start with COPYING for copying permission. The manuals, and some of the runtime libraries, are under different terms; see the individual source files for details. The directory INSTALL contains copies of the installation information as HTML and plain text. The source of this information is gcc/doc/install.texi. The installation information includes details of what is included in the GCC sources and what files GCC installs. See the file gcc/doc/gcc.texi (together with other files that it includes) for usage and porting information. An online readable version of the manual is in the files gcc/doc/gcc.info*. See http://gcc.gnu.org/bugs/ for how to report bugs usefully. Copyright years on GCC source files may be listed using range notation, e.g., 1987-2012, indicating that every year in the range, inclusive, is a copyrightable year that could otherwise be listed individually.