gcc/gcc/range.h
Aldy Hernandez d32969898e [PR tree-optimization/107312] Make range_true_and_false work with 1-bit signed types.
range_true_and_false() returns a range of [0,1], which for a 1-bit
signed integer gets passed to the irange setter as [0, -1].  These
endpoints are out of order and cause an ICE.  Through some dumb luck,
the legacy code swaps out of order endpoints, because old VRP would
sometimes pass endpoints reversed, depending on the setter to fix
them.  This swapping does not happen for non-legacy, hence the ICE.

The right thing to do (apart from killing legacy and 1-bit signed
integers ;-)), is to avoid passing out of order endpoints for 1-bit
signed integers.  For that matter, a range of [-1, 0] (signed) or
[0, 1] (unsigned) is just varying.

	PR tree-optimization/107312

gcc/ChangeLog:

	* range.h (range_true_and_false): Special case 1-bit signed types.
	* value-range.cc (range_tests_misc): New test.

gcc/testsuite/ChangeLog:

	* gcc.target/i386/pr107312.c: New test.
2022-10-19 16:00:48 +02:00

59 lines
1.7 KiB
C++

/* Header file for misc range functions. -*- C++ -*-
Copyright (C) 2017-2022 Free Software Foundation, Inc.
Contributed by Aldy Hernandez <aldyh@redhat.com>.
This file is part of GCC.
GCC is free software; you can redistribute it and/or modify it under
the terms of the GNU General Public License as published by the Free
Software Foundation; either version 3, or (at your option) any later
version.
GCC is distributed in the hope that it will be useful, but WITHOUT ANY
WARRANTY; without even the implied warranty of MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
for more details.
You should have received a copy of the GNU General Public License
along with GCC; see the file COPYING3. If not see
<http://www.gnu.org/licenses/>. */
#ifndef GCC_RANGE_H
#define GCC_RANGE_H
value_range range_zero (tree type);
value_range range_nonzero (tree type);
value_range range_positives (tree type);
value_range range_negatives (tree type);
// Return an irange instance that is a boolean TRUE.
static inline int_range<1>
range_true (tree type)
{
unsigned prec = TYPE_PRECISION (type);
return int_range<2> (type, wi::one (prec), wi::one (prec));
}
// Return an irange instance that is a boolean FALSE.
static inline int_range<1>
range_false (tree type)
{
unsigned prec = TYPE_PRECISION (type);
return int_range<2> (type, wi::zero (prec), wi::zero (prec));
}
// Return an irange that covers both true and false.
static inline int_range<1>
range_true_and_false (tree type)
{
unsigned prec = TYPE_PRECISION (type);
if (prec == 1)
return int_range<2> (type);
return int_range<2> (type, wi::zero (prec), wi::one (prec));
}
#endif // GCC_RANGE_H