mirror of
git://gcc.gnu.org/git/gcc.git
synced 2025-03-24 04:20:27 +08:00
2523d721cf
this patch fixes wrong code on a testcase where inline predicts builtin_constant_p to be true but we fail to optimize its parameter to constant becuase FRE is not run and the value is passed by an aggregate. This patch makes the inline predicates to disable aggregate tracking when FRE is not going to be run and similarly value range when VRP is not going to be run. This is just partial fix. Even with it we can arrange FRE/VRP to fail and produce wrong code, unforutnately. I think for GCC11 I will need to implement transformation in ipa-inline but this is bit hard to do: predicates only tracks that value will be constant and do not track what constant to be. Optimizing builtin_constant_p in a conditional is not going to do good job when the value is used later in a place that expects it to be constant. This is pre-existing problem that is not limited to inline tracking. For example, FRE may do the transofrm at one place but not in another due to alias oracle walking limits. So I am not sure what full fix would be :( gcc/ChangeLog: 2020-04-04 Jan Hubicka <hubicka@ucw.cz> PR ipa/93940 * ipa-fnsummary.c (vrp_will_run_p): New function. (fre_will_run_p): New function. (evaluate_properties_for_edge): Use it. * ipa-inline.c (can_inline_edge_by_limits_p): Do not inline !optimize_debug to optimize_debug. gcc/testsuite/ChangeLog: 2020-04-04 Jan Hubicka <hubicka@ucw.cz> * g++.dg/tree-ssa/pr93940.C: New test.
This directory contains the GNU Compiler Collection (GCC). The GNU Compiler Collection is free software. See the files whose names start with COPYING for copying permission. The manuals, and some of the runtime libraries, are under different terms; see the individual source files for details. The directory INSTALL contains copies of the installation information as HTML and plain text. The source of this information is gcc/doc/install.texi. The installation information includes details of what is included in the GCC sources and what files GCC installs. See the file gcc/doc/gcc.texi (together with other files that it includes) for usage and porting information. An online readable version of the manual is in the files gcc/doc/gcc.info*. See http://gcc.gnu.org/bugs/ for how to report bugs usefully. Copyright years on GCC source files may be listed using range notation, e.g., 1987-2012, indicating that every year in the range, inclusive, is a copyrightable year that could otherwise be listed individually.