197411 Commits

Author SHA1 Message Date
Andrew Pinski
5c11d74856 tree-optimization/107956 - ICE with NULL call LHS
The following adds a missing check for a NULL call LHS in the
vector pattern recognizer.

	PR tree-optimization/107956
	* tree-vect-patterns.cc (vect_recog_mask_conversion_pattern):
	Check for NULL LHS on masked loads.
2022-12-05 09:11:33 +01:00
Kewen Lin
380d62c14c gimple-fold: Refine gimple_fold_partial_load_store_mem_ref [PR107412]
Following Richard's review comments, this patch is to use
untruncated type for the length used for IFN_LEN_{LOAD,STORE}
instead of "unsigned int" for better robustness.  It also
avoid to use to_constant and tree arithmetic for subtraction.

Co-authored-by: Richard Sandiford  <richard.sandiford@arm.com>

	PR tree-optimization/107412

gcc/ChangeLog:

	* gimple-fold.cc (gimple_fold_partial_load_store_mem_ref): Use
	untruncated type for the length, and avoid to_constant and tree
	arithmetic for subtraction.
2022-12-04 23:27:08 -06:00
GCC Administrator
102f3cef56 Daily bump. 2022-12-05 00:17:24 +00:00
Harald Anlauf
24b9337d1f Fortran: error recovery simplifying UNPACK for insufficient FIELD [PR107922]
gcc/fortran/ChangeLog:

	PR fortran/107922
	* simplify.cc (gfc_simplify_unpack): Terminate simplification when
	array-valued argument FIELD does not provide enough elements.

gcc/testsuite/ChangeLog:

	PR fortran/107922
	* gfortran.dg/unpack_field_1.f90: New test.
2022-12-04 20:59:03 +01:00
Harald Anlauf
98d6e4b6f1 Fortran: fix typo in documentation of intrinsic FLOOR [PR107870]
gcc/fortran/ChangeLog:

	PR fortran/107870
	* intrinsic.texi: Fix typo in documentation of intrinsic FLOOR.
	Describe the optional KIND argument to intrinsics as a scalar
	constant expression, in accordance with the current standard.
2022-12-04 20:27:34 +01:00
Harald Anlauf
9123863828 Fortran: error recovery handling invalid CLASS variable [PR107899]
gcc/fortran/ChangeLog:

	PR fortran/107899
	* resolve.cc (resolve_deallocate_expr): Avoid NULL pointer dereference
	on invalid CLASS variable.

gcc/testsuite/ChangeLog:

	PR fortran/107899
	* gfortran.dg/pr107899.f90: New test.
2022-12-04 20:27:34 +01:00
Patrick Palka
079add3ad3 c++: pack in requires-expr parm list [PR107417]
Here find_parameter_packs_r isn't detecting the pack T inside the
requires-expr's parameter list ultimately because cp_walk_trees
deliberately avoids walking the list so as to avoid false positives in
the unexpanded pack checker.

But it should still be fine to walk the TREE_TYPE of each parameter,
which we already need to do from for_each_template_parm_r, and is
sufficient to fix the testcase.

	PR c++/107417

gcc/cp/ChangeLog:

	* pt.cc (for_each_template_parm_r) <case REQUIRES_EXPR>: Move
	walking of the TREE_TYPE of each parameter to ...
	* tree.cc (cp_walk_subtrees) <case REQUIRES_EXPR>: ... here.

gcc/testsuite/ChangeLog:

	* g++.dg/cpp2a/concepts-requires33.C: New test.
2022-12-04 10:47:24 -05:00
Iain Sandoe
a044c9d259 libstdc++, Darwin: Limit recursive mutex init to OS versions needing it.
The problem described in pr 51906 was fixed in the next OS release.  Limit the
workaround to systems that need it.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

libstdc++-v3/ChangeLog:

	* config/os/bsd/darwin/os_defines.h
	(_GTHREAD_USE_RECURSIVE_MUTEX_INIT_FUNC): Limit use of this macro
	to OS versions that need it.
2022-12-04 14:55:07 +00:00
Iain Sandoe
e76a44bf68 libstdc++, Darwin: Fix weak attribute to use __weak__ instead of weak.
The text for _GLIBCXX_WEAK_DEFINITION has used 'weak' for the attribute name,
since its intoduction.  Amend to use the implementation namespace '__weak__'
version.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

libstdc++-v3/ChangeLog:

	* config/os/bsd/darwin/os_defines.h (_GLIBCXX_WEAK_DEFINITION): Use the
	implementation namespace for the weak attribute.
2022-12-04 10:48:48 +00:00
Iain Sandoe
7fe8aca8a6 libsanitizer, Darwin: Restrict build to Darwin 16 or newer.
The latest import has added dependencies on system resources that are not
present until Darwin 16.  It might be possible to work around these for
earlier systems, but in the short-term we have to disable the build so that
bootstrap completes.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

libsanitizer/ChangeLog:

	* configure.tgt: Restrict build to Darwin 16 or newer.
2022-12-04 10:41:53 +00:00
Iain Sandoe
58a7b1e354 coroutines: Do not promote temporaries that will be elided.
We usually need to 'promote' (i.e. save to the coroutine frame) any temporary
variable that is in a target expression that must persist across an await
expression.  However, if the TE is just used as a direct initializer for
another object it will be elided - and we should not promote it since that
would lead to a DTOR call for something that is never constructed.

Since we now have a mechanism to tell if TEs will be elided, use that.

Although the PRs referenced initially appear to be different issues, they all
stem from this.

Co-Authored-By: Adrian Perl <adrian.perl@web.de>
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

	PR c++/100611
	PR c++/101367
	PR c++/101976
	PR c++/99576

gcc/cp/ChangeLog:

	* coroutines.cc (find_interesting_subtree): Do not promote temporaries
	that are only used as direct initializers for some other object.

gcc/testsuite/ChangeLog:

	* g++.dg/coroutines/pr100611.C: New test.
	* g++.dg/coroutines/pr101367.C: New test.
	* g++.dg/coroutines/pr101976.C: New test.
	* g++.dg/coroutines/pr99576_1.C: New test.
	* g++.dg/coroutines/pr99576_2.C: New test.
2022-12-04 10:39:36 +00:00
GCC Administrator
8c45e67ac6 Daily bump. 2022-12-04 00:17:06 +00:00
Patrick Palka
b3912122c9 c++: substituting CONST_DECL_USING_P enumerators [PR103081]
We implement class-scope using enum by injecting clones of the enum's
CONST_DECLs as fields of the class, for which CONST_DECL_USING_P is
true, so that qualified lookup naturally finds the enumerators.
Substitution into such a CONST_DECL currently ICEs however, because we
assume the DECL_CONTEXT is always the ENUMERAL_TYPE (which has
TYPE_VALUES) but in this case it's the RECORD_TYPE for the class scope
(which has TYPE_FIELDS).

Since these CONST_DECLs appear to always be non-dependent, this patch
fixes this by shortcutting substitution for CONST_DECLs that have
non-dependent DECL_CONTEXT.  This subsumes the existing (and seemingly
dead) DECL_NAMESPACE_SCOPE_P early exit test and also benefits
substitution into ordinary non-dependent CONST_DECLs.

	PR c++/103081

gcc/cp/ChangeLog:

	* pt.cc (tsubst_copy) <case CONST_DECL>: Generalize
	early exit test for namespace-scope decls to check dependence of
	the enclosing scope instead.  Remove dead early exit test.

gcc/testsuite/ChangeLog:

	* g++.dg/cpp2a/using-enum-10.C: New test.
	* g++.dg/cpp2a/using-enum-10a.C: New test.
2022-12-03 10:28:25 -05:00
Alexandre Oliva
93574914e4 [testsuite] [riscv] skip ssa-sink-18.c
On riscv64, despite being lp64, we choose two IV candidates as on arm,
which prevents some of the expected sinking.  Add an xfail for it.


for  gcc/testsuite/ChangeLog

	* gcc.dg/tree-ssa/ssa-sink-18.c: xfail sink2 on riscv64.
2022-12-02 21:55:25 -03:00
Alexandre Oliva
cebd317578 [testsuite] [riscv] uninit-pred-9_b bogus warning
Like other platforms, riscv hits the uninitialized warning because the
optimizations don't eliminate the nonviable path that would enable it
to be omitted.


for  gcc/testsuite/ChangeLog

	* gcc.dg/uninit-pred-9_b.c: Add riscv*-*-* to the xfail list
	for the bogus warning.
2022-12-02 21:55:24 -03:00
GCC Administrator
596dbfff88 Daily bump. 2022-12-03 00:17:18 +00:00
Harald Anlauf
36a4ee406b Fortran: intrinsic MERGE shall use all its arguments [PR107874]
gcc/testsuite/ChangeLog:

	PR fortran/107874
	* gfortran.dg/merge_1.f90: Avoid recursive I/O.
2022-12-02 22:34:38 +01:00
David Malcolm
e24fe1283c analyzer: introduce struct event_loc_info
gcc/analyzer/ChangeLog:
	* analyzer.h (struct event_loc_info): New forward decl.
	* bounds-checking.cc: Use event_loc_info throughout to bundle the
	loc, fndecl, depth triples.
	* call-info.cc: Likewise.
	* checker-event.cc: Likewise.
	* checker-event.h (struct event_loc_info): New decl.  Use it
	throughout to bundle the loc, fndecl, depth triples.
	* checker-path.cc: Likewise.
	* checker-path.h: Likewise.
	* diagnostic-manager.cc: Likewise.
	* engine.cc: Likewise.
	* infinite-recursion.cc: Likewise.
	* pending-diagnostic.cc: Likewise.
	* pending-diagnostic.h: Likewise.
	* region-model.cc: Likewise.
	* sm-signal.cc: Likewise.
	* varargs.cc: Likewise.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
2022-12-02 16:30:52 -05:00
David Malcolm
f5758fe5b4 analyzer: fixes to region creation messages [PR107851]
In r13-2573-gc81b60b8c6ff3d I split up the analyzer's region-creation
events to describe the memory space and capacity of the region as two
separate events to avoid combinatorial explosion of message wordings.

However I didn't take into account r13-1405-ge6c3bb379f515b which
added a pending_diagnostic::describe_region_creation_event vfunc which
could change the wording of region creation events.

Hence for:

#include <stdlib.h>
#include <stdint.h>

void test ()
{
  int32_t *ptr = malloc (1);
  free (ptr);
}

trunk currently emits:

  Compiler Explorer (x86_64 trunk): https://godbolt.org/z/e3Td7c9s5:

<source>: In function 'test':
<source>:6:18: warning: allocated buffer size is not a multiple of the pointee's size [CWE-131] [-Wanalyzer-allocation-size]
    6 |   int32_t *ptr = malloc (1);
      |                  ^~~~~~~~~~
  'test': events 1-3
    |
    |    6 |   int32_t *ptr = malloc (1);
    |      |                  ^~~~~~~~~~
    |      |                  |
    |      |                  (1) allocated 1 bytes here
    |      |                  (2) allocated 1 bytes here
    |      |                  (3) assigned to 'int32_t *' {aka 'int *'} here; 'sizeof (int32_t {aka int})' is '4'
    |

where events (1) and (2) are different region_creation_events that have
had their wording overridden (also, with a "1 bytes" issue).

This patch reorganizes region creation events so that each
pending_diagnostic instead creates the events that is appropriate for it,
and the events have responsibility for their own wording.

With this patch, the above emits:

<source>: In function 'test':
<source>:6:18: warning: allocated buffer size is not a multiple of the pointee's size [CWE-131] [-Wanalyzer-allocation-size]
    6 |   int32_t *ptr = malloc (1);
      |                  ^~~~~~~~~~
  'test': events 1-2
    |
    |    6 |   int32_t *ptr = malloc (1);
    |      |                  ^~~~~~~~~~
    |      |                  |
    |      |                  (1) allocated 1 byte here
    |      |                  (2) assigned to 'int32_t *' {aka 'int *'} here; 'sizeof (int32_t {aka int})' is '4'
    |

fixing the duplicate event, and fixing the singular/plural issue.

gcc/analyzer/ChangeLog:
	PR analyzer/107851
	* analyzer.cc (make_label_text_n): Convert param "n" from int to
	unsigned HOST_WIDE_INT.
	* analyzer.h (make_label_text_n): Likewise for decl.
	* bounds-checking.cc: Include "analyzer/checker-event.h" and
	"analyzer/checker-path.h".
	(out_of_bounds::add_region_creation_events): New.
	(concrete_past_the_end::describe_region_creation_event): Replace
	with...
	(concrete_past_the_end::add_region_creation_events): ...this.
	(symbolic_past_the_end::describe_region_creation_event): Delete.
	* checker-event.cc (region_creation_event::region_creation_event):
	Update for dropping all member data.
	(region_creation_event::get_desc): Delete, splitting out into
	region_creation_event_memory_space::get_desc,
	region_creation_event_capacity::get_desc, and
	region_creation_event_debug::get_desc.
	(region_creation_event_memory_space::get_desc): New.
	(region_creation_event_capacity::get_desc): New.
	(region_creation_event_allocation_size::get_desc): New.
	(region_creation_event_debug::get_desc): New.
	* checker-event.h: Include "analyzer/program-state.h".
	(enum rce_kind): Delete.
	(class region_creation_event): Drop all member data.
	(region_creation_event::region_creation_event): Make protected.
	(region_creation_event::get_desc): Delete.
	(class region_creation_event_memory_space): New.
	(class region_creation_event_capacity): New.
	(class region_creation_event_allocation_size): New.
	(class region_creation_event_debug): New.
	* checker-path.cc (checker_path::add_region_creation_events): Add
	"pd" param.  Call pending_diangnostic::add_region_creation_events.
	Update for conversion of RCE_DEBUG to region_creation_event_debug.
	* checker-path.h (checker_path::add_region_creation_events): Add
	"pd" param.
	* diagnostic-manager.cc (diagnostic_manager::build_emission_path):
	Pass pending_diagnostic to
	emission_path::add_region_creation_events.
	(diagnostic_manager::build_emission_path): Pass path_builder to
	add_event_on_final_node.
	(diagnostic_manager::add_event_on_final_node): Add "pb" param.
	Pass pending_diagnostic to
	emission_path::add_region_creation_events.
	(diagnostic_manager::add_events_for_eedge): Pass
	pending_diagnostic to emission_path::add_region_creation_events.
	* diagnostic-manager.h
	(diagnostic_manager::add_event_on_final_node): Add "pb" param.
	* pending-diagnostic.cc
	(pending_diagnostic::add_region_creation_events): New.
	* pending-diagnostic.h (struct region_creation): Delete.
	(pending_diagnostic::describe_region_creation_event): Delete.
	(pending_diagnostic::add_region_creation_events): New vfunc.
	* region-model.cc: Include "analyzer/checker-event.h" and
	"analyzer/checker-path.h".
	(dubious_allocation_size::dubious_allocation_size): Initialize
	m_has_allocation_event.
	(dubious_allocation_size::describe_region_creation_event): Delete.
	(dubious_allocation_size::describe_final_event): Update for
	replacement of m_allocation_event with m_has_allocation_event.
	(dubious_allocation_size::add_region_creation_events): New.
	(dubious_allocation_size::m_allocation_event): Replace with...
	(dubious_allocation_size::m_has_allocation_event): ...this.

gcc/testsuite/ChangeLog:
	PR analyzer/107851
	* gcc.dg/analyzer/allocation-size-4.c: Update expected wording.
	* gcc.dg/analyzer/allocation-size-multiline-1.c: New test.
	* gcc.dg/analyzer/allocation-size-multiline-2.c: New test.
	* gcc.dg/analyzer/out-of-bounds-multiline-1.c: Update expected
	wording.
	* gcc.dg/analyzer/out-of-bounds-multiline-2.c: New test.
	* gcc.dg/analyzer/out-of-bounds-read-char-arr.c: Update expected
	wording.
	* gcc.dg/analyzer/out-of-bounds-read-int-arr.c: Likewise.
	* gcc.dg/analyzer/out-of-bounds-write-char-arr.c: Likewise.
	* gcc.dg/analyzer/out-of-bounds-write-int-arr.c: Likewise.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
2022-12-02 16:30:51 -05:00
Marek Polacek
1998db0fa1 testsuite: Adjust dg-error for -fimplicit-constexpr
Some of the new tests were failing with -fimplicit-constexpr.  This
patch adjusts the expected diagnostic.  Tested with

GXX_TESTSUITE_STDS=98,11,14,17,20,23 make check-c++ RUNTESTFLAGS="--target_board=unix\{,-fimplicit-constexpr\} dg.exp=spaceship-eq3.C"

gcc/testsuite/ChangeLog:

	* g++.dg/cpp0x/constexpr-ex1.C: Adjust dg-error.
	* g++.dg/cpp23/constexpr-nonlit10.C: Adjust dg-warning.
	* g++.dg/cpp23/constexpr-nonlit11.C: Likewise.
	* g++.dg/cpp2a/spaceship-eq3.C: Add dg-error.
2022-12-02 14:47:45 -05:00
Bernhard Reutner-Fischer
d19aa6af66 c++: Set the locus of the function result decl
gcc/cp/ChangeLog:

	* decl.cc (grokdeclarator): Build RESULT_DECL.
	(start_preparsed_function): Copy location from template.
	* semantics.cc (apply_deduced_return_type): Handle
	arg != current_function_decl.
	* method.cc (implicitly_declare_fn): Use it.

gcc/ChangeLog:

	* function.cc (init_function_start): Use DECL_RESULT location
	for -Waggregate-return warning.

gcc/testsuite/ChangeLog:

	* g++.dg/diagnostic/return-type-loc1.C: New test.

Co-authored-by: Jason Merrill <jason@redhat.com>
2022-12-02 14:17:53 -05:00
Andrew MacLeod
76dd48f895 Fix a few incorrect accesses.
This consists of 3 changes which stronger type checking has indicated
are incorrect.

	gcc/
	* fold-const.cc (fold_unary_loc): Check TREE_TYPE of node.
	(tree_invalid_nonnegative_warnv_p): Likewise.

	gcc/c-family/
	* c-attribs.cc (handle_deprecated_attribute): Use type when
	using TYPE_NAME.
2022-12-02 11:50:05 -05:00
Jason Merrill
6d3c634c8b driver: fix validate_switches logic
Under the old logic for validate_switches, once suffix or starred got set,
they stayed set for all later switches found in the spec.  So for e.g.

%{g*:%{%:debug-level-gt(0):

Once we see g*, starred is set.  Then we see %:, and it sees that as a
zero-length switch, which because starred is still set, matches any and all
command-line options.  So targets that use such a spec accept all options in
the driver, while ones that don't reject some, such as the recent
-nostdlib++.

This patch fixes the inconsistency, so all targets would complain about
-nostdlib++, and then sets SKIPOPT for it so they don't.

gcc/ChangeLog:

	* gcc.cc (validate_switches): Reset suffix/starred on loop.

gcc/cp/ChangeLog:

	* g++spec.cc (lang_specific_driver): Set SKIPOPT for nostdlib++.
2022-12-02 10:38:32 -05:00
Vladimir N. Makarov
70596a0fb2 LRA: Check hard reg availability of pseudo and its subreg for pseudo reload
Do not reload subreg pseudo if there are hard regs for subreg mode
but there are no hard regs for pseudo mode.

        PR target/106462

gcc/ChangeLog:

	* lra-constraints.cc (curr_insn_transform): Check available hard
	regs for pseudo and its subreg to decide what to reload.

gcc/testsuite/ChangeLog:

	* gcc.target/mips/pr106462.c: New test.
2022-12-02 08:24:03 -05:00
liuhongt
e55251f3d3 Improve ix86_expand_fast_convert_bf_to_sf with new extendbfsf2_1.
After supporting extendbfsf2_1, ix86_expand_fast_convert_bf_to_sf can
be improved with pslld either.
CONST_INT_P is not handled since constant shift can be optimized off.

gcc/ChangeLog:

	* config/i386/i386-expand.cc
	(ix86_expand_fast_convert_bf_to_sf): Use extendbfsf2_1 for
	nonimmediate operand.

gcc/testsuite/ChangeLog:

	* gcc.target/i386/cbranchbf4.c: New test.
2022-12-02 20:30:22 +08:00
Martin Liska
71e800747e gcc: regenerate configure
gcc/ChangeLog:

	* configure: Regenerate.
2022-12-02 12:38:57 +01:00
GCC Administrator
b35680ec3d Daily bump. 2022-12-02 11:25:05 +00:00
Jakub Jelinek
b3237a2c68 i386: Save/restore recog_data in ix86_vector_duplicate_value [PR106577]
On Tue, Aug 16, 2022 at 09:14:06AM +0100, Richard Sandiford via Gcc-patches wrote:
> IMO the correct low-effort fix is to save and restore recog_data
> in ix86_vector_duplicate_value.  It's a relatively big copy,
> but the current code is pretty wasteful anyway (allocating at
> least a new SET and INSN for every query).  Compared to the
> overhead of doing that, a copy to and from the stack shouldn't
> be too bad.

The following patch does that.
It isn't the first spot in the compiler that does that, not even the first
spot in the i386 backend.
In i386-expand.cc beyond these 2 recog_memoized calls there is one in
expand_vselect, but I think it is unlikely we'd run into these issues trying
to expand new permutations from splitters.

2022-12-02  Jakub Jelinek  <jakub@redhat.com>

	PR target/106577
	* config/i386/i386-expand.cc (ix86_vector_duplicate_value): Save/restore
	recog_data around recog_memoized calls.

	* gcc.target/i386/pr106577.c: New test.
2022-12-02 11:08:45 +01:00
Jakub Jelinek
f133055185 c++: Incremental fix for g++.dg/gomp/for-21.C [PR84469]
The PR84469 patch I've just posted regresses the for-21.C testcase,
when in OpenMP loop there are at least 2 associated loops and
in a template outer structured binding with non type dependent expression
is used in the expressions of some inner loop, we don't diagnose those
any longer, as the (weirdly worded) diagnostics was only done during
finish_id_expression -> mark_used which for the inner loop expressions
happens before the structured bindings are finalized.  When in templates,
mark_used doesn't diagnose uses of non-deduced variables, and if the
range for expression is type dependent, it is similarly diagnosed during
instantiation.  But newly with the PR84469 fix if the range for expression
is not type dependent, there is no place that would diagnose it, as during
instantiation the structured bindings are already deduced.

This patch ensures that the bug of using structured bindings from one
associated loop in other associated loops is diagnosed by the
c_omp_check_loop_iv code by ensuring that cp_finish_decomp is called
already during cp_convert_omp_range_for if the artificial iterator
has been successfully auto-deduced.

2022-12-02  Jakub Jelinek  <jakub@redhat.com>

	PR c++/84469
gcc/c-family/
	* c-omp.cc (c_omp_is_loop_iterator): For range for with structured
	binding return TREE_VEC_LENGTH (d->declv) even if decl is equal
	to any of the structured binding decls.
gcc/cp/
	* parser.cc (cp_convert_omp_range_for): After do_auto_deduction if
	!processing_template_decl call cp_finish_decomp with
	processing_template_decl temporarily incremented.
gcc/testsuite/
	* g++.dg/gomp/for-21.C (f3, f6, f9): Adjust expected diagnostics.
	* g++.dg/gomp/for-22.C: New test.
2022-12-02 10:30:16 +01:00
Jakub Jelinek
ee4f25999f c++: Deduce range for structured bindings if expression is not type dependent [PR84469]
As shown on the decomp56.C testcase, if the range for expression
when using structured bindings is not type dependent, we deduce
the finish the structured binding types only when not in template
(cp_convert_range_for takes care of that), but if in templates,
do_range_for_auto_deduction is called instead and it doesn't handle
structured bindings.  During instantiation they are handled later,
but during the parsing keeping the structured bindings type
dependent when they shouldn't be changes behavior.
The following patch calls cp_finish_decomp even from
do_range_for_auto_deduction.
The patch regresses the OpenMP g++.dg/gomp/for-21.C test (3 errors
are gone), I'll post an incremental patch for it momentarily.

2022-12-02  Jakub Jelinek  <jakub@redhat.com>

	PR c++/84469
	* parser.cc (do_range_for_auto_deduction): Add DECOMP_FIRST_NAME
	and DECOMP_CNT arguments.  Call cp_finish_decomp if DECL
	is a structured binding.
	(cp_parser_range_for): Adjust do_range_for_auto_deduction caller.
	(cp_convert_omp_range_for): Likewise.

	* g++.dg/cpp1z/decomp56.C: New test.
	* g++.dg/gomp/pr84469.C: New test.
2022-12-02 10:29:11 +01:00
Michael Collison
6508d5e5a1 match.pd: rewrite select to branchless expression
This patches transforms ((x & 0x1) == 0) ? y : z <op> y -into
(-(typeof(y))(x & 0x1) & z) <op> y, where op is a '^' or a '|'. It also
transforms (cond (and (x , 0x1) != 0), (z op y), y ) into (-(and (x ,
0x1)) & z ) op y.

Matching this patterns allows GCC to generate branchless code for one of
the functions in coremark.

	* match.pd ((x & 0x1) == 0) ? y : z <op> y
	-> (-(typeof(y))(x & 0x1) & z) <op> y.

	* gcc.dg/tree-ssa/branchless-cond.c: New test.
2022-12-02 09:22:01 +01:00
Richard Biener
5b50850c3c Add --param max-unswitch-depth
The following adds a --param to limit the depth of unswitched loop
nests.  One can use --param max-unswitch-depth=1 to disable unswitching
of outer loops (the innermost loop will then be unswitched).

	PR tree-optimization/107946
	* params.opt (-param=max-unswitch-depth=): New.
	* doc/invoke.texi (--param=max-unswitch-depth): Document.
	* tree-ssa-loop-unswitch.cc (init_loop_unswitch_info): Honor
	--param=max-unswitch-depth
2022-12-02 08:04:11 +01:00
Eric Gallager
a710f3ce74 PR59447: --with-dwarf2 implies "(or later)"
This patch includes "(or later)" in the documentation of the gcc
subdirectory's --with-dwarf2 configure flag. Closes PR59447.

gcc/ChangeLog:

	PR bootstrap/59447
	* configure: Regenerate.
	* configure.ac: Document --with-dwarf2 flag as also
	applying to later DWARF standards.
	* doc/install.texi: Likewise.
2022-12-02 01:08:45 -05:00
David Malcolm
0b737090a6 analyzer: handle comparisons against negated symbolic values [PR107948]
gcc/analyzer/ChangeLog:
	PR analyzer/107948
	* region-model-manager.cc
	(region_model_manager::maybe_fold_binop): Fold (0 - VAL) to -VAL.
	* region-model.cc (region_model::eval_condition): Handle e.g.
	"-X <= 0" as equivalent to X >= 0".

gcc/testsuite/ChangeLog:
	PR analyzer/107948
	* gcc.dg/analyzer/feasibility-pr107948.c: New test.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
2022-12-01 21:28:55 -05:00
David Malcolm
5cb7d28dcf analyzer: add test coverage for string ops
gcc/testsuite/ChangeLog:
	* gcc.dg/analyzer/string-ops-concat-pair.c: New test.
	* gcc.dg/analyzer/string-ops-dup.c: New test.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
2022-12-01 21:28:55 -05:00
liuhongt
e055e6db97 Fix ICE due to incorrect insn type.
;; if reg/mem op
(define_insn_reservation  "slm_sseishft_3" 2
  (and (eq_attr "cpu" "slm")
       (and (eq_attr "type" "sseishft")
            (not (match_operand 2 "immediate_operand"))))
  "slm-complex, slm-all-eu")

in slm.md it will check operands[2] for type sseishft, but for
extendbfsf2_1 there's no second operand which caused ICE.
The patch set type from sseishft to sseishft1 to fix the issue.

gcc/ChangeLog:

	PR target/107934
	* config/i386/i386.md (extendbfsf2_1): Change type from
	sseishft to sseishft1.

gcc/testsuite/ChangeLog:

	* gcc.target/i386/pr107934.c: New test.
2022-12-02 09:29:10 +08:00
Patrick Palka
a4e577b044 c++: comptypes ICE with BOUND_TEMPLATE_TEMPLATE_PARMs [PR107539]
Here we end up giving the two BOUND_TEMPLATE_TEMPLATE_PARMs
C<decltype(f::t)> and C<decltype(g::t)> the same TYPE_CANONICAL because
the hash table that interns TYPE_CANONICAL for template type parameters
doesn't set the comparing_specializations flag which controls how
PARM_DECLs from different contexts compare equal.

Later, from spec_hasher::equal for the corresponding two specializations
A<C<decltype(f::t)>> and A<C<decltype(g::t)>>, we compare the two bound
ttps with comparing_specializations set hence they now (structurally)
compare different despite having the same TYPE_CANONICAL, and so we get
the error:

  internal compiler error: same canonical type node for different types
    'C<decltype (t)>' and 'C<decltype (t)>'

This suggests that we should be setting comparing_specializations from
ctp_hasher::equal to match spec_hasher::equal.  But doing so introduces
a separate ICE in cpp2a/concepts-placeholder3.C:

  internal compiler error: canonical types differ for identical types
    'auto [requires ::same_as<<placeholder>, decltype(f::x)>]' and
    'auto [requires ::same_as<<placeholder>, decltype(g::x)>]'

because norm_hasher::equal doesn't set comparing_specializations either.

I'm not sure when exactly we need to set comparing_specializations given
what it controls (TYPENAME_TYPE equality/hashing and PARM_DECL equality)
but it seems to be the conservative choice to set the flag wherever we
have a global hash table that relies on type equality.  To that end this
patch sets comparing_specializations in ctp_hasher and norm_hasher, as
well as in atom_hasher and sat_hasher for good measure.  This turns out
to be a compile time win of about 2% in some concepts tests, probably
because of the improved TYPENAME_TYPE hashing enabled by the flag.

	PR c++/107539

gcc/cp/ChangeLog:

	* constraint.cc (norm_hasher::hash, norm_hasher::equal): Set
	comparing_specializations.
	(sat_hasher::hash, sat_hasher::equal): Likewise.
	* cp-tree.h (atom_hasher::hash, atom_hasher::equal): Likewise.
	* pt.cc (ctp_hasher::hash, ctp_hasher::equal): Likewise.

gcc/testsuite/ChangeLog:

	* g++.dg/template/canon-type-19.C: New test.
2022-12-01 20:11:53 -05:00
Björn Schäpers
40adb39566 libstdc++: Add error handler for <stacktrace>
Not providing an error handler results in a null pointer dereference
when an error occurs.

Co-authored-by: Jonathan Wakely <jwakely@redhat.com>

libstdc++-v3/ChangeLog:

	* include/std/stacktrace (stacktrace_entry::_S_err_handler): New
	static function.
	(stacktrace_entry, basic_stacktrace): Pass &_S_err_handler to
	all calls to libbacktrace.
2022-12-02 00:17:42 +00:00
Alex Coplan
de144fdab1 varasm: Fix type confusion bug
This patch fixes a type confusion bug in varasm.cc:assemble_variable.
The problem is that the current code calls:

  sect = get_variable_section (decl, false);

and then accesses sect->named.name without checking whether the section
is in fact a named section. In the surrounding else clause, we only know
that SECTION_STYLE (sect) != SECTION_NOSWITCH, so it is possible that
the section is an unnamed section.

In practice, this means that we end up doing a wild string compare
between a function pointer and the string literal ".vtable_map_vars".
This is because sect->named.name aliases sect->unnamed.callback in the
section union.

This can be seen in GDB with a simple testcase such as "int x;".

This patch fixes the issue by checking the SECTION_STYLE of the section
is in fact SECTION_NAMED before trying to do the string comparison.

We drop the existing check of whether sect->named.name is non-NULL
because this should presumably always be the case for a named section.

gcc/ChangeLog:

	* varasm.cc (assemble_variable): Fix type confusion bug when
	checking for ".vtable_map_vars" section.
2022-12-01 17:36:02 +00:00
Martin Liska
a5354dafb3 gcc: remove incpath.o from CXX_C_OBJS
The object is already included in OBJS (libbackend.a), thus
we don't need it.

gcc/cp/ChangeLog:

	* Make-lang.in: Remove extra object dependency.
2022-12-01 17:22:47 +01:00
Ju-Zhe Zhong
c126e144d4 RISC-V: Remove tail && mask policy operand for vmclr, vmset, vmld, vmst
1. vector.md: remove tail && mask policy operand for mask mode operations since
   we don't need them according to RVV ISA.
2. riscv-v.cc: adapt emit_pred_op for mask mode predicated mov since all RVV modes
   including vector integer mode && vector float mode  && vector bool mode are
   all use emit_pred_op function. For vector integer mode && vector float mode,
   we have instruction like vle.v/vse.v that we need tail && mask policy.
   However, for vector bool mode, the instruction is vlm/vsm that we don't need
   tail && mask policy. So we add a condition here to add tail && mask policy operand
   during expand if it is not a vector bool modes.

This patch is to cleanup the code and make it be consistent with RVV ISA.

gcc/ChangeLog:

	* config/riscv/riscv-v.cc (emit_pred_op): Adapt for mask mode.
	* config/riscv/vector.md: Remove Tail && make policy operand for mask mode mov.
2022-12-02 00:14:22 +08:00
Ju-Zhe Zhong
3b16afeb3f RISC-V: Add attributes for VSETVL PASS
gcc/ChangeLog:

	* config/riscv/riscv-protos.h (enum vlmul_type): New enum.
	(get_vlmul): New function.
	(get_ratio): Ditto.
	* config/riscv/riscv-v.cc (struct mode_vtype_group): New struct.
	(ENTRY): Adapt for attributes.
	(enum vlmul_type): New enum.
	(get_vlmul): New function.
	(get_ratio): New function.
	* config/riscv/riscv-vector-switch.def (ENTRY): Adapt for attributes.
	* config/riscv/riscv.cc (ENTRY): Ditto.
	* config/riscv/vector.md (false,true): Add attributes.
2022-12-02 00:13:45 +08:00
Ju-Zhe Zhong
fa144175c9 RISC-V: Add duplicate vector support.
gcc/ChangeLog:

	* config/riscv/constraints.md (Wdm): New constraint.
	* config/riscv/predicates.md (direct_broadcast_operand): New predicate.
	* config/riscv/riscv-protos.h (RVV_VLMAX): New macro.
	(emit_pred_op): Refine function.
	* config/riscv/riscv-selftests.cc (run_const_vector_selftests): New function.
	(run_broadcast_selftests): Ditto.
	(BROADCAST_TEST): New tests.
	(riscv_run_selftests): More tests.
	* config/riscv/riscv-v.cc (emit_pred_move): Refine function.
	(emit_vlmax_vsetvl): Ditto.
	(emit_pred_op): Ditto.
	(expand_const_vector): New function.
	(legitimize_move): Add constant vector support.
	* config/riscv/riscv.cc (riscv_print_operand): New asm print rule for const vector.
	* config/riscv/riscv.h (X0_REGNUM): New macro.
	* config/riscv/vector-iterators.md: New attribute.
	* config/riscv/vector.md (vec_duplicate<mode>): New pattern.
	(@pred_broadcast<mode>): New pattern.

gcc/testsuite/ChangeLog:

	* gcc.target/riscv/rvv/base/dup-1.c: New test.
	* gcc.target/riscv/rvv/base/dup-2.c: New test.
2022-12-02 00:11:52 +08:00
Paul-Antoine Arras
e41b243302 amdgcn: Add preprocessor builtins for every processor type
Provide a specific builtin for each possible value of '-march'.

gcc/ChangeLog:

	* config/gcn/gcn-opts.h (TARGET_FIJI): -march=fiji.
	(TARGET_VEGA10): -march=gfx900.
	(TARGET_VEGA20): -march=gfx906.
	(TARGET_GFX908): -march=gfx908.
	(TARGET_GFX90a): -march=gfx90a.
	* config/gcn/gcn.h (TARGET_CPU_CPP_BUILTINS): Define a builtin that
	uniquely maps to '-march'.
2022-12-01 15:48:34 +01:00
Eric Botcazou
798c08ca4b ada: Strip conversions for the implementation of storage models
This is necessary for unconstrained allocators with qualified expression.

gcc/ada/

	* gcc-interface/trans.cc (get_storage_model_access): Strip any type
	conversion around the node before looking into it.
2022-12-01 14:53:54 +01:00
Steve Baird
82cf82c461 ada: Enforce Aggregate aspect legality rule
Ada 2022 requires that an Aggregate aspect specification shall specify a
a name for at least one of Add_Named, Add_Unnamed, or Assign_Indexed.
Enforce this rule.

gcc/ada/

	* sem_ch13.adb
	(Validate_Aspect_Aggregate): Reject illegal case where none of
	Add_Named, Add_Unnamed, and Assign_Indexed are specified.
2022-12-01 14:53:54 +01:00
Eric Botcazou
f82d10a548 ada: Further adjustments to User's Guide for PIE default
gcc/ada/

	* doc/gnat_ugn/gnat_and_program_execution.rst (Non-Symbolic
	Traceback): Add compilation line.
	(Symbolic Traceback): Remove obsolete stuff.
	* doc/gnat_ugn/gnat_utility_programs.rst (gnatsymbolize): Adjust.
	* gnat_ugn.texi: Regenerate.
2022-12-01 14:53:54 +01:00
Ronan Desplanques
81fd08ae71 ada: Fix misphrasing in comment
gcc/ada/

	* lib-xref.adb (Generate_Reference): Fix misphrasing in comment.
2022-12-01 14:53:53 +01:00
Gary Dismukes
8e56d311d3 ada: Use the address type of a Storage_Model_Type for 'Address
When an Address attribute applies to an object that is a dereference of
an access value whose type has aspect Designated_Storage_Model, the
attribute will now be treated as having the address type associated
with the Storage_Model_Type of the access type's associated Storage_Model
object instead of being of type System.Address.

gcc/ada/

	* sem_attr.adb (Analyze_Attribute, Attribute_Address): In the case
	where the attribute's prefix is a dereference of a value of an
	access type that has aspect Designated_Storage_Model (or a
	renaming of such a dereference), set the attribute's type to the
	corresponding Storage_Model_Type's associated address type rather
	than System.Address.
2022-12-01 14:53:53 +01:00
Ronan Desplanques
eeba836bf3 ada: Fix minor issues in reference manual
This patch fixes a few minor issues in the GNAT library section of
the reference manual.

gcc/ada/

	* doc/gnat_rm/the_gnat_library.rst: Fix minor issues.
	* gnat_rm.texi: Regenerate.
2022-12-01 14:53:53 +01:00