mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-21 00:11:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

haifa-sched: fix autopref_rank_for_schedule comparator [PR109187]

Browse Source 
Do not attempt to use a plain subtraction for generating a three-way
comparison result in autopref_rank_for_schedule qsort comparator, as
offsets are not restricted and subtraction may overflow.  Open-code
a safe three-way comparison instead.

gcc/ChangeLog:

	PR rtl-optimization/109187
	* haifa-sched.cc (autopref_rank_for_schedule): Avoid use of overflowing
	subtraction in three-way comparison.

gcc/testsuite/ChangeLog:

	PR rtl-optimization/109187
	* gcc.dg/pr109187.c: New test.
This commit is contained in:
Alexander Monakov 2023-03-28 16:00:37 +03:00
parent dd63bba0c8
commit fb046e69f0
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/haifa-sched.cc
View File

@ -5686,7 +5686,7 @@ autopref_rank_for_schedule (const rtx_insn *insn1, const rtx_insn *insn2)
if (!irrel1 && !irrel2)
/* Sort memory references from lowest offset to the largest. */
r = data1->offset - data2->offset;
r = (data1->offset > data2->offset) - (data1->offset < data2->offset);
else if (write)
/* Schedule "irrelevant" insns before memory stores to resolve
as many producer dependencies of stores as possible. */

8
gcc/testsuite/gcc.dg/pr109187.c Normal file
View File

@ -0,0 +1,8 @@
/* { dg-do compile } */
/* { dg-options "-O2 --param sched-autopref-queue-depth=1" } */
void f(int *a)
{
for (;;)
asm("" :: "r"(a[-0x10000000]), "r"(a[0x10000000]), "r"(a[0]) : "memory");
}