mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-05 08:00:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

c++: Fix SEGV with malformed constructor decl.

Browse Source 
In the testcase, since there's no declaration of T, ref_view(T) declares a
non-static data member T of type ref_view, the same type as its enclosing
class.  Then when we try to do C++20 aggregate class template argument
deduction we recursively try to adjust the braced-init-list to match the
template class definition until we run out of stack.

Fixed by rejecting the template data member.

	PR c++/92593
	* decl.c (grokdeclarator): Reject field of current class type even
	in a template.
This commit is contained in:
Jason Merrill 2020-02-04 18:49:16 -05:00
parent efe0e5cd64
commit fa0c6e297b
5 changed files with 26 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2020-02-05 Jason Merrill <jason@redhat.com>
PR c++/92593
* decl.c (grokdeclarator): Reject field of current class type even
in a template.
2020-02-05 Bin Cheng <bin.cheng@linux.alibaba.com>
* coroutines.cc (maybe_promote_captured_temps): Increase the index

11
gcc/cp/decl.c
View File

@ -13259,10 +13259,13 @@ grokdeclarator (const cp_declarator *declarator,
if (declspecs->explicit_specifier)
store_explicit_specifier (decl, declspecs->explicit_specifier);
}
else if (!staticp && !dependent_type_p (type)
&& !COMPLETE_TYPE_P (complete_type (type))
&& (!complete_or_array_type_p (type)
|| initialized == 0))
else if (!staticp
&& ((current_class_type
&& same_type_p (type, current_class_type))
|| (!dependent_type_p (type)
&& !COMPLETE_TYPE_P (complete_type (type))
&& (!complete_or_array_type_p (type)
|| initialized == 0))))
{
if (TREE_CODE (type) != ARRAY_TYPE
|| !COMPLETE_TYPE_P (TREE_TYPE (type)))

10
gcc/testsuite/g++.dg/cpp1z/class-deduction68.C Normal file
View File

@ -0,0 +1,10 @@
// PR c++/92593
// { dg-do compile { target c++17 } }
template<int I>
struct ref_view
{
ref_view(T) { }; // { dg-error "incomplete" }
};
ref_view r{1}; // { dg-error "no match|deduction failed" }

2
gcc/testsuite/g++.dg/parse/undefined3.C
View File

@ -2,5 +2,5 @@
// Origin: Volker Reichelt <reichelt@igpm.rwth-aachen.de>
// { dg-do compile }
template<typename T> struct A { A(B); };
template<typename T> struct A { A(B); }; // { dg-error "incomplete" }
template<typename T> A<T>::A(B) {} // { dg-error "" }

4
gcc/testsuite/g++.dg/template/pr71710.C
View File

@ -3,8 +3,8 @@
template < typename > struct A
{
A a;
A a; // { dg-error "incomplete" }
template < int > using B = decltype (a);
B < 0 > b;
B < 0 > b; // { dg-prune-output "B. does not name a type" }
template < int C > B < C > foo ();
};