mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-02-26 07:35:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

tree-optimization/114471 - ICE with mismatching vector types

Browse Source 
The following fixes too lax verification of vector type compatibility
in vectorizable_operation.  When we only have a single vector size then
comparing the number of elements is enough but with SLP we mix those
and thus for operations like BIT_AND_EXPR we need to verify compatible
element types as well.  Allow sign changes for ABSU_EXPR though.

	PR tree-optimization/114471
	* tree-vect-stmts.cc (vectorizable_operation): Verify operand
	types are compatible with the result type.

	* gcc.dg/vect/pr114471.c: New testcase.
This commit is contained in:
Richard Biener 2024-03-26 09:11:00 +01:00
parent 226a220d00
commit f4e92d62dc
2 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gcc/testsuite/gcc.dg/vect/pr114471.c Normal file
View File

@ -0,0 +1,13 @@
/* { dg-do compile } */
float f1, f0, fa[2];
short sa[2];
void quantize(short s0)
{
_Bool ta[2] = {(fa[0] < 0), (fa[1] < 0)};
_Bool t = ((s0 > 0) & ta[0]);
short x1 = s0 + t;
_Bool t1 = ((x1 > 0) & ta[1]);
sa[0] = x1;
sa[1] = s0 + t1;
}

11
gcc/tree-vect-stmts.cc
View File

@ -6667,7 +6667,8 @@ vectorizable_operation (vec_info *vinfo,
nunits_out = TYPE_VECTOR_SUBPARTS (vectype_out);
nunits_in = TYPE_VECTOR_SUBPARTS (vectype);
if (maybe_ne (nunits_out, nunits_in))
if (maybe_ne (nunits_out, nunits_in)
|| !tree_nop_conversion_p (TREE_TYPE (vectype_out), TREE_TYPE (vectype)))
return false;
tree vectype2 = NULL_TREE, vectype3 = NULL_TREE;
@ -6685,7 +6686,9 @@ vectorizable_operation (vec_info *vinfo,
is_invariant &= (dt[1] == vect_external_def
|| dt[1] == vect_constant_def);
if (vectype2
&& maybe_ne (nunits_out, TYPE_VECTOR_SUBPARTS (vectype2)))
&& (maybe_ne (nunits_out, TYPE_VECTOR_SUBPARTS (vectype2))
|| !tree_nop_conversion_p (TREE_TYPE (vectype_out),
TREE_TYPE (vectype2))))
return false;
}
if (op_type == ternary_op)
@ -6701,7 +6704,9 @@ vectorizable_operation (vec_info *vinfo,
is_invariant &= (dt[2] == vect_external_def
|| dt[2] == vect_constant_def);
if (vectype3
&& maybe_ne (nunits_out, TYPE_VECTOR_SUBPARTS (vectype3)))
&& (maybe_ne (nunits_out, TYPE_VECTOR_SUBPARTS (vectype3))
|| !tree_nop_conversion_p (TREE_TYPE (vectype_out),
TREE_TYPE (vectype3))))
return false;
}