mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-08 00:01:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

[libbacktrace] Reduce memory usage in build_address_map

Browse Source 
In build_address_map we allocate a unit, and then look for addresses in the
unit, which we store in the addrs vector, with the elements pointing to the
unit.  However, if we cannot find addresses in the unit, the allocated unit is
not used.

Fix this by detecting if the allocated unit has been used, and reusing it
otherwise.

Bootstrapped and reg-tested on x86_64.

2018-12-28  Tom de Vries  <tdevries@suse.de>

	* dwarf.c (build_address_map): Reuse unused units.

From-SVN: r267445
This commit is contained in:
Tom de Vries 2018-12-28 03:43:56 +00:00 committed by Tom de Vries
parent d9aa0961ea
commit eb33bf0a0a
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libbacktrace/ChangeLog
View File

@ -1,3 +1,7 @@
2018-12-28 Tom de Vries <tdevries@suse.de>
* dwarf.c (build_address_map): Reuse unused units.
2018-12-28 Tom de Vries <tdevries@suse.de>
* dwarf.c (build_address_map): Simplify by removing local variable

14
libbacktrace/dwarf.c
View File

@ -1436,9 +1436,11 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address,
size_t units_count;
size_t i;
struct unit **pu;
size_t prev_addrs_count;
memset (&addrs->vec, 0, sizeof addrs->vec);
addrs->count = 0;
prev_addrs_count = 0;
/* Read through the .debug_info section. FIXME: Should we use the
.debug_aranges section? gdb and addr2line don't use it, but I'm
@ -1534,6 +1536,18 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address,
if (unit_buf.reported_underflow)
goto fail;
if (addrs->count > prev_addrs_count)
prev_addrs_count = addrs->count;
else
{
/* Unit was not used; remove it from the vector. */
--units_count;
units.size -= sizeof (u);
units.alc += sizeof (u);
free_abbrevs (state, &u->abbrevs, error_callback, data);
backtrace_free (state, u, sizeof *u, error_callback, data);
}
}
if (info.reported_underflow)
goto fail;