From de41ebf5ddab45c643cfe8166c1d274ed4620d4f Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Mon, 11 Jan 2016 17:55:39 +0000 Subject: [PATCH] re PR go/68980 (ps -o cmd in gotest isn't portable) PR 68980 libgo/testsuite: portable ps usage in gotest gotest is using "ps" to list descendant sleep processes in its timeout handling, grepping the command name. We are currently using the "cmd" ps output formatter, which is non-portable. We should use "comm" which is part of the POSIX standard, and outputs only the command name and not the arguments. Fixes https://gcc.gnu.org/PR68980 Reviewed-on: https://go-review.googlesource.com/18426 From-SVN: r232234 --- libgo/testsuite/gotest | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libgo/testsuite/gotest b/libgo/testsuite/gotest index 19cc6bed9740..79e02e2a1ea0 100755 --- a/libgo/testsuite/gotest +++ b/libgo/testsuite/gotest @@ -618,7 +618,7 @@ xno) wait $pid status=$? if ! test -f gotest-timeout; then - sleeppid=`ps -o pid,ppid,cmd | grep " $alarmpid " | grep sleep | sed -e 's/ *\([0-9]*\) .*$/\1/'` + sleeppid=`ps -o pid,ppid,comm | grep " $alarmpid " | grep sleep | sed -e 's/ *\([0-9]*\) .*$/\1/'` kill $alarmpid wait $alarmpid if test "$sleeppid" != ""; then