mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-05 13:51:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

rs6000: Fix ICE in decompose_normal_address. [PR93974]

Browse Source 
Fix an ICE in decompose_normal_address(), which cannot handle Altivec AND:
addresses, by disallowing them via implementing the target hook
rs6000_cannot_substitute_mem_equiv_p.

gcc/
	PR rtl-optimization/93974
	* config/rs6000/rs6000.c (TARGET_CANNOT_SUBSTITUTE_MEM_EQUIV_P): Define.
	(rs6000_cannot_substitute_mem_equiv_p): New function.

gcc/testsuite/
	PR rtl-optimization/93974
	* g++.dg/pr93974.C: New test.
This commit is contained in:
Peter Bergner 2020-04-16 23:26:41 -05:00
parent 5fb9a619ee
commit dd75498db7
4 changed files with 58 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2020-04-16 Peter Bergner <bergner@linux.ibm.com>
PR rtl-optimization/93974
* config/rs6000/rs6000.c (TARGET_CANNOT_SUBSTITUTE_MEM_EQUIV_P): Define.
(rs6000_cannot_substitute_mem_equiv_p): New function.
2020-04-16 Martin Jambor <mjambor@suse.cz>
PR ipa/93621

20
gcc/config/rs6000/rs6000.c
View File

@ -1734,6 +1734,10 @@ static const struct attribute_spec rs6000_attribute_table[] =
#undef TARGET_MANGLE_DECL_ASSEMBLER_NAME
#define TARGET_MANGLE_DECL_ASSEMBLER_NAME rs6000_mangle_decl_assembler_name
#undef TARGET_CANNOT_SUBSTITUTE_MEM_EQUIV_P
#define TARGET_CANNOT_SUBSTITUTE_MEM_EQUIV_P \
rs6000_cannot_substitute_mem_equiv_p
/* Processor table. */
@ -26375,6 +26379,22 @@ rs6000_predict_doloop_p (struct loop *loop)
return true;
}
/* Implement TARGET_CANNOT_SUBSTITUTE_MEM_EQUIV_P. */
static bool
rs6000_cannot_substitute_mem_equiv_p (rtx mem)
{
gcc_assert (MEM_P (mem));
/* curr_insn_transform()'s handling of subregs cannot handle altivec AND:
type addresses, so don't allow MEMs with those address types to be
substituted as an equivalent expression. See PR93974 for details. */
if (GET_CODE (XEXP (mem, 0)) == AND)
return true;
return false;
}
struct gcc_target targetm = TARGET_INITIALIZER;
#include "gt-rs6000.h"

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-04-16 Peter Bergner <bergner@linux.ibm.com>
PR rtl-optimization/93974
* g++.dg/pr93974.C: New test.
2020-04-16 Iain Sandoe <iain@sandoe.co.uk>
* g++.dg/cpp0x/lambda/pr94426-2.C: Adjust scan-asms to test

27
gcc/testsuite/g++.dg/pr93974.C Normal file
View File

@ -0,0 +1,27 @@
/* { dg-do compile } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
/* { dg-options "-mdejagnu-cpu=power8 -O3 -fstack-protector-strong" } */
class a {
double b[2];
public:
a();
};
class c {
public:
typedef a d;
d m_fn1() {
a e;
return e;
}
};
template <typename f> void operator+(f, typename f::d);
void g() {
c connector;
for (;;) {
c cut;
a h = cut.m_fn1();
connector + h;
}
}